From: YueHaibing <yuehaibing@huawei.com> To: <herbert@gondor.apana.org.au>, <davem@davemloft.net> Cc: <linux-crypto@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, YueHaibing <yuehaibing@huawei.com> Subject: [PATCH -next 5/5] crypto: ccree - Remove redundant dev_err call in init_cc_resources() Date: Wed, 7 Apr 2021 22:18:19 +0800 [thread overview] Message-ID: <20210407141819.32588-6-yuehaibing@huawei.com> (raw) In-Reply-To: <20210407141819.32588-1-yuehaibing@huawei.com> There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/crypto/ccree/cc_driver.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/crypto/ccree/cc_driver.c b/drivers/crypto/ccree/cc_driver.c index d0e59e942568..e599ac6dc162 100644 --- a/drivers/crypto/ccree/cc_driver.c +++ b/drivers/crypto/ccree/cc_driver.c @@ -352,10 +352,8 @@ static int init_cc_resources(struct platform_device *plat_dev) req_mem_cc_regs = platform_get_resource(plat_dev, IORESOURCE_MEM, 0); /* Map registers space */ new_drvdata->cc_base = devm_ioremap_resource(dev, req_mem_cc_regs); - if (IS_ERR(new_drvdata->cc_base)) { - dev_err(dev, "Failed to ioremap registers"); + if (IS_ERR(new_drvdata->cc_base)) return PTR_ERR(new_drvdata->cc_base); - } dev_dbg(dev, "Got MEM resource (%s): %pR\n", req_mem_cc_regs->name, req_mem_cc_regs); -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: YueHaibing <yuehaibing@huawei.com> To: <herbert@gondor.apana.org.au>, <davem@davemloft.net> Cc: <linux-crypto@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, YueHaibing <yuehaibing@huawei.com> Subject: [PATCH -next 5/5] crypto: ccree - Remove redundant dev_err call in init_cc_resources() Date: Wed, 7 Apr 2021 22:18:19 +0800 [thread overview] Message-ID: <20210407141819.32588-6-yuehaibing@huawei.com> (raw) In-Reply-To: <20210407141819.32588-1-yuehaibing@huawei.com> There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/crypto/ccree/cc_driver.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/crypto/ccree/cc_driver.c b/drivers/crypto/ccree/cc_driver.c index d0e59e942568..e599ac6dc162 100644 --- a/drivers/crypto/ccree/cc_driver.c +++ b/drivers/crypto/ccree/cc_driver.c @@ -352,10 +352,8 @@ static int init_cc_resources(struct platform_device *plat_dev) req_mem_cc_regs = platform_get_resource(plat_dev, IORESOURCE_MEM, 0); /* Map registers space */ new_drvdata->cc_base = devm_ioremap_resource(dev, req_mem_cc_regs); - if (IS_ERR(new_drvdata->cc_base)) { - dev_err(dev, "Failed to ioremap registers"); + if (IS_ERR(new_drvdata->cc_base)) return PTR_ERR(new_drvdata->cc_base); - } dev_dbg(dev, "Got MEM resource (%s): %pR\n", req_mem_cc_regs->name, req_mem_cc_regs); -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-07 14:18 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-07 14:18 [PATCH -next 0/5] Remove redundant dev_err call YueHaibing 2021-04-07 14:18 ` YueHaibing 2021-04-07 14:18 ` [PATCH -next 1/5] crypto: atmel-tdes - Remove redundant dev_err call in atmel_tdes_probe() YueHaibing 2021-04-07 14:18 ` YueHaibing 2021-04-07 14:18 ` [PATCH -next 2/5] crypto: img-hash - Remove redundant dev_err call in img_hash_probe() YueHaibing 2021-04-07 14:18 ` YueHaibing 2021-04-07 14:18 ` [PATCH -next 3/5] crypto: ux500 - Remove redundant dev_err calls YueHaibing 2021-04-07 14:18 ` YueHaibing 2021-04-07 14:18 ` [PATCH -next 4/5] crypto: keembay " YueHaibing 2021-04-07 14:18 ` YueHaibing 2021-04-07 14:18 ` YueHaibing [this message] 2021-04-07 14:18 ` [PATCH -next 5/5] crypto: ccree - Remove redundant dev_err call in init_cc_resources() YueHaibing 2021-04-16 11:30 ` [PATCH -next 0/5] Remove redundant dev_err call Herbert Xu 2021-04-16 11:30 ` Herbert Xu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210407141819.32588-6-yuehaibing@huawei.com \ --to=yuehaibing@huawei.com \ --cc=davem@davemloft.net \ --cc=herbert@gondor.apana.org.au \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.