From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, David Hildenbrand <david@redhat.com>,
Joel Stanley <joel@jms.id.au>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>, Andrew Jeffery <andrew@aj.id.au>,
Lucas Stach <l.stach@pengutronix.de>,
Russell King <linux+etnaviv@armlinux.org.uk>,
Christian Gmeiner <christian.gmeiner@gmail.com>,
Mike Rapoport <rppt@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
Michal Simek <michal.simek@xilinx.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Peter Collingbourne <pcc@google.com>,
linux-aspeed@lists.ozlabs.org, dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
etnaviv@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Subject: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv
Date: Thu, 8 Apr 2021 11:20:11 +0200 [thread overview]
Message-ID: <20210408092011.52763-3-david@redhat.com> (raw)
In-Reply-To: <20210408092011.52763-1-david@redhat.com>
Random drivers should not override a user configuration of core knobs
(e.g., CONFIG_DMA_CMA=n). Use "imply" instead, to still respect
dependencies and manual overrides.
"This is similar to "select" as it enforces a lower limit on another
symbol except that the "implied" symbol's value may still be set to n
from a direct dependency or with a visible prompt."
Implying DRM_CMA should be sufficient, as that depends on CMA.
Note: If this is a real dependency, we should use "depends on DMA_CMA"
instead - but I assume the driver can work without CMA just fine --
esp. when we wouldn't have HAVE_DMA_CONTIGUOUS right now.
Signed-off-by: David Hildenbrand <david@redhat.com>
---
drivers/gpu/drm/aspeed/Kconfig | 3 +--
drivers/gpu/drm/etnaviv/Kconfig | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/aspeed/Kconfig b/drivers/gpu/drm/aspeed/Kconfig
index 5e95bcea43e9..a055f763d230 100644
--- a/drivers/gpu/drm/aspeed/Kconfig
+++ b/drivers/gpu/drm/aspeed/Kconfig
@@ -6,9 +6,8 @@ config DRM_ASPEED_GFX
depends on MMU
select DRM_KMS_HELPER
select DRM_KMS_CMA_HELPER
- select DMA_CMA if HAVE_DMA_CONTIGUOUS
- select CMA if HAVE_DMA_CONTIGUOUS
select MFD_SYSCON
+ imply DRM_CMA
help
Chose this option if you have an ASPEED AST2500 SOC Display
Controller (aka GFX).
diff --git a/drivers/gpu/drm/etnaviv/Kconfig b/drivers/gpu/drm/etnaviv/Kconfig
index faa7fc68b009..5f5576b7221a 100644
--- a/drivers/gpu/drm/etnaviv/Kconfig
+++ b/drivers/gpu/drm/etnaviv/Kconfig
@@ -9,9 +9,8 @@ config DRM_ETNAVIV
select THERMAL if DRM_ETNAVIV_THERMAL
select TMPFS
select WANT_DEV_COREDUMP
- select CMA if HAVE_DMA_CONTIGUOUS
- select DMA_CMA if HAVE_DMA_CONTIGUOUS
select DRM_SCHED
+ imply DMA_CMA
help
DRM driver for Vivante GPUs.
--
2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, David Hildenbrand <david@redhat.com>,
Joel Stanley <joel@jms.id.au>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>, Andrew Jeffery <andrew@aj.id.au>,
Lucas Stach <l.stach@pengutronix.de>,
Russell King <linux+etnaviv@armlinux.org.uk>,
Christian Gmeiner <christian.gmeiner@gmail.com>,
Mike Rapoport <rppt@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
Michal Simek <michal.simek@xilinx.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Peter Collingbourne <pcc@google.com>,
linux-aspeed@lists.ozlabs.org, dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
etnaviv@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Subject: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv
Date: Thu, 8 Apr 2021 11:20:11 +0200 [thread overview]
Message-ID: <20210408092011.52763-3-david@redhat.com> (raw)
In-Reply-To: <20210408092011.52763-1-david@redhat.com>
Random drivers should not override a user configuration of core knobs
(e.g., CONFIG_DMA_CMA=n). Use "imply" instead, to still respect
dependencies and manual overrides.
"This is similar to "select" as it enforces a lower limit on another
symbol except that the "implied" symbol's value may still be set to n
from a direct dependency or with a visible prompt."
Implying DRM_CMA should be sufficient, as that depends on CMA.
Note: If this is a real dependency, we should use "depends on DMA_CMA"
instead - but I assume the driver can work without CMA just fine --
esp. when we wouldn't have HAVE_DMA_CONTIGUOUS right now.
Signed-off-by: David Hildenbrand <david@redhat.com>
---
drivers/gpu/drm/aspeed/Kconfig | 3 +--
drivers/gpu/drm/etnaviv/Kconfig | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/aspeed/Kconfig b/drivers/gpu/drm/aspeed/Kconfig
index 5e95bcea43e9..a055f763d230 100644
--- a/drivers/gpu/drm/aspeed/Kconfig
+++ b/drivers/gpu/drm/aspeed/Kconfig
@@ -6,9 +6,8 @@ config DRM_ASPEED_GFX
depends on MMU
select DRM_KMS_HELPER
select DRM_KMS_CMA_HELPER
- select DMA_CMA if HAVE_DMA_CONTIGUOUS
- select CMA if HAVE_DMA_CONTIGUOUS
select MFD_SYSCON
+ imply DRM_CMA
help
Chose this option if you have an ASPEED AST2500 SOC Display
Controller (aka GFX).
diff --git a/drivers/gpu/drm/etnaviv/Kconfig b/drivers/gpu/drm/etnaviv/Kconfig
index faa7fc68b009..5f5576b7221a 100644
--- a/drivers/gpu/drm/etnaviv/Kconfig
+++ b/drivers/gpu/drm/etnaviv/Kconfig
@@ -9,9 +9,8 @@ config DRM_ETNAVIV
select THERMAL if DRM_ETNAVIV_THERMAL
select TMPFS
select WANT_DEV_COREDUMP
- select CMA if HAVE_DMA_CONTIGUOUS
- select DMA_CMA if HAVE_DMA_CONTIGUOUS
select DRM_SCHED
+ imply DMA_CMA
help
DRM driver for Vivante GPUs.
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-fbdev@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
David Hildenbrand <david@redhat.com>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-mm@kvack.org,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
Joel Stanley <joel@jms.id.au>,
Russell King <linux+etnaviv@armlinux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
etnaviv@lists.freedesktop.org,
Peter Collingbourne <pcc@google.com>,
linux-arm-kernel@lists.infradead.org,
Andrew Jeffery <andrew@aj.id.au>,
Randy Dunlap <rdunlap@infradead.org>,
Mike Rapoport <rppt@kernel.org>
Subject: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv
Date: Thu, 8 Apr 2021 11:20:11 +0200 [thread overview]
Message-ID: <20210408092011.52763-3-david@redhat.com> (raw)
In-Reply-To: <20210408092011.52763-1-david@redhat.com>
Random drivers should not override a user configuration of core knobs
(e.g., CONFIG_DMA_CMA=n). Use "imply" instead, to still respect
dependencies and manual overrides.
"This is similar to "select" as it enforces a lower limit on another
symbol except that the "implied" symbol's value may still be set to n
from a direct dependency or with a visible prompt."
Implying DRM_CMA should be sufficient, as that depends on CMA.
Note: If this is a real dependency, we should use "depends on DMA_CMA"
instead - but I assume the driver can work without CMA just fine --
esp. when we wouldn't have HAVE_DMA_CONTIGUOUS right now.
Signed-off-by: David Hildenbrand <david@redhat.com>
---
drivers/gpu/drm/aspeed/Kconfig | 3 +--
drivers/gpu/drm/etnaviv/Kconfig | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/aspeed/Kconfig b/drivers/gpu/drm/aspeed/Kconfig
index 5e95bcea43e9..a055f763d230 100644
--- a/drivers/gpu/drm/aspeed/Kconfig
+++ b/drivers/gpu/drm/aspeed/Kconfig
@@ -6,9 +6,8 @@ config DRM_ASPEED_GFX
depends on MMU
select DRM_KMS_HELPER
select DRM_KMS_CMA_HELPER
- select DMA_CMA if HAVE_DMA_CONTIGUOUS
- select CMA if HAVE_DMA_CONTIGUOUS
select MFD_SYSCON
+ imply DRM_CMA
help
Chose this option if you have an ASPEED AST2500 SOC Display
Controller (aka GFX).
diff --git a/drivers/gpu/drm/etnaviv/Kconfig b/drivers/gpu/drm/etnaviv/Kconfig
index faa7fc68b009..5f5576b7221a 100644
--- a/drivers/gpu/drm/etnaviv/Kconfig
+++ b/drivers/gpu/drm/etnaviv/Kconfig
@@ -9,9 +9,8 @@ config DRM_ETNAVIV
select THERMAL if DRM_ETNAVIV_THERMAL
select TMPFS
select WANT_DEV_COREDUMP
- select CMA if HAVE_DMA_CONTIGUOUS
- select DMA_CMA if HAVE_DMA_CONTIGUOUS
select DRM_SCHED
+ imply DMA_CMA
help
DRM driver for Vivante GPUs.
--
2.30.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-04-08 9:20 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 9:20 [PATCH v1 0/2] drivers: don't select DMA_CMA or CMA David Hildenbrand
2021-04-08 9:20 ` David Hildenbrand
2021-04-08 9:20 ` David Hildenbrand
2021-04-08 9:20 ` [PATCH v1 1/2] drivers/video/fbdev: don't select DMA_CMA David Hildenbrand
2021-04-08 9:20 ` David Hildenbrand
2021-04-08 9:20 ` David Hildenbrand
2021-04-08 9:56 ` Mike Rapoport
2021-04-08 9:56 ` Mike Rapoport
2021-04-08 9:56 ` Mike Rapoport
2021-04-08 9:20 ` David Hildenbrand [this message]
2021-04-08 9:20 ` [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv David Hildenbrand
2021-04-08 9:20 ` David Hildenbrand
2021-04-08 9:56 ` Mike Rapoport
2021-04-08 9:56 ` Mike Rapoport
2021-04-08 9:56 ` Mike Rapoport
2021-04-08 9:57 ` David Hildenbrand
2021-04-08 9:57 ` David Hildenbrand
2021-04-08 9:57 ` David Hildenbrand
2021-04-08 10:20 ` Arnd Bergmann
2021-04-08 10:20 ` Arnd Bergmann
2021-04-08 10:20 ` Arnd Bergmann
2021-04-08 10:20 ` Arnd Bergmann
2021-04-08 10:27 ` David Hildenbrand
2021-04-08 10:27 ` David Hildenbrand
2021-04-08 10:27 ` David Hildenbrand
2021-04-08 10:36 ` David Hildenbrand
2021-04-08 10:36 ` David Hildenbrand
2021-04-08 10:36 ` David Hildenbrand
2021-04-08 10:44 ` Arnd Bergmann
2021-04-08 10:44 ` Arnd Bergmann
2021-04-08 10:44 ` Arnd Bergmann
2021-04-08 10:44 ` Arnd Bergmann
2021-04-08 11:00 ` David Hildenbrand
2021-04-08 11:00 ` David Hildenbrand
2021-04-08 11:00 ` David Hildenbrand
2021-04-08 11:44 ` Arnd Bergmann
2021-04-08 11:44 ` Arnd Bergmann
2021-04-08 11:44 ` Arnd Bergmann
2021-04-08 11:44 ` Arnd Bergmann
2021-04-08 12:00 ` David Hildenbrand
2021-04-08 12:00 ` David Hildenbrand
2021-04-08 12:00 ` David Hildenbrand
2021-04-08 12:12 ` Arnd Bergmann
2021-04-08 12:12 ` Arnd Bergmann
2021-04-08 12:12 ` Arnd Bergmann
2021-04-08 12:12 ` Arnd Bergmann
2021-04-08 12:49 ` Linus Walleij
2021-04-08 12:49 ` Linus Walleij
2021-04-08 12:49 ` Linus Walleij
2021-04-08 12:49 ` Linus Walleij
2021-04-08 13:19 ` Arnd Bergmann
2021-04-08 13:19 ` Arnd Bergmann
2021-04-08 13:19 ` Arnd Bergmann
2021-04-08 13:19 ` Arnd Bergmann
2021-04-09 8:07 ` David Hildenbrand
2021-04-09 8:07 ` David Hildenbrand
2021-04-09 8:07 ` David Hildenbrand
2021-04-08 16:44 ` David Hildenbrand
2021-04-08 16:44 ` David Hildenbrand
2021-04-08 16:44 ` David Hildenbrand
2021-04-08 20:29 ` Arnd Bergmann
2021-04-08 20:29 ` Arnd Bergmann
2021-04-08 20:29 ` Arnd Bergmann
2021-04-08 20:29 ` Arnd Bergmann
2021-04-09 8:09 ` David Hildenbrand
2021-04-09 8:09 ` David Hildenbrand
2021-04-09 8:09 ` David Hildenbrand
2021-04-08 21:45 ` Linus Walleij
2021-04-08 21:45 ` Linus Walleij
2021-04-08 21:45 ` Linus Walleij
2021-04-08 21:45 ` Linus Walleij
2021-04-08 11:38 ` Daniel Vetter
2021-04-08 11:38 ` Daniel Vetter
2021-04-08 11:38 ` Daniel Vetter
2021-04-08 16:46 ` Jason Gunthorpe
2021-04-08 16:46 ` Jason Gunthorpe
2021-04-08 16:46 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210408092011.52763-3-david@redhat.com \
--to=david@redhat.com \
--cc=airlied@linux.ie \
--cc=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=christian.gmeiner@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=joel@jms.id.au \
--cc=l.stach@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=masahiroy@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=pcc@google.com \
--cc=rdunlap@infradead.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.