All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Ferruh Yigit <fery@cypress.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Javier Martinez Canillas <javier@dowhile0.org>
Cc: Henrik Rydberg <rydberg@bitmath.org>,
	linux-input@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH 8/8 v3] Input: cyttsp - Flag the device properly
Date: Thu,  8 Apr 2021 15:11:53 +0200	[thread overview]
Message-ID: <20210408131153.3446138-9-linus.walleij@linaro.org> (raw)
In-Reply-To: <20210408131153.3446138-1-linus.walleij@linaro.org>

This device is certainly a very simple touchscreen so
we set INPUT_MT_DIRECT.

The sibling driver for CY8CTMA140 also sets
INPUT_MT_DROP_UNUSED and experimenting with this driver
it clearly does not hurt: the touchscreen is working just
fine so let's set it for this one as well.

Reviewed-by: Javier Martinez Canillas <javier@dowhile0.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ChangeLog v1->v3:
- Collect Javier's Reviewed-by.
---
 drivers/input/touchscreen/cyttsp_core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/cyttsp_core.c b/drivers/input/touchscreen/cyttsp_core.c
index ac412bcb15d8..fb71cd0d2070 100644
--- a/drivers/input/touchscreen/cyttsp_core.c
+++ b/drivers/input/touchscreen/cyttsp_core.c
@@ -672,7 +672,8 @@ struct cyttsp *cyttsp_probe(const struct cyttsp_bus_ops *bus_ops,
 
 	touchscreen_parse_properties(input_dev, true, NULL);
 
-	error = input_mt_init_slots(input_dev, CY_MAX_ID, 0);
+	error = input_mt_init_slots(input_dev, CY_MAX_ID,
+				    INPUT_MT_DIRECT | INPUT_MT_DROP_UNUSED);
 	if (error) {
 		dev_err(dev, "Unable to init MT slots.\n");
 		return ERR_PTR(error);
-- 
2.29.2


  parent reply	other threads:[~2021-04-08 13:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 13:11 [PATCH 0/8 v3] Update CYTTSP driver Linus Walleij
2021-04-08 13:11 ` [PATCH 1/8 v3] Input: cyttsp - Convert bindings to YAML and extend Linus Walleij
2021-04-10  7:44   ` Dmitry Torokhov
2021-04-08 13:11 ` [PATCH 2/8 v3] Input: cyttsp - Probe from compatibles Linus Walleij
2021-04-08 13:11 ` [PATCH 3/8 v3] Input: cyttsp - Obtain regulators Linus Walleij
2021-04-08 13:11 ` [PATCH 4/8 v3] Input: cyttsp - Error message on boot mode exit error Linus Walleij
2021-04-10  7:31   ` Dmitry Torokhov
2021-04-08 13:11 ` [PATCH 5/8 v3] Input: cyttsp - Reduce reset pulse timings Linus Walleij
2021-04-10  7:32   ` Dmitry Torokhov
2021-04-08 13:11 ` [PATCH 6/8 v3] Input: cyttsp - Drop the phys path Linus Walleij
2021-04-10  7:33   ` Dmitry Torokhov
2021-04-08 13:11 ` [PATCH 7/8 v3] Input: cyttsp - Set abs params for ABS_MT_TOUCH_MAJOR Linus Walleij
2021-04-10  7:34   ` Dmitry Torokhov
2021-04-08 13:11 ` Linus Walleij [this message]
2021-04-10  7:41   ` [PATCH 8/8 v3] Input: cyttsp - Flag the device properly Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210408131153.3446138-9-linus.walleij@linaro.org \
    --to=linus.walleij@linaro.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=fery@cypress.com \
    --cc=javier@dowhile0.org \
    --cc=linux-input@vger.kernel.org \
    --cc=rydberg@bitmath.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.