All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cleber Rosa <crosa@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Willian Rampazzo" <willianr@redhat.com>,
	"Eric Auger" <eric.auger@redhat.com>,
	"John Snow" <jsnow@redhat.com>,
	"Willian Rampazzo" <wrampazz@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Beraldo Leal" <bleal@redhat.com>
Subject: [PATCH v3 05/11] Acceptance Tests: add port redirection for ssh by default
Date: Mon, 12 Apr 2021 00:46:38 -0400	[thread overview]
Message-ID: <20210412044644.55083-6-crosa@redhat.com> (raw)
In-Reply-To: <20210412044644.55083-1-crosa@redhat.com>

For users of the LinuxTest class, let's set up the VM with the port
redirection for SSH, instead of requiring each test to set the same
arguments.

It also sets the network device, by default, to virtio-net.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
---
 tests/acceptance/avocado_qemu/__init__.py | 5 ++++-
 tests/acceptance/virtiofs_submounts.py    | 4 ----
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py
index 67f75f66e56..0856880000f 100644
--- a/tests/acceptance/avocado_qemu/__init__.py
+++ b/tests/acceptance/avocado_qemu/__init__.py
@@ -309,10 +309,13 @@ class LinuxTest(Test, LinuxSSHMixIn):
     timeout = 900
     chksum = None
 
-    def setUp(self, ssh_pubkey=None):
+    def setUp(self, ssh_pubkey=None, network_device_type='virtio-net'):
         super(LinuxTest, self).setUp()
         self.vm.add_args('-smp', '2')
         self.vm.add_args('-m', '1024')
+        # The following network device allows for SSH connections
+        self.vm.add_args('-netdev', 'user,id=vnet,hostfwd=:127.0.0.1:0-:22',
+                         '-device', '%s,netdev=vnet' % network_device_type)
         self.set_up_boot()
         if ssh_pubkey is None:
             ssh_pubkey, self.ssh_key = self.set_up_existing_ssh_keys()
diff --git a/tests/acceptance/virtiofs_submounts.py b/tests/acceptance/virtiofs_submounts.py
index bed8ce44dfc..e10a935ac4e 100644
--- a/tests/acceptance/virtiofs_submounts.py
+++ b/tests/acceptance/virtiofs_submounts.py
@@ -207,10 +207,6 @@ def setUp(self):
             self.vm.add_args('-kernel', vmlinuz,
                              '-append', 'console=ttyS0 root=/dev/sda1')
 
-        # Allow us to connect to SSH
-        self.vm.add_args('-netdev', 'user,id=vnet,hostfwd=:127.0.0.1:0-:22',
-                         '-device', 'virtio-net,netdev=vnet')
-
         self.require_accelerator("kvm")
         self.vm.add_args('-accel', 'kvm')
 
-- 
2.30.2



  parent reply	other threads:[~2021-04-12  4:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-12  4:46 [PATCH v3 00/11] Acceptance Test: introduce base class for Linux based tests Cleber Rosa
2021-04-12  4:46 ` [PATCH v3 01/11] tests/acceptance/virtiofs_submounts.py: add missing accel tag Cleber Rosa
2021-04-12  4:46 ` [PATCH v3 02/11] tests/acceptance/virtiofs_submounts.py: evaluate string not length Cleber Rosa
2021-04-12  4:46 ` [PATCH v3 03/11] Python: add utility function for retrieving port redirection Cleber Rosa
2021-05-13 19:10   ` John Snow
2021-04-12  4:46 ` [PATCH v3 04/11] Acceptance Tests: move useful ssh methods to base class Cleber Rosa
2021-04-19 15:22   ` Philippe Mathieu-Daudé
2021-04-12  4:46 ` Cleber Rosa [this message]
2021-04-12  4:46 ` [PATCH v3 06/11] Acceptance Tests: make username/password configurable Cleber Rosa
2021-04-12  4:46 ` [PATCH v3 07/11] Acceptance Tests: set up SSH connection by default after boot for LinuxTest Cleber Rosa
2021-04-19 15:05   ` Auger Eric
2021-04-12  4:46 ` [PATCH v3 08/11] tests/acceptance/virtiofs_submounts.py: remove launch_vm() Cleber Rosa
2021-04-12  4:46 ` [PATCH v3 09/11] Acceptance Tests: add basic documentation on LinuxTest base class Cleber Rosa
2021-04-12  4:46 ` [PATCH v3 10/11] Acceptance Tests: introduce CPU hotplug test Cleber Rosa
2021-04-12  4:46 ` [PATCH v3 11/11] tests/acceptance/virtiofs_submounts.py: fix setup of SSH pubkey Cleber Rosa
2021-04-12 15:08   ` Wainer dos Santos Moschetta
2021-04-12 18:59   ` Willian Rampazzo
2021-04-19 15:03   ` Auger Eric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210412044644.55083-6-crosa@redhat.com \
    --to=crosa@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=bleal@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=willianr@redhat.com \
    --cc=wrampazz@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.