All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nuno Sa <nuno.sa@analog.com>
To: <linux-iio@vger.kernel.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Lars-Peter Clausen <lars@metafoo.de>
Subject: [PATCH 6/7] iio: adis_buffer: don't push data to buffers on failure
Date: Tue, 13 Apr 2021 13:21:04 +0200	[thread overview]
Message-ID: <20210413112105.69458-7-nuno.sa@analog.com> (raw)
In-Reply-To: <20210413112105.69458-1-nuno.sa@analog.com>

There's no point in pushing data to IIO buffers in case 'spi_sync()'
fails.

Signed-off-by: Nuno Sa <nuno.sa@analog.com>
---
 drivers/iio/imu/adis_buffer.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/imu/adis_buffer.c b/drivers/iio/imu/adis_buffer.c
index 7ab15c08889f..73790b71102b 100644
--- a/drivers/iio/imu/adis_buffer.c
+++ b/drivers/iio/imu/adis_buffer.c
@@ -146,9 +146,10 @@ static irqreturn_t adis_trigger_handler(int irq, void *p)
 	}
 
 	ret = spi_sync(adis->spi, &adis->msg);
-	if (ret)
+	if (ret) {
 		dev_err(&adis->spi->dev, "Failed to read data: %d", ret);
-
+		goto irq_done;
+	}
 
 	if (adis->data->has_paging) {
 		adis->current_page = 0;
-- 
2.31.1


  parent reply	other threads:[~2021-04-13 11:19 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13 11:20 [PATCH 0/7] Adis IRQ fixes and minor improvements Nuno Sa
2021-04-13 11:20 ` [PATCH 1/7] iio: adis_buffer: do not return ints in irq handlers Nuno Sa
2021-04-14  7:23   ` Alexandru Ardelean
2021-04-13 11:21 ` [PATCH 2/7] iio: adis16400: " Nuno Sa
2021-04-14  7:23   ` Alexandru Ardelean
2021-04-13 11:21 ` [PATCH 3/7] iio: adis16475: " Nuno Sa
2021-04-14  7:27   ` Alexandru Ardelean
2021-04-15  7:38     ` Sa, Nuno
2021-04-15  8:17       ` Alexandru Ardelean
2021-04-13 11:21 ` [PATCH 4/7] iio: adis16475: re-set max spi transfer Nuno Sa
2021-04-14  7:28   ` Alexandru Ardelean
2021-04-15  7:53     ` Sa, Nuno
2021-04-15  8:16       ` Sa, Nuno
2021-04-18 10:20         ` Jonathan Cameron
2021-04-19  7:47           ` Sa, Nuno
2021-04-19 15:41             ` Jonathan Cameron
2021-04-13 11:21 ` [PATCH 5/7] iio: adis_buffer: check return value on page change Nuno Sa
2021-04-14  7:34   ` Alexandru Ardelean
2021-04-15  7:55     ` Sa, Nuno
2021-04-13 11:21 ` Nuno Sa [this message]
2021-04-14  7:35   ` [PATCH 6/7] iio: adis_buffer: don't push data to buffers on failure Alexandru Ardelean
2021-04-15  7:56     ` Sa, Nuno
2021-04-13 11:21 ` [PATCH 7/7] iio: adis_buffer: update device page after changing it Nuno Sa
2021-04-14  7:38   ` Alexandru Ardelean
2021-04-15  7:58     ` Sa, Nuno
2021-04-15  8:20       ` Alexandru Ardelean
2021-04-14  8:37 ` [PATCH 0/7] Adis IRQ fixes and minor improvements Lars-Peter Clausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210413112105.69458-7-nuno.sa@analog.com \
    --to=nuno.sa@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.