All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carlos Venegas <jose.carlos.venegas.munoz@intel.com>
To: virtio-fs@redhat.com
Cc: qemu-devel@nongnu.org, vgoyal@redhat.com
Subject: [PATCH 1/2] virtiofsd: Allow use "-o xattrmap" without "-o xattr"
Date: Wed, 14 Apr 2021 20:12:06 +0000	[thread overview]
Message-ID: <20210414201207.3612432-2-jose.carlos.venegas.munoz@intel.com> (raw)
In-Reply-To: <20210414201207.3612432-1-jose.carlos.venegas.munoz@intel.com>

When -o xattrmap is used, it will not work unless xattr is enabled.

This patch enables xattr when -o xattrmap is used.

Signed-off-by: Carlos Venegas <jose.carlos.venegas.munoz@intel.com>
---
 tools/virtiofsd/passthrough_ll.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
index ddaf57305c..2337ea5a58 100644
--- a/tools/virtiofsd/passthrough_ll.c
+++ b/tools/virtiofsd/passthrough_ll.c
@@ -3939,6 +3939,7 @@ int main(int argc, char *argv[])
     }
 
     if (lo.xattrmap) {
+        lo.xattr = 1;
         parse_xattrmap(&lo);
     }
 
-- 
2.25.1



WARNING: multiple messages have this Message-ID (diff)
From: Carlos Venegas <jose.carlos.venegas.munoz@intel.com>
To: virtio-fs@redhat.com
Cc: qemu-devel@nongnu.org, vgoyal@redhat.com
Subject: [Virtio-fs] [PATCH 1/2] virtiofsd: Allow use "-o xattrmap" without "-o xattr"
Date: Wed, 14 Apr 2021 20:12:06 +0000	[thread overview]
Message-ID: <20210414201207.3612432-2-jose.carlos.venegas.munoz@intel.com> (raw)
In-Reply-To: <20210414201207.3612432-1-jose.carlos.venegas.munoz@intel.com>

When -o xattrmap is used, it will not work unless xattr is enabled.

This patch enables xattr when -o xattrmap is used.

Signed-off-by: Carlos Venegas <jose.carlos.venegas.munoz@intel.com>
---
 tools/virtiofsd/passthrough_ll.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
index ddaf57305c..2337ea5a58 100644
--- a/tools/virtiofsd/passthrough_ll.c
+++ b/tools/virtiofsd/passthrough_ll.c
@@ -3939,6 +3939,7 @@ int main(int argc, char *argv[])
     }
 
     if (lo.xattrmap) {
+        lo.xattr = 1;
         parse_xattrmap(&lo);
     }
 
-- 
2.25.1


  reply	other threads:[~2021-04-14 20:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-14 20:12 [PATCH 0/2] virtiofsd: Enable xattr if xattrmap is used Carlos Venegas
2021-04-14 20:12 ` [Virtio-fs] " Carlos Venegas
2021-04-14 20:12 ` Carlos Venegas [this message]
2021-04-14 20:12   ` [Virtio-fs] [PATCH 1/2] virtiofsd: Allow use "-o xattrmap" without "-o xattr" Carlos Venegas
2021-04-16 11:05   ` Greg Kurz
2021-04-19 18:55     ` Vivek Goyal
2021-05-06 10:00     ` Dr. David Alan Gilbert
2021-04-14 20:12 ` [PATCH 2/2] virtiofsd: Add help for -o xattr-mapping Carlos Venegas
2021-04-14 20:12   ` [Virtio-fs] " Carlos Venegas
2021-04-14 21:44   ` Connor Kuehl
2021-04-14 21:44     ` Connor Kuehl
2021-04-19 19:07     ` Vivek Goyal
2021-04-19 19:21       ` Connor Kuehl
2021-04-19 19:59         ` Vivek Goyal
2021-04-14 21:47 ` [PATCH 0/2] virtiofsd: Enable xattr if xattrmap is used Connor Kuehl
2021-04-14 21:47   ` [Virtio-fs] " Connor Kuehl
2021-05-06 15:52 ` Dr. David Alan Gilbert
2021-05-06 15:52   ` [Virtio-fs] " Dr. David Alan Gilbert
2021-05-06 15:55   ` Venegas Munoz, Jose Carlos
2021-05-06 15:55     ` [Virtio-fs] " Venegas Munoz, Jose Carlos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210414201207.3612432-2-jose.carlos.venegas.munoz@intel.com \
    --to=jose.carlos.venegas.munoz@intel.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vgoyal@redhat.com \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.