From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org Cc: Dan Williams <dan.j.williams@intel.com>, Vishal Verma <vishal.l.verma@intel.com>, Dave Jiang <dave.jiang@intel.com>, Ira Weiny <ira.weiny@intel.com> Subject: [PATCH v1 1/1] libnvdimm: Don't use GUID APIs against raw buffer Date: Thu, 15 Apr 2021 17:37:54 +0300 [thread overview] Message-ID: <20210415143754.16553-1-andriy.shevchenko@linux.intel.com> (raw) Strictly speaking the comparison between guid_t and raw buffer is not correct. Return to plain memcmp() since the data structures haven't changed to use uuid_t / guid_t the current state of affairs is inconsistent. Either it should be changed altogether or left as is. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/nvdimm/btt_devs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nvdimm/btt_devs.c b/drivers/nvdimm/btt_devs.c index 05feb97e11ce..82bcd2e86a18 100644 --- a/drivers/nvdimm/btt_devs.c +++ b/drivers/nvdimm/btt_devs.c @@ -244,13 +244,14 @@ struct device *nd_btt_create(struct nd_region *nd_region) */ bool nd_btt_arena_is_valid(struct nd_btt *nd_btt, struct btt_sb *super) { + static const u8 null_uuid[16]; const u8 *parent_uuid = nd_dev_to_uuid(&nd_btt->ndns->dev); u64 checksum; if (memcmp(super->signature, BTT_SIG, BTT_SIG_LEN) != 0) return false; - if (!guid_is_null((guid_t *)&super->parent_uuid)) + if (memcmp(super->parent_uuid, null_uuid, 16) != 0) if (memcmp(super->parent_uuid, parent_uuid, 16) != 0) return false; -- 2.30.2 _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org Cc: Dan Williams <dan.j.williams@intel.com>, Vishal Verma <vishal.l.verma@intel.com>, Dave Jiang <dave.jiang@intel.com>, Ira Weiny <ira.weiny@intel.com> Subject: [PATCH v1 1/1] libnvdimm: Don't use GUID APIs against raw buffer Date: Thu, 15 Apr 2021 17:37:54 +0300 [thread overview] Message-ID: <20210415143754.16553-1-andriy.shevchenko@linux.intel.com> (raw) Strictly speaking the comparison between guid_t and raw buffer is not correct. Return to plain memcmp() since the data structures haven't changed to use uuid_t / guid_t the current state of affairs is inconsistent. Either it should be changed altogether or left as is. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/nvdimm/btt_devs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nvdimm/btt_devs.c b/drivers/nvdimm/btt_devs.c index 05feb97e11ce..82bcd2e86a18 100644 --- a/drivers/nvdimm/btt_devs.c +++ b/drivers/nvdimm/btt_devs.c @@ -244,13 +244,14 @@ struct device *nd_btt_create(struct nd_region *nd_region) */ bool nd_btt_arena_is_valid(struct nd_btt *nd_btt, struct btt_sb *super) { + static const u8 null_uuid[16]; const u8 *parent_uuid = nd_dev_to_uuid(&nd_btt->ndns->dev); u64 checksum; if (memcmp(super->signature, BTT_SIG, BTT_SIG_LEN) != 0) return false; - if (!guid_is_null((guid_t *)&super->parent_uuid)) + if (memcmp(super->parent_uuid, null_uuid, 16) != 0) if (memcmp(super->parent_uuid, parent_uuid, 16) != 0) return false; -- 2.30.2
next reply other threads:[~2021-04-15 14:37 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-15 14:37 Andy Shevchenko [this message] 2021-04-15 14:37 ` [PATCH v1 1/1] libnvdimm: Don't use GUID APIs against raw buffer Andy Shevchenko 2021-04-16 17:36 ` Andy Shevchenko 2021-04-16 17:36 ` Andy Shevchenko 2021-04-16 20:08 ` Dan Williams 2021-04-16 20:08 ` Dan Williams 2021-04-16 20:42 ` Andy Shevchenko 2021-04-16 20:42 ` Andy Shevchenko 2021-04-16 22:08 ` Dan Williams 2021-04-16 22:08 ` Dan Williams 2021-04-19 22:56 ` Kaneda, Erik 2021-04-19 22:56 ` Kaneda, Erik 2021-04-20 15:54 ` Moore, Robert 2021-04-20 15:54 ` Moore, Robert
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210415143754.16553-1-andriy.shevchenko@linux.intel.com \ --to=andriy.shevchenko@linux.intel.com \ --cc=dan.j.williams@intel.com \ --cc=dave.jiang@intel.com \ --cc=ira.weiny@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=vishal.l.verma@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.