From: Lee Jones <lee.jones@linaro.org> To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Christian Koenig <christian.koenig@amd.com>, Huang Rui <ray.huang@amd.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, dri-devel@lists.freedesktop.org Subject: [PATCH 27/40] drm/ttm/ttm_device: Demote kernel-doc abuses Date: Fri, 16 Apr 2021 15:37:12 +0100 [thread overview] Message-ID: <20210416143725.2769053-28-lee.jones@linaro.org> (raw) In-Reply-To: <20210416143725.2769053-1-lee.jones@linaro.org> Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/ttm/ttm_device.c:42: warning: Function parameter or member 'ttm_global_mutex' not described in 'DEFINE_MUTEX' drivers/gpu/drm/ttm/ttm_device.c:42: warning: expecting prototype for ttm_global_mutex(). Prototype was for DEFINE_MUTEX() instead drivers/gpu/drm/ttm/ttm_device.c:112: warning: Function parameter or member 'ctx' not described in 'ttm_global_swapout' drivers/gpu/drm/ttm/ttm_device.c:112: warning: Function parameter or member 'gfp_flags' not described in 'ttm_global_swapout' drivers/gpu/drm/ttm/ttm_device.c:112: warning: expecting prototype for A buffer object shrink method that tries to swap out the first(). Prototype was for ttm_global_swapout() instead Cc: Christian Koenig <christian.koenig@amd.com> Cc: Huang Rui <ray.huang@amd.com> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/gpu/drm/ttm/ttm_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_device.c b/drivers/gpu/drm/ttm/ttm_device.c index 9b787b3caeb50..a8bec8358350d 100644 --- a/drivers/gpu/drm/ttm/ttm_device.c +++ b/drivers/gpu/drm/ttm/ttm_device.c @@ -36,7 +36,7 @@ #include "ttm_module.h" -/** +/* * ttm_global_mutex - protecting the global state */ DEFINE_MUTEX(ttm_global_mutex); @@ -104,7 +104,7 @@ static int ttm_global_init(void) return ret; } -/** +/* * A buffer object shrink method that tries to swap out the first * buffer object on the global::swap_lru list. */ -- 2.27.0
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org> To: lee.jones@linaro.org Cc: David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Huang Rui <ray.huang@amd.com>, Christian Koenig <christian.koenig@amd.com> Subject: [PATCH 27/40] drm/ttm/ttm_device: Demote kernel-doc abuses Date: Fri, 16 Apr 2021 15:37:12 +0100 [thread overview] Message-ID: <20210416143725.2769053-28-lee.jones@linaro.org> (raw) In-Reply-To: <20210416143725.2769053-1-lee.jones@linaro.org> Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/ttm/ttm_device.c:42: warning: Function parameter or member 'ttm_global_mutex' not described in 'DEFINE_MUTEX' drivers/gpu/drm/ttm/ttm_device.c:42: warning: expecting prototype for ttm_global_mutex(). Prototype was for DEFINE_MUTEX() instead drivers/gpu/drm/ttm/ttm_device.c:112: warning: Function parameter or member 'ctx' not described in 'ttm_global_swapout' drivers/gpu/drm/ttm/ttm_device.c:112: warning: Function parameter or member 'gfp_flags' not described in 'ttm_global_swapout' drivers/gpu/drm/ttm/ttm_device.c:112: warning: expecting prototype for A buffer object shrink method that tries to swap out the first(). Prototype was for ttm_global_swapout() instead Cc: Christian Koenig <christian.koenig@amd.com> Cc: Huang Rui <ray.huang@amd.com> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/gpu/drm/ttm/ttm_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_device.c b/drivers/gpu/drm/ttm/ttm_device.c index 9b787b3caeb50..a8bec8358350d 100644 --- a/drivers/gpu/drm/ttm/ttm_device.c +++ b/drivers/gpu/drm/ttm/ttm_device.c @@ -36,7 +36,7 @@ #include "ttm_module.h" -/** +/* * ttm_global_mutex - protecting the global state */ DEFINE_MUTEX(ttm_global_mutex); @@ -104,7 +104,7 @@ static int ttm_global_init(void) return ret; } -/** +/* * A buffer object shrink method that tries to swap out the first * buffer object on the global::swap_lru list. */ -- 2.27.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-04-16 14:39 UTC|newest] Thread overview: 235+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-16 14:36 [PATCH 00/40] [Set 16] Rid W=1 warnings from GPU! Lee Jones 2021-04-16 14:36 ` Lee Jones 2021-04-16 14:36 ` Lee Jones 2021-04-16 14:36 ` Lee Jones 2021-04-16 14:36 ` [Nouveau] " Lee Jones 2021-04-16 14:36 ` [PATCH 01/40] drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc Lee Jones 2021-04-16 14:36 ` Lee Jones 2021-04-16 14:36 ` [Nouveau] " Lee Jones 2021-04-19 11:40 ` Karol Herbst 2021-04-19 11:40 ` Karol Herbst 2021-04-19 11:40 ` Karol Herbst 2021-04-16 14:36 ` [PATCH 02/40] drm/nouveau/dispnv50/disp: Remove unused variable 'ret' Lee Jones 2021-04-16 14:36 ` Lee Jones 2021-04-16 14:36 ` [Nouveau] " Lee Jones 2021-04-19 11:42 ` Karol Herbst 2021-04-19 11:42 ` Karol Herbst 2021-04-19 11:42 ` Karol Herbst 2021-04-16 14:36 ` [PATCH 03/40] drm/msm/dp/dp_display: Remove unused variable 'hpd' Lee Jones 2021-04-16 14:36 ` Lee Jones 2021-04-16 14:36 ` [PATCH 04/40] include: drm: drm_atomic: Make use of 'new_plane_state' Lee Jones 2021-04-16 14:36 ` Lee Jones 2021-04-16 14:36 ` [PATCH 05/40] drm/nouveau/nvkm/subdev/volt/gk20a: Demote non-conformant kernel-doc headers Lee Jones 2021-04-16 14:36 ` Lee Jones 2021-04-16 14:36 ` [Nouveau] " Lee Jones 2021-04-19 11:43 ` Karol Herbst 2021-04-19 11:43 ` Karol Herbst 2021-04-19 11:43 ` Karol Herbst 2021-04-16 14:36 ` [PATCH 06/40] drm/nouveau/nvkm/engine/gr/gf100: Demote non-conformant kernel-doc header Lee Jones 2021-04-16 14:36 ` Lee Jones 2021-04-16 14:36 ` [Nouveau] " Lee Jones 2021-04-19 11:43 ` Karol Herbst 2021-04-19 11:43 ` Karol Herbst 2021-04-19 11:43 ` Karol Herbst 2021-04-16 14:36 ` [PATCH 07/40] drm/nouveau/nouveau_bo: Remove unused variables 'dev' Lee Jones 2021-04-16 14:36 ` Lee Jones 2021-04-16 14:36 ` [Nouveau] " Lee Jones 2021-04-19 11:44 ` Karol Herbst 2021-04-19 11:44 ` Karol Herbst 2021-04-19 11:44 ` Karol Herbst 2021-04-16 14:36 ` [PATCH 08/40] drm/nouveau/nouveau_display: Remove set but unused variable 'width' Lee Jones 2021-04-16 14:36 ` Lee Jones 2021-04-16 14:36 ` [Nouveau] " Lee Jones 2021-04-16 14:36 ` [PATCH 09/40] drm/nouveau/dispnv04/crtc: Demote non-conforming kernel-doc headers Lee Jones 2021-04-16 14:36 ` Lee Jones 2021-04-16 14:36 ` [Nouveau] " Lee Jones 2021-04-19 11:45 ` Karol Herbst 2021-04-19 11:45 ` Karol Herbst 2021-04-19 11:45 ` [Nouveau] " Karol Herbst 2021-04-16 14:36 ` [PATCH 10/40] drm/nouveau/dispnv50/disp: Remove unused variable 'ret' from function returning void Lee Jones 2021-04-16 14:36 ` Lee Jones 2021-04-16 14:36 ` [Nouveau] " Lee Jones 2021-04-19 11:46 ` Karol Herbst 2021-04-19 11:46 ` Karol Herbst 2021-04-19 11:46 ` Karol Herbst 2021-04-16 14:36 ` [PATCH 11/40] drm/nouveau/dispnv50/headc57d: Make local function 'headc57d_olut' static Lee Jones 2021-04-16 14:36 ` Lee Jones 2021-04-16 14:36 ` [Nouveau] " Lee Jones 2021-04-19 11:46 ` Karol Herbst 2021-04-19 11:46 ` Karol Herbst 2021-04-19 11:46 ` Karol Herbst 2021-04-16 14:36 ` [PATCH 12/40] drm/nouveau/nv50_display: Remove superfluous prototype for local static functions Lee Jones 2021-04-16 14:36 ` Lee Jones 2021-04-16 14:36 ` [Nouveau] " Lee Jones 2021-04-19 11:46 ` Karol Herbst 2021-04-19 11:46 ` Karol Herbst 2021-04-19 11:46 ` Karol Herbst 2021-04-16 14:36 ` [PATCH 13/40] drm/nouveau/dispnv50/disp: Include header containing our prototypes Lee Jones 2021-04-16 14:36 ` Lee Jones 2021-04-16 14:36 ` [Nouveau] " Lee Jones 2021-04-19 11:49 ` Karol Herbst 2021-04-19 11:49 ` Karol Herbst 2021-04-19 11:49 ` Karol Herbst 2021-04-16 14:36 ` [PATCH 14/40] drm/nouveau/nouveau_ioc32: File headers are not good candidates for kernel-doc Lee Jones 2021-04-16 14:36 ` Lee Jones 2021-04-16 14:36 ` [Nouveau] " Lee Jones 2021-04-19 11:49 ` Karol Herbst 2021-04-19 11:49 ` Karol Herbst 2021-04-19 11:49 ` [Nouveau] " Karol Herbst 2021-04-16 14:37 ` [PATCH 15/40] drm/nouveau/nouveau_svm: Remove unused variable 'ret' from void function Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:37 ` [Nouveau] " Lee Jones 2021-04-19 11:48 ` Karol Herbst 2021-04-19 11:48 ` Karol Herbst 2021-04-19 11:48 ` Karol Herbst 2021-04-16 14:37 ` [PATCH 16/40] drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment block Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:37 ` [Nouveau] " Lee Jones 2021-04-19 11:49 ` Karol Herbst 2021-04-19 11:49 ` Karol Herbst 2021-04-19 11:49 ` Karol Herbst 2021-04-16 14:37 ` [PATCH 17/40] gpu: host1x: bus: Remove superfluous param description 'key' Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:37 ` [PATCH 18/40] drm/omapdrm/omap_irq: Fix a couple of incorrectly documented functions Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-23 12:12 ` Tomi Valkeinen 2021-04-23 12:12 ` Tomi Valkeinen 2021-04-16 14:37 ` [PATCH 19/40] drm/omapdrm/omap_gem: Properly document omap_gem_dumb_map_offset() Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-23 12:12 ` Tomi Valkeinen 2021-04-23 12:12 ` Tomi Valkeinen 2021-04-16 14:37 ` [PATCH 20/40] drm/xlnx/zynqmp_disp: Fix incorrectly documented enum 'zynqmp_disp_id' Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:45 ` Laurent Pinchart 2021-04-16 14:45 ` Laurent Pinchart 2021-04-16 14:45 ` Laurent Pinchart 2021-04-16 14:37 ` [PATCH 21/40] drm/xlnx/zynqmp_dp: Fix a little potential doc-rot Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:46 ` Laurent Pinchart 2021-04-16 14:46 ` Laurent Pinchart 2021-04-16 14:46 ` Laurent Pinchart 2021-04-16 14:37 ` [PATCH 22/40] drm/ttm/ttm_tt: Demote non-conformant kernel-doc header Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 15:34 ` Christian König 2021-04-16 15:34 ` Christian König 2021-04-19 7:32 ` Lee Jones 2021-04-19 7:32 ` Lee Jones 2021-04-16 14:37 ` [PATCH 23/40] drm/ttm/ttm_bo: Fix incorrectly documented function 'ttm_bo_cleanup_refs' Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 15:31 ` Christian König 2021-04-16 15:31 ` Christian König 2021-04-20 21:27 ` Alex Deucher 2021-04-20 21:27 ` Alex Deucher 2021-04-21 7:02 ` Christian König 2021-04-21 7:02 ` Christian König 2021-04-16 14:37 ` [PATCH 24/40] drm/scheduler/sched_entity: Fix some function name disparity Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:37 ` [PATCH 25/40] drm/radeon/radeon_device: Provide function name in kernel-doc header Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 15:51 ` Christian König 2021-04-16 15:51 ` Christian König 2021-04-16 15:51 ` Christian König 2021-04-20 23:56 ` Alex Deucher 2021-04-20 23:56 ` Alex Deucher 2021-04-20 23:56 ` Alex Deucher 2021-04-16 14:37 ` [PATCH 26/40] drm/amd/amdgpu/amdgpu_device: Remove unused variable 'r' Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-20 23:53 ` Alex Deucher 2021-04-20 23:53 ` Alex Deucher 2021-04-20 23:53 ` Alex Deucher 2021-04-16 14:37 ` Lee Jones [this message] 2021-04-16 14:37 ` [PATCH 27/40] drm/ttm/ttm_device: Demote kernel-doc abuses Lee Jones 2021-04-16 15:32 ` Christian König 2021-04-16 15:32 ` Christian König 2021-04-20 8:53 ` Daniel Vetter 2021-04-20 8:53 ` Daniel Vetter 2021-04-22 12:09 ` Christian König 2021-04-22 12:09 ` Christian König 2021-04-16 14:37 ` [PATCH 28/40] drm/panel/panel-raspberrypi-touchscreen: Demote kernel-doc abuse Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:37 ` [PATCH 29/40] drm/amd/amdgpu/amdgpu_fence: Provide description for 'sched_score' Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 15:52 ` Christian König 2021-04-16 15:52 ` Christian König 2021-04-16 15:52 ` Christian König 2021-04-20 23:57 ` Alex Deucher 2021-04-20 23:57 ` Alex Deucher 2021-04-20 23:57 ` Alex Deucher 2021-04-16 14:37 ` [PATCH 30/40] drm/vgem/vgem_drv: Demote kernel-doc abuse Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:37 ` [PATCH 31/40] drm/amd/amdgpu/amdgpu_gart: Correct a couple of function names in the docs Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 15:35 ` Nirmoy 2021-04-16 15:35 ` Nirmoy 2021-04-16 15:35 ` Nirmoy 2021-04-16 15:53 ` Christian König 2021-04-16 15:53 ` Christian König 2021-04-16 15:53 ` Christian König 2021-04-20 23:59 ` Alex Deucher 2021-04-20 23:59 ` Alex Deucher 2021-04-20 23:59 ` Alex Deucher 2021-04-23 8:28 ` Lee Jones 2021-04-23 8:28 ` Lee Jones 2021-04-23 8:28 ` Lee Jones 2021-04-16 14:37 ` [PATCH 32/40] drm/amd/amdgpu/amdgpu_ttm: Fix incorrectly documented function 'amdgpu_ttm_copy_mem_to_mem()' Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 15:53 ` Christian König 2021-04-16 15:53 ` Christian König 2021-04-16 15:53 ` Christian König 2021-04-21 0:00 ` Alex Deucher 2021-04-21 0:00 ` Alex Deucher 2021-04-21 0:00 ` Alex Deucher 2021-04-16 14:37 ` [PATCH 33/40] drm/amd/amdgpu/amdgpu_ring: Provide description for 'sched_score' Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 15:54 ` Christian König 2021-04-16 15:54 ` Christian König 2021-04-16 15:54 ` Christian König 2021-04-21 0:01 ` Alex Deucher 2021-04-21 0:01 ` Alex Deucher 2021-04-21 0:01 ` Alex Deucher 2021-04-16 14:37 ` [PATCH 34/40] drm/exynos/exynos_drm_fimd: Realign function name with its header Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:40 ` Krzysztof Kozlowski 2021-04-16 14:40 ` Krzysztof Kozlowski 2021-04-16 14:40 ` Krzysztof Kozlowski 2021-04-16 14:47 ` Lee Jones 2021-04-16 14:47 ` Lee Jones 2021-04-16 14:47 ` Lee Jones 2021-04-16 14:37 ` [PATCH 35/40] drm/amd/amdgpu/amdgpu_cs: Repair some function naming disparity Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 15:54 ` Christian König 2021-04-16 15:54 ` Christian König 2021-04-16 15:54 ` Christian König 2021-04-21 0:03 ` Alex Deucher 2021-04-21 0:03 ` Alex Deucher 2021-04-21 0:03 ` Alex Deucher 2021-04-16 14:37 ` [PATCH 36/40] drm/exynos/exynos7_drm_decon: Realign function name with its header Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:41 ` Krzysztof Kozlowski 2021-04-16 14:41 ` Krzysztof Kozlowski 2021-04-16 14:41 ` Krzysztof Kozlowski 2021-04-16 14:37 ` [PATCH 37/40] drm/panel/panel-sitronix-st7701: Demote kernel-doc format abuse Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:37 ` [PATCH 38/40] drm/exynos/exynos_drm_ipp: Fix some function name disparity issues Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:42 ` Krzysztof Kozlowski 2021-04-16 14:42 ` Krzysztof Kozlowski 2021-04-16 14:42 ` Krzysztof Kozlowski 2021-04-16 14:37 ` [PATCH 39/40] drm/sti/sti_hdmi: Provide kernel-doc headers with function names Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:37 ` [PATCH 40/40] drm/mediatek/mtk_disp_ccorr: Demote less than half-populated struct header Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:37 ` Lee Jones 2021-04-16 14:37 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210416143725.2769053-28-lee.jones@linaro.org \ --to=lee.jones@linaro.org \ --cc=airlied@linux.ie \ --cc=christian.koenig@amd.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=ray.huang@amd.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.