From: Oleksij Rempel <o.rempel@pengutronix.de> To: Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>, Heiner Kallweit <hkallweit1@gmail.com>, Fugang Duan <fugang.duan@nxp.com> Cc: Oleksij Rempel <o.rempel@pengutronix.de>, kernel@pengutronix.de, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, Fabio Estevam <festevam@gmail.com>, David Jander <david@protonic.nl>, Russell King <linux@armlinux.org.uk>, Philippe Schenker <philippe.schenker@toradex.com> Subject: [PATCH net-next v3 1/6] net: phy: execute genphy_loopback() per default on all PHYs Date: Mon, 19 Apr 2021 15:01:01 +0200 [thread overview] Message-ID: <20210419130106.6707-2-o.rempel@pengutronix.de> (raw) In-Reply-To: <20210419130106.6707-1-o.rempel@pengutronix.de> The generic loopback is really generic and is defined by the 802.3 standard, we should just mandate that drivers implement a custom loopback if the generic one cannot work. Suggested-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- drivers/net/phy/phy_device.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 73d29fd5e03d..320a3e5cd10a 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -1777,6 +1777,9 @@ int phy_loopback(struct phy_device *phydev, bool enable) struct phy_driver *phydrv = to_phy_driver(phydev->mdio.dev.driver); int ret = 0; + if (!phydrv) + return -ENODEV; + mutex_lock(&phydev->lock); if (enable && phydev->loopback_enabled) { @@ -1789,10 +1792,10 @@ int phy_loopback(struct phy_device *phydev, bool enable) goto out; } - if (phydev->drv && phydrv->set_loopback) + if (phydrv->set_loopback) ret = phydrv->set_loopback(phydev, enable); else - ret = -EOPNOTSUPP; + ret = genphy_loopback(phydev, enable); if (ret) goto out; -- 2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: Oleksij Rempel <o.rempel@pengutronix.de> To: Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>, Heiner Kallweit <hkallweit1@gmail.com>, Fugang Duan <fugang.duan@nxp.com> Cc: Oleksij Rempel <o.rempel@pengutronix.de>, kernel@pengutronix.de, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, Fabio Estevam <festevam@gmail.com>, David Jander <david@protonic.nl>, Russell King <linux@armlinux.org.uk>, Philippe Schenker <philippe.schenker@toradex.com> Subject: [PATCH net-next v3 1/6] net: phy: execute genphy_loopback() per default on all PHYs Date: Mon, 19 Apr 2021 15:01:01 +0200 [thread overview] Message-ID: <20210419130106.6707-2-o.rempel@pengutronix.de> (raw) In-Reply-To: <20210419130106.6707-1-o.rempel@pengutronix.de> The generic loopback is really generic and is defined by the 802.3 standard, we should just mandate that drivers implement a custom loopback if the generic one cannot work. Suggested-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- drivers/net/phy/phy_device.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 73d29fd5e03d..320a3e5cd10a 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -1777,6 +1777,9 @@ int phy_loopback(struct phy_device *phydev, bool enable) struct phy_driver *phydrv = to_phy_driver(phydev->mdio.dev.driver); int ret = 0; + if (!phydrv) + return -ENODEV; + mutex_lock(&phydev->lock); if (enable && phydev->loopback_enabled) { @@ -1789,10 +1792,10 @@ int phy_loopback(struct phy_device *phydev, bool enable) goto out; } - if (phydev->drv && phydrv->set_loopback) + if (phydrv->set_loopback) ret = phydrv->set_loopback(phydev, enable); else - ret = -EOPNOTSUPP; + ret = genphy_loopback(phydev, enable); if (ret) goto out; -- 2.29.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-19 13:01 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-19 13:01 [PATCH net-next v3 0/6] provide generic net selftest support Oleksij Rempel 2021-04-19 13:01 ` Oleksij Rempel 2021-04-19 13:01 ` Oleksij Rempel [this message] 2021-04-19 13:01 ` [PATCH net-next v3 1/6] net: phy: execute genphy_loopback() per default on all PHYs Oleksij Rempel 2021-04-19 13:01 ` [PATCH net-next v3 2/6] net: phy: genphy_loopback: add link speed configuration Oleksij Rempel 2021-04-19 13:01 ` Oleksij Rempel 2021-04-19 13:01 ` [PATCH net-next v3 3/6] net: add generic selftest support Oleksij Rempel 2021-04-19 13:01 ` Oleksij Rempel 2021-04-30 6:45 ` Geert Uytterhoeven 2021-04-30 6:45 ` Geert Uytterhoeven 2021-04-30 7:26 ` Oleksij Rempel 2021-04-30 7:26 ` Oleksij Rempel 2021-04-30 7:49 ` Geert Uytterhoeven 2021-04-30 7:49 ` Geert Uytterhoeven 2021-04-30 12:31 ` Andrew Lunn 2021-04-30 12:31 ` Andrew Lunn 2021-04-19 13:01 ` [PATCH net-next v3 4/6] net: fec: make use of generic NET_SELFTESTS library Oleksij Rempel 2021-04-19 13:01 ` Oleksij Rempel 2021-04-19 13:01 ` [PATCH net-next v3 5/6] net: ag71xx: " Oleksij Rempel 2021-04-19 13:01 ` Oleksij Rempel 2021-04-19 13:01 ` [PATCH net-next v3 6/6] net: dsa: enable selftest support for all switches by default Oleksij Rempel 2021-04-19 13:01 ` Oleksij Rempel 2021-04-23 3:18 ` [PATCH net-next v3 0/6] provide generic net selftest support Joakim Zhang 2021-04-23 3:18 ` Joakim Zhang 2021-04-23 4:37 ` Oleksij Rempel 2021-04-23 4:37 ` Oleksij Rempel 2021-04-27 4:48 ` Joakim Zhang 2021-04-27 4:48 ` Joakim Zhang 2021-04-27 7:15 ` Oleksij Rempel 2021-04-27 7:15 ` Oleksij Rempel 2021-04-27 16:40 ` Florian Fainelli 2021-04-27 16:40 ` Florian Fainelli 2021-04-28 8:06 ` Joakim Zhang 2021-04-28 8:06 ` Joakim Zhang 2021-04-28 8:51 ` Oleksij Rempel 2021-04-28 8:51 ` Oleksij Rempel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210419130106.6707-2-o.rempel@pengutronix.de \ --to=o.rempel@pengutronix.de \ --cc=andrew@lunn.ch \ --cc=david@protonic.nl \ --cc=f.fainelli@gmail.com \ --cc=festevam@gmail.com \ --cc=fugang.duan@nxp.com \ --cc=hkallweit1@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=netdev@vger.kernel.org \ --cc=philippe.schenker@toradex.com \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.