All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mahmoud Mandour <ma.mandourr@gmail.com>
To: qemu-devel@nongnu.org
Cc: "open list:virtiofs" <virtio-fs@redhat.com>,
	Mahmoud Mandour <ma.mandourr@gmail.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [PATCH v2 4/7] virtiofsd: Changed allocation of lo_map_elems to GLib's functions
Date: Tue, 20 Apr 2021 17:46:39 +0200	[thread overview]
Message-ID: <20210420154643.58439-5-ma.mandourr@gmail.com> (raw)
In-Reply-To: <20210420154643.58439-1-ma.mandourr@gmail.com>

Replaced (re)allocation of lo_map_elem structs from realloc() to
GLib's g_try_realloc_n() and replaced the respective free() call
with a g_free().

Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 tools/virtiofsd/passthrough_ll.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
index 1553d2ef45..b9260c26d4 100644
--- a/tools/virtiofsd/passthrough_ll.c
+++ b/tools/virtiofsd/passthrough_ll.c
@@ -406,7 +406,7 @@ static void lo_map_init(struct lo_map *map)
 
 static void lo_map_destroy(struct lo_map *map)
 {
-    free(map->elems);
+    g_free(map->elems);
 }
 
 static int lo_map_grow(struct lo_map *map, size_t new_nelems)
@@ -418,7 +418,7 @@ static int lo_map_grow(struct lo_map *map, size_t new_nelems)
         return 1;
     }
 
-    new_elems = realloc(map->elems, sizeof(map->elems[0]) * new_nelems);
+    new_elems = g_try_realloc_n(map->elems, new_nelems, sizeof(map->elems[0]));
     if (!new_elems) {
         return 0;
     }
-- 
2.25.1



WARNING: multiple messages have this Message-ID (diff)
From: Mahmoud Mandour <ma.mandourr@gmail.com>
To: qemu-devel@nongnu.org
Cc: "open list:virtiofs" <virtio-fs@redhat.com>,
	Mahmoud Mandour <ma.mandourr@gmail.com>
Subject: [Virtio-fs] [PATCH v2 4/7] virtiofsd: Changed allocation of lo_map_elems to GLib's functions
Date: Tue, 20 Apr 2021 17:46:39 +0200	[thread overview]
Message-ID: <20210420154643.58439-5-ma.mandourr@gmail.com> (raw)
In-Reply-To: <20210420154643.58439-1-ma.mandourr@gmail.com>

Replaced (re)allocation of lo_map_elem structs from realloc() to
GLib's g_try_realloc_n() and replaced the respective free() call
with a g_free().

Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 tools/virtiofsd/passthrough_ll.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
index 1553d2ef45..b9260c26d4 100644
--- a/tools/virtiofsd/passthrough_ll.c
+++ b/tools/virtiofsd/passthrough_ll.c
@@ -406,7 +406,7 @@ static void lo_map_init(struct lo_map *map)
 
 static void lo_map_destroy(struct lo_map *map)
 {
-    free(map->elems);
+    g_free(map->elems);
 }
 
 static int lo_map_grow(struct lo_map *map, size_t new_nelems)
@@ -418,7 +418,7 @@ static int lo_map_grow(struct lo_map *map, size_t new_nelems)
         return 1;
     }
 
-    new_elems = realloc(map->elems, sizeof(map->elems[0]) * new_nelems);
+    new_elems = g_try_realloc_n(map->elems, new_nelems, sizeof(map->elems[0]));
     if (!new_elems) {
         return 0;
     }
-- 
2.25.1


  parent reply	other threads:[~2021-04-20 15:53 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-20 15:46 [PATCH v2 0/7] virtiofsd: Changed various allocations to GLib functions Mahmoud Mandour
2021-04-20 15:46 ` [PATCH v2 1/7] virtiofsd: Changed allocations of fuse_req " Mahmoud Mandour
2021-04-20 15:46   ` [Virtio-fs] " Mahmoud Mandour
2021-04-20 19:03   ` Vivek Goyal
2021-04-21  0:39     ` Mahmoud Mandour
2021-04-27  9:48       ` Dr. David Alan Gilbert
2021-04-20 15:46 ` [PATCH v2 2/7] virtiofds: Changed allocations of iovec to GLib's functions Mahmoud Mandour
2021-04-20 15:46   ` [Virtio-fs] " Mahmoud Mandour
2021-04-27 10:24   ` Dr. David Alan Gilbert
2021-04-27 10:24     ` [Virtio-fs] " Dr. David Alan Gilbert
2021-04-27 10:53     ` Mahmoud Mandour
2021-04-27 10:53       ` [Virtio-fs] " Mahmoud Mandour
2021-04-27 11:01       ` Dr. David Alan Gilbert
2021-04-27 11:01         ` [Virtio-fs] " Dr. David Alan Gilbert
2021-04-27 11:08         ` Mahmoud Mandour
2021-04-27 11:08           ` [Virtio-fs] " Mahmoud Mandour
2021-04-27 11:33           ` Dr. David Alan Gilbert
2021-04-27 11:33             ` [Virtio-fs] " Dr. David Alan Gilbert
2021-04-27 18:13             ` [PATCH v3 2/7] virtiofsd: " Mahmoud Mandour
2021-04-27 18:13               ` [Virtio-fs] " Mahmoud Mandour
2021-05-06  9:39               ` Dr. David Alan Gilbert
2021-05-06  9:39                 ` [Virtio-fs] " Dr. David Alan Gilbert
2021-04-27 18:19             ` [PATCH v2 2/7] virtiofds: " Mahmoud Mandour
2021-04-27 18:19               ` [Virtio-fs] " Mahmoud Mandour
2021-04-27 18:41               ` Dr. David Alan Gilbert
2021-04-27 18:41                 ` [Virtio-fs] " Dr. David Alan Gilbert
2021-04-27 10:57     ` Daniel P. Berrangé
2021-04-27 10:57       ` [Virtio-fs] " Daniel P. Berrangé
2021-04-20 15:46 ` [PATCH v2 3/7] virtiofsd: Changed allocations of fuse_session " Mahmoud Mandour
2021-04-20 15:46   ` [Virtio-fs] " Mahmoud Mandour
2021-04-20 15:46 ` Mahmoud Mandour [this message]
2021-04-20 15:46   ` [Virtio-fs] [PATCH v2 4/7] virtiofsd: Changed allocation of lo_map_elems " Mahmoud Mandour
2021-04-20 15:46 ` [PATCH v2 5/7] virtiofsd: Changed allocations of fv_VuDev & its internals to GLib functions Mahmoud Mandour
2021-04-20 15:46   ` [Virtio-fs] " Mahmoud Mandour
2021-04-20 15:46 ` [PATCH v2 6/7] virtiofsd/passthrough_ll.c: Changed local allocations " Mahmoud Mandour
2021-04-20 15:46   ` [Virtio-fs] " Mahmoud Mandour
2021-04-20 15:46 ` [PATCH v2 7/7] virtiofsd/fuse_virtio.c: Changed allocations of locals to GLib Mahmoud Mandour
2021-04-20 15:46   ` [Virtio-fs] " Mahmoud Mandour
2021-05-06 16:27 ` [PATCH v2 0/7] virtiofsd: Changed various allocations to GLib functions Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210420154643.58439-5-ma.mandourr@gmail.com \
    --to=ma.mandourr@gmail.com \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.