All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Thiery <heiko.thiery@gmail.com>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Stephen Hemminger <stephen@networkplumber.org>,
	Petr Vorel <petr.vorel@gmail.com>,
	Heiko Thiery <heiko.thiery@gmail.com>
Subject: [PATCH] lib/fs: fix issue when {name, open}_to_handle_at() is not implemented
Date: Thu, 22 Apr 2021 10:46:13 +0200	[thread overview]
Message-ID: <20210422084612.26374-1-heiko.thiery@gmail.com> (raw)

With commit d5e6ee0dac64b64e the usage of functions name_to_handle_at() and
open_by_handle_at() are introduced. But these function are not available
e.g. in uclibc-ng < 1.0.35. To have a backward compatibility check for the
availability in the configure script and in case of absence do a direct
syscall.

Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
---
 configure | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 lib/fs.c  | 25 ++++++++++++++++++++++++
 2 files changed, 83 insertions(+)

diff --git a/configure b/configure
index 2c363d3b..f1be9977 100755
--- a/configure
+++ b/configure
@@ -202,6 +202,58 @@ EOF
     rm -f $TMPDIR/setnstest.c $TMPDIR/setnstest
 }
 
+check_name_to_handle_at()
+{
+
+    cat >$TMPDIR/name_to_handle_at_test.c <<EOF
+#include <sys/types.h>
+#include <sys/stat.h>
+#include <fcntl.h>
+int main(int argc, char **argv)
+{
+	struct file_handle *fhp;
+	int mount_id, flags, dirfd;
+	char *pathname;
+	name_to_handle_at(dirfd, pathname, fhp, &mount_id, flags);
+	return 0;
+}
+EOF
+
+    if $CC -I$INCLUDE -o $TMPDIR/name_to_handle_at_test $TMPDIR/name_to_handle_at_test.c >/dev/null 2>&1; then
+	echo "IP_CONFIG_NAME_TO_HANDLE_AT:=y" >>$CONFIG
+	echo "yes"
+	echo "CFLAGS += -DHAVE_NAME_TO_HANDLE_AT" >>$CONFIG
+    else
+	echo "no"
+    fi
+    rm -f $TMPDIR/name_to_handle_at_test.c $TMPDIR/name_to_handle_at_test
+}
+
+check_open_by_handle_at()
+{
+
+    cat >$TMPDIR/open_by_handle_at_test.c <<EOF
+#include <sys/types.h>
+#include <sys/stat.h>
+#include <fcntl.h>
+int main(int argc, char **argv)
+{
+	struct file_handle *fhp;
+	int mount_fd;
+	open_by_handle_at(mount_fd, fhp, O_RDONLY);
+	return 0;
+}
+EOF
+    if $CC -I$INCLUDE -o $TMPDIR/open_by_handle_at_test $TMPDIR/open_by_handle_at_test.c >/dev/null 2>&1; then
+	echo "IP_CONFIG_OPEN_BY_HANDLE_AT:=y" >>$CONFIG
+	echo "yes"
+	echo "CFLAGS += -DHAVE_OPEN_BY_HANDLE_AT" >>$CONFIG
+    else
+	echo "no"
+    fi
+    rm -f $TMPDIR/open_by_handle_at_test.c $TMPDIR/open_by_handle_at_test
+}
+
 check_ipset()
 {
     cat >$TMPDIR/ipsettest.c <<EOF
@@ -492,6 +544,12 @@ fi
 echo -n "libc has setns: "
 check_setns
 
+echo -n "libc has name_to_handle_at: "
+check_name_to_handle_at
+
+echo -n "libc has open_by_handle_at: "
+check_open_by_handle_at
+
 echo -n "SELinux support: "
 check_selinux
 
diff --git a/lib/fs.c b/lib/fs.c
index ee0b130b..c561d85b 100644
--- a/lib/fs.c
+++ b/lib/fs.c
@@ -30,6 +30,31 @@
 /* if not already mounted cgroup2 is mounted here for iproute2's use */
 #define MNT_CGRP2_PATH  "/var/run/cgroup2"
 
+
+#if (!defined HAVE_NAME_TO_HANDLE_AT && !defined HAVE_OPEN_BY_HANDLE_AT)
+struct file_handle {
+	unsigned handle_bytes;
+	int handle_type;
+	unsigned char f_handle[];
+};
+#endif
+
+#ifndef HAVE_NAME_TO_HANDLE_AT
+int name_to_handle_at(int dirfd, const char *pathname,
+	struct file_handle *handle, int *mount_id, int flags)
+{
+	return syscall(name_to_handle_at, 5, dirfd, pathname, handle,
+	               mount_id, flags);
+}
+#endif
+
+#ifndef HAVE_OPEN_BY_HANDLE_AT
+int open_by_handle_at(int mount_fd, struct file_handle *handle, int flags)
+{
+	return syscall(open_by_handle_at, 3, mount_fd, handle, flags);
+}
+#endif
+
 /* return mount path of first occurrence of given fstype */
 static char *find_fs_mount(const char *fs_to_find)
 {
-- 
2.30.0


             reply	other threads:[~2021-04-22  8:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22  8:46 Heiko Thiery [this message]
2021-04-29 19:19 ` [PATCH] lib/fs: fix issue when {name, open}_to_handle_at() is not implemented Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210422084612.26374-1-heiko.thiery@gmail.com \
    --to=heiko.thiery@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=petr.vorel@gmail.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.