From: Ming Lei <ming.lei@redhat.com> To: Jens Axboe <axboe@kernel.dk> Cc: linux-block@vger.kernel.org, Jeffle Xu <jefflexu@linux.alibaba.com>, Mike Snitzer <snitzer@redhat.com>, dm-devel@redhat.com, Hannes Reinecke <hare@suse.de>, Ming Lei <ming.lei@redhat.com> Subject: [PATCH V6 00/12] block: support bio based io polling Date: Thu, 22 Apr 2021 20:20:26 +0800 [thread overview] Message-ID: <20210422122038.2192933-1-ming.lei@redhat.com> (raw) Hi Jens, Add per-task io poll context for holding HIPRI blk-mq/underlying bios queued from bio based driver's io submission context, and reuse one bio padding field for storing 'cookie' returned from submit_bio() for these bios. Also explicitly end these bios in poll context by adding two new bio flags. In this way, we needn't to poll all underlying hw queues any more, which is implemented in Jeffle's patches. And we can just poll hw queues in which there is HIPRI IO queued. Usually io submission and io poll share same context, so the added io poll context data is just like one stack variable, and the cost for saving bios is cheap. V6: - move poll code into block/blk-poll.c, as suggested by Christoph - define bvec_iter as __packed, and add one new field to bio, as suggested by Christoph - re-organize patch order, as suggested by Christoph - add one flag for checking if the disk is capable of bio polling and remove .poll_capable(), as suggested by Christoph - fix type of .bi_poll V5: - fix one use-after-free issue in case that polling is from another context: adds one new cookie of BLK_QC_T_NOT_READY for preventing this issue in patch 8/12 - add reviewed-by & tested-by tag V4: - cover one more test_bit(QUEUE_FLAG_POLL, ...) suggested by Jeffle(01/12) - drop patch of 'block: add helper of blk_create_io_context' - add new helper of blk_create_io_poll_context() (03/12) - drain submission queues in exit_io_context(), suggested by Jeffle(08/13) - considering shared io context case for blk_bio_poll_io_drain() (08/13) - fix one issue in blk_bio_poll_pack_groups() as suggested by Jeffle(08/13) - add reviewed-by tag V3: - fix cookie returned for bio based driver, as suggested by Jeffle Xu - draining pending bios when submission context is exiting - patch style and comment fix, as suggested by Mike - allow poll context data to be NULL by always polling on submission queue - remove RFC, and reviewed-by V2: - address queue depth scalability issue reported by Jeffle via bio group list. Reuse .bi_end_io for linking bios which share same .bi_end_io, and support 32 such groups in submit queue. With this way, the scalability issue caused by kfifio is solved. Before really ending bio, .bi_end_io is recovered from the group head. Jeffle Xu (2): block: extract one helper function polling hw queue dm: support IO polling for bio-based dm device Ming Lei (10): block: add helper of blk_queue_poll block: define 'struct bvec_iter' as packed block: add one helper to free io_context block: move block polling code into one dedicated source file block: prepare for supporting bio_list via other link block: create io poll context for submission and poll task block: add req flag of REQ_POLL_CTX block: use per-task poll context to implement bio based io polling block: limit hw queues to be polled in each blk_poll() block: allow to control FLAG_POLL via sysfs for bio poll capable queue block/Makefile | 3 +- block/bio.c | 5 + block/blk-core.c | 68 +++- block/blk-ioc.c | 15 +- block/blk-mq.c | 231 ------------- block/blk-mq.h | 40 +++ block/blk-poll.c | 632 ++++++++++++++++++++++++++++++++++ block/blk-sysfs.c | 16 +- block/blk.h | 112 ++++++ drivers/md/dm-table.c | 24 ++ drivers/md/dm.c | 2 + drivers/nvme/host/core.c | 2 +- include/linux/bio.h | 132 +++---- include/linux/blk_types.h | 31 +- include/linux/blkdev.h | 1 + include/linux/bvec.h | 2 +- include/linux/device-mapper.h | 1 + include/linux/genhd.h | 2 + include/linux/iocontext.h | 2 + 19 files changed, 1003 insertions(+), 318 deletions(-) create mode 100644 block/blk-poll.c -- 2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com> To: Jens Axboe <axboe@kernel.dk> Cc: Mike Snitzer <snitzer@redhat.com>, Ming Lei <ming.lei@redhat.com>, linux-block@vger.kernel.org, dm-devel@redhat.com, Jeffle Xu <jefflexu@linux.alibaba.com> Subject: [dm-devel] [PATCH V6 00/12] block: support bio based io polling Date: Thu, 22 Apr 2021 20:20:26 +0800 [thread overview] Message-ID: <20210422122038.2192933-1-ming.lei@redhat.com> (raw) Hi Jens, Add per-task io poll context for holding HIPRI blk-mq/underlying bios queued from bio based driver's io submission context, and reuse one bio padding field for storing 'cookie' returned from submit_bio() for these bios. Also explicitly end these bios in poll context by adding two new bio flags. In this way, we needn't to poll all underlying hw queues any more, which is implemented in Jeffle's patches. And we can just poll hw queues in which there is HIPRI IO queued. Usually io submission and io poll share same context, so the added io poll context data is just like one stack variable, and the cost for saving bios is cheap. V6: - move poll code into block/blk-poll.c, as suggested by Christoph - define bvec_iter as __packed, and add one new field to bio, as suggested by Christoph - re-organize patch order, as suggested by Christoph - add one flag for checking if the disk is capable of bio polling and remove .poll_capable(), as suggested by Christoph - fix type of .bi_poll V5: - fix one use-after-free issue in case that polling is from another context: adds one new cookie of BLK_QC_T_NOT_READY for preventing this issue in patch 8/12 - add reviewed-by & tested-by tag V4: - cover one more test_bit(QUEUE_FLAG_POLL, ...) suggested by Jeffle(01/12) - drop patch of 'block: add helper of blk_create_io_context' - add new helper of blk_create_io_poll_context() (03/12) - drain submission queues in exit_io_context(), suggested by Jeffle(08/13) - considering shared io context case for blk_bio_poll_io_drain() (08/13) - fix one issue in blk_bio_poll_pack_groups() as suggested by Jeffle(08/13) - add reviewed-by tag V3: - fix cookie returned for bio based driver, as suggested by Jeffle Xu - draining pending bios when submission context is exiting - patch style and comment fix, as suggested by Mike - allow poll context data to be NULL by always polling on submission queue - remove RFC, and reviewed-by V2: - address queue depth scalability issue reported by Jeffle via bio group list. Reuse .bi_end_io for linking bios which share same .bi_end_io, and support 32 such groups in submit queue. With this way, the scalability issue caused by kfifio is solved. Before really ending bio, .bi_end_io is recovered from the group head. Jeffle Xu (2): block: extract one helper function polling hw queue dm: support IO polling for bio-based dm device Ming Lei (10): block: add helper of blk_queue_poll block: define 'struct bvec_iter' as packed block: add one helper to free io_context block: move block polling code into one dedicated source file block: prepare for supporting bio_list via other link block: create io poll context for submission and poll task block: add req flag of REQ_POLL_CTX block: use per-task poll context to implement bio based io polling block: limit hw queues to be polled in each blk_poll() block: allow to control FLAG_POLL via sysfs for bio poll capable queue block/Makefile | 3 +- block/bio.c | 5 + block/blk-core.c | 68 +++- block/blk-ioc.c | 15 +- block/blk-mq.c | 231 ------------- block/blk-mq.h | 40 +++ block/blk-poll.c | 632 ++++++++++++++++++++++++++++++++++ block/blk-sysfs.c | 16 +- block/blk.h | 112 ++++++ drivers/md/dm-table.c | 24 ++ drivers/md/dm.c | 2 + drivers/nvme/host/core.c | 2 +- include/linux/bio.h | 132 +++---- include/linux/blk_types.h | 31 +- include/linux/blkdev.h | 1 + include/linux/bvec.h | 2 +- include/linux/device-mapper.h | 1 + include/linux/genhd.h | 2 + include/linux/iocontext.h | 2 + 19 files changed, 1003 insertions(+), 318 deletions(-) create mode 100644 block/blk-poll.c -- 2.29.2 -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
next reply other threads:[~2021-04-22 12:22 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-22 12:20 Ming Lei [this message] 2021-04-22 12:20 ` [dm-devel] [PATCH V6 00/12] block: support bio based io polling Ming Lei 2021-04-22 12:20 ` [PATCH V6 01/12] block: add helper of blk_queue_poll Ming Lei 2021-04-22 12:20 ` [dm-devel] " Ming Lei 2021-04-22 12:20 ` [PATCH V6 02/12] block: define 'struct bvec_iter' as packed Ming Lei 2021-04-22 12:20 ` [dm-devel] " Ming Lei 2021-04-22 13:18 ` Hannes Reinecke 2021-04-22 13:18 ` [dm-devel] " Hannes Reinecke 2021-04-22 12:20 ` [PATCH V6 03/12] block: add one helper to free io_context Ming Lei 2021-04-22 12:20 ` [dm-devel] " Ming Lei 2021-04-22 12:20 ` [PATCH V6 04/12] block: move block polling code into one dedicated source file Ming Lei 2021-04-22 12:20 ` [dm-devel] " Ming Lei 2021-04-22 13:19 ` Hannes Reinecke 2021-04-22 13:19 ` [dm-devel] " Hannes Reinecke 2021-04-26 7:12 ` Hannes Reinecke 2021-04-26 7:12 ` [dm-devel] " Hannes Reinecke 2021-04-22 12:20 ` [PATCH V6 05/12] block: extract one helper function polling hw queue Ming Lei 2021-04-22 12:20 ` [dm-devel] " Ming Lei 2021-04-22 12:20 ` [PATCH V6 06/12] block: prepare for supporting bio_list via other link Ming Lei 2021-04-22 12:20 ` [dm-devel] " Ming Lei 2021-04-22 12:20 ` [PATCH V6 07/12] block: create io poll context for submission and poll task Ming Lei 2021-04-22 12:20 ` [dm-devel] " Ming Lei 2021-04-22 12:20 ` [PATCH V6 08/12] block: add req flag of REQ_POLL_CTX Ming Lei 2021-04-22 12:20 ` [dm-devel] " Ming Lei 2021-04-22 12:20 ` [PATCH V6 09/12] block: use per-task poll context to implement bio based io polling Ming Lei 2021-04-22 12:20 ` [dm-devel] " Ming Lei 2021-04-26 7:17 ` Hannes Reinecke 2021-04-26 7:17 ` [dm-devel] " Hannes Reinecke 2021-04-22 12:20 ` [PATCH V6 10/12] block: limit hw queues to be polled in each blk_poll() Ming Lei 2021-04-22 12:20 ` [dm-devel] " Ming Lei 2021-04-26 7:19 ` Hannes Reinecke 2021-04-26 7:19 ` [dm-devel] " Hannes Reinecke 2021-04-26 8:00 ` Ming Lei 2021-04-26 8:00 ` [dm-devel] " Ming Lei 2021-04-26 9:05 ` Hannes Reinecke 2021-04-26 9:05 ` [dm-devel] " Hannes Reinecke 2021-04-22 12:20 ` [PATCH V6 11/12] block: allow to control FLAG_POLL via sysfs for bio poll capable queue Ming Lei 2021-04-22 12:20 ` [dm-devel] " Ming Lei 2021-04-26 7:20 ` Hannes Reinecke 2021-04-26 7:20 ` [dm-devel] " Hannes Reinecke 2021-04-22 12:20 ` [PATCH V6 12/12] dm: support IO polling for bio-based dm device Ming Lei 2021-04-22 12:20 ` [dm-devel] " Ming Lei 2021-04-23 1:32 ` JeffleXu 2021-04-23 1:32 ` [dm-devel] " JeffleXu 2021-04-23 2:39 ` Ming Lei 2021-04-23 2:39 ` [dm-devel] " Ming Lei 2021-04-23 2:38 ` [PATCH V7 " Ming Lei 2021-04-23 2:38 ` [dm-devel] " Ming Lei 2021-05-17 6:16 ` [PATCH V6 00/12] block: support bio based io polling JeffleXu 2021-05-17 6:16 ` [dm-devel] " JeffleXu 2021-05-17 7:13 ` Ming Lei 2021-05-17 7:13 ` [dm-devel] " Ming Lei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210422122038.2192933-1-ming.lei@redhat.com \ --to=ming.lei@redhat.com \ --cc=axboe@kernel.dk \ --cc=dm-devel@redhat.com \ --cc=hare@suse.de \ --cc=jefflexu@linux.alibaba.com \ --cc=linux-block@vger.kernel.org \ --cc=snitzer@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.