From: Ming Lei <ming.lei@redhat.com> To: Jens Axboe <axboe@kernel.dk> Cc: linux-block@vger.kernel.org, Jeffle Xu <jefflexu@linux.alibaba.com>, Mike Snitzer <snitzer@redhat.com>, dm-devel@redhat.com, Hannes Reinecke <hare@suse.de>, Ming Lei <ming.lei@redhat.com>, Christoph Hellwig <hch@lst.de> Subject: [PATCH V6 02/12] block: define 'struct bvec_iter' as packed Date: Thu, 22 Apr 2021 20:20:28 +0800 [thread overview] Message-ID: <20210422122038.2192933-3-ming.lei@redhat.com> (raw) In-Reply-To: <20210422122038.2192933-1-ming.lei@redhat.com> 'struct bvec_iter' is embedded into 'struct bio', define it as packed so that we can get one extra 4bytes for other uses without expanding bio. 'struct bvec_iter' is often allocated on stack, so making it packed doesn't affect performance. Also I have run io_uring on both nvme/null_blk, and not observe performance effect in this way. Suggested-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Ming Lei <ming.lei@redhat.com> --- include/linux/bvec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/bvec.h b/include/linux/bvec.h index ff832e698efb..a0c4f41dfc83 100644 --- a/include/linux/bvec.h +++ b/include/linux/bvec.h @@ -43,7 +43,7 @@ struct bvec_iter { unsigned int bi_bvec_done; /* number of bytes completed in current bvec */ -}; +} __packed; struct bvec_iter_all { struct bio_vec bv; -- 2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com> To: Jens Axboe <axboe@kernel.dk> Cc: Mike Snitzer <snitzer@redhat.com>, Ming Lei <ming.lei@redhat.com>, linux-block@vger.kernel.org, dm-devel@redhat.com, Jeffle Xu <jefflexu@linux.alibaba.com>, Christoph Hellwig <hch@lst.de> Subject: [dm-devel] [PATCH V6 02/12] block: define 'struct bvec_iter' as packed Date: Thu, 22 Apr 2021 20:20:28 +0800 [thread overview] Message-ID: <20210422122038.2192933-3-ming.lei@redhat.com> (raw) In-Reply-To: <20210422122038.2192933-1-ming.lei@redhat.com> 'struct bvec_iter' is embedded into 'struct bio', define it as packed so that we can get one extra 4bytes for other uses without expanding bio. 'struct bvec_iter' is often allocated on stack, so making it packed doesn't affect performance. Also I have run io_uring on both nvme/null_blk, and not observe performance effect in this way. Suggested-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Ming Lei <ming.lei@redhat.com> --- include/linux/bvec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/bvec.h b/include/linux/bvec.h index ff832e698efb..a0c4f41dfc83 100644 --- a/include/linux/bvec.h +++ b/include/linux/bvec.h @@ -43,7 +43,7 @@ struct bvec_iter { unsigned int bi_bvec_done; /* number of bytes completed in current bvec */ -}; +} __packed; struct bvec_iter_all { struct bio_vec bv; -- 2.29.2 -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-04-22 12:21 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-22 12:20 [PATCH V6 00/12] block: support bio based io polling Ming Lei 2021-04-22 12:20 ` [dm-devel] " Ming Lei 2021-04-22 12:20 ` [PATCH V6 01/12] block: add helper of blk_queue_poll Ming Lei 2021-04-22 12:20 ` [dm-devel] " Ming Lei 2021-04-22 12:20 ` Ming Lei [this message] 2021-04-22 12:20 ` [dm-devel] [PATCH V6 02/12] block: define 'struct bvec_iter' as packed Ming Lei 2021-04-22 13:18 ` Hannes Reinecke 2021-04-22 13:18 ` [dm-devel] " Hannes Reinecke 2021-04-22 12:20 ` [PATCH V6 03/12] block: add one helper to free io_context Ming Lei 2021-04-22 12:20 ` [dm-devel] " Ming Lei 2021-04-22 12:20 ` [PATCH V6 04/12] block: move block polling code into one dedicated source file Ming Lei 2021-04-22 12:20 ` [dm-devel] " Ming Lei 2021-04-22 13:19 ` Hannes Reinecke 2021-04-22 13:19 ` [dm-devel] " Hannes Reinecke 2021-04-26 7:12 ` Hannes Reinecke 2021-04-26 7:12 ` [dm-devel] " Hannes Reinecke 2021-04-22 12:20 ` [PATCH V6 05/12] block: extract one helper function polling hw queue Ming Lei 2021-04-22 12:20 ` [dm-devel] " Ming Lei 2021-04-22 12:20 ` [PATCH V6 06/12] block: prepare for supporting bio_list via other link Ming Lei 2021-04-22 12:20 ` [dm-devel] " Ming Lei 2021-04-22 12:20 ` [PATCH V6 07/12] block: create io poll context for submission and poll task Ming Lei 2021-04-22 12:20 ` [dm-devel] " Ming Lei 2021-04-22 12:20 ` [PATCH V6 08/12] block: add req flag of REQ_POLL_CTX Ming Lei 2021-04-22 12:20 ` [dm-devel] " Ming Lei 2021-04-22 12:20 ` [PATCH V6 09/12] block: use per-task poll context to implement bio based io polling Ming Lei 2021-04-22 12:20 ` [dm-devel] " Ming Lei 2021-04-26 7:17 ` Hannes Reinecke 2021-04-26 7:17 ` [dm-devel] " Hannes Reinecke 2021-04-22 12:20 ` [PATCH V6 10/12] block: limit hw queues to be polled in each blk_poll() Ming Lei 2021-04-22 12:20 ` [dm-devel] " Ming Lei 2021-04-26 7:19 ` Hannes Reinecke 2021-04-26 7:19 ` [dm-devel] " Hannes Reinecke 2021-04-26 8:00 ` Ming Lei 2021-04-26 8:00 ` [dm-devel] " Ming Lei 2021-04-26 9:05 ` Hannes Reinecke 2021-04-26 9:05 ` [dm-devel] " Hannes Reinecke 2021-04-22 12:20 ` [PATCH V6 11/12] block: allow to control FLAG_POLL via sysfs for bio poll capable queue Ming Lei 2021-04-22 12:20 ` [dm-devel] " Ming Lei 2021-04-26 7:20 ` Hannes Reinecke 2021-04-26 7:20 ` [dm-devel] " Hannes Reinecke 2021-04-22 12:20 ` [PATCH V6 12/12] dm: support IO polling for bio-based dm device Ming Lei 2021-04-22 12:20 ` [dm-devel] " Ming Lei 2021-04-23 1:32 ` JeffleXu 2021-04-23 1:32 ` [dm-devel] " JeffleXu 2021-04-23 2:39 ` Ming Lei 2021-04-23 2:39 ` [dm-devel] " Ming Lei 2021-04-23 2:38 ` [PATCH V7 " Ming Lei 2021-04-23 2:38 ` [dm-devel] " Ming Lei 2021-05-17 6:16 ` [PATCH V6 00/12] block: support bio based io polling JeffleXu 2021-05-17 6:16 ` [dm-devel] " JeffleXu 2021-05-17 7:13 ` Ming Lei 2021-05-17 7:13 ` [dm-devel] " Ming Lei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210422122038.2192933-3-ming.lei@redhat.com \ --to=ming.lei@redhat.com \ --cc=axboe@kernel.dk \ --cc=dm-devel@redhat.com \ --cc=hare@suse.de \ --cc=hch@lst.de \ --cc=jefflexu@linux.alibaba.com \ --cc=linux-block@vger.kernel.org \ --cc=snitzer@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.