From: Joel Stanley <joel@jms.id.au>
To: soc@kernel.org
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Patrick Venture <venture@google.com>
Subject: [PATCH] soc: aspeed: fix a ternary sign expansion bug
Date: Fri, 23 Apr 2021 09:39:19 +0930 [thread overview]
Message-ID: <20210423000919.1249474-1-joel@jms.id.au> (raw)
From: Dan Carpenter <dan.carpenter@oracle.com>
The intent here was to return negative error codes but it actually
returns positive values. The problem is that type promotion with
ternary operations is quite complicated.
"ret" is an int. "copied" is a u32. And the snoop_file_read() function
returns long. What happens is that "ret" is cast to u32 and becomes
positive then it's cast to long and it's still positive.
Fix this by removing the ternary so that "ret" is type promoted directly
to long.
Fixes: 3772e5da4454 ("drivers/misc: Aspeed LPC snoop output using misc chardev")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Patrick Venture <venture@google.com>
Link: https://lore.kernel.org/r/YIE90PSXsMTa2Y8n@mwanda
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
Soc maintainers, can you please apply this fix.
drivers/soc/aspeed/aspeed-lpc-snoop.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/aspeed/aspeed-lpc-snoop.c b/drivers/soc/aspeed/aspeed-lpc-snoop.c
index 210455efb321..eceeaf8dfbeb 100644
--- a/drivers/soc/aspeed/aspeed-lpc-snoop.c
+++ b/drivers/soc/aspeed/aspeed-lpc-snoop.c
@@ -94,8 +94,10 @@ static ssize_t snoop_file_read(struct file *file, char __user *buffer,
return -EINTR;
}
ret = kfifo_to_user(&chan->fifo, buffer, count, &copied);
+ if (ret)
+ return ret;
- return ret ? ret : copied;
+ return copied;
}
static __poll_t snoop_file_poll(struct file *file,
--
2.30.2
next reply other threads:[~2021-04-23 0:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 0:09 Joel Stanley [this message]
2021-04-23 9:30 ` [PATCH] soc: aspeed: fix a ternary sign expansion bug patchwork-bot+linux-soc
-- strict thread matches above, loose matches on Subject: below --
2021-04-22 9:11 Dan Carpenter
2021-04-22 9:24 ` Al Viro
2021-04-22 9:26 ` Al Viro
2021-04-22 14:56 ` Patrick Venture
2021-04-22 16:21 ` David Laight
2021-04-23 0:07 ` Joel Stanley
2021-04-23 7:43 ` Dan Carpenter
2021-04-23 10:45 ` Sergey Organov
2021-04-23 10:54 ` David Laight
2021-04-23 11:14 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210423000919.1249474-1-joel@jms.id.au \
--to=joel@jms.id.au \
--cc=dan.carpenter@oracle.com \
--cc=soc@kernel.org \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.