All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nuno Sa <nuno.sa@analog.com>
To: <linux-iio@vger.kernel.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Lars-Peter Clausen <lars@metafoo.de>
Subject: [PATCH v3 2/6] iio: adis_buffer: update device page after changing it
Date: Tue, 27 Apr 2021 10:54:50 +0200	[thread overview]
Message-ID: <20210427085454.30616-3-nuno.sa@analog.com> (raw)
In-Reply-To: <20210427085454.30616-1-nuno.sa@analog.com>

It makes more sense to update the device page as soon as we we
successfully changed it. Moreover, a follow up patch will handle
'spi_sync' error path which would leave 'current_page' in a inconsistent
state.

Signed-off-by: Nuno Sa <nuno.sa@analog.com>
---
 drivers/iio/imu/adis_buffer.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/imu/adis_buffer.c b/drivers/iio/imu/adis_buffer.c
index 0ae551a748eb..4fc0e0ca7561 100644
--- a/drivers/iio/imu/adis_buffer.c
+++ b/drivers/iio/imu/adis_buffer.c
@@ -140,6 +140,8 @@ static irqreturn_t adis_trigger_handler(int irq, void *p)
 				mutex_unlock(&adis->state_lock);
 				goto irq_done;
 			}
+
+			adis->current_page = 0;
 		}
 	}
 
@@ -148,10 +150,8 @@ static irqreturn_t adis_trigger_handler(int irq, void *p)
 		dev_err(&adis->spi->dev, "Failed to read data: %d", ret);
 
 
-	if (adis->data->has_paging) {
-		adis->current_page = 0;
+	if (adis->data->has_paging)
 		mutex_unlock(&adis->state_lock);
-	}
 
 	iio_push_to_buffers_with_timestamp(indio_dev, adis->buffer,
 		pf->timestamp);
-- 
2.31.1


  parent reply	other threads:[~2021-04-27  8:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-27  8:54 [PATCH v3 0/6] Adis IRQ fixes and minor improvements Nuno Sa
2021-04-27  8:54 ` [PATCH v3 1/6] iio: adis16475: do not return ints in irq handlers Nuno Sa
2021-04-27  8:54 ` Nuno Sa [this message]
2021-04-28  6:58   ` [PATCH v3 2/6] iio: adis_buffer: update device page after changing it Alexandru Ardelean
2021-04-27  8:54 ` [PATCH v3 3/6] iio: adis_buffer: don't push data to buffers on failure Nuno Sa
2021-04-27  8:54 ` [PATCH v3 4/6] iio: adis: add burst_max_speed_hz variable Nuno Sa
2021-04-27  8:54 ` [PATCH v3 5/6] iio: adis16475: do not directly change spi 'max_speed_hz' Nuno Sa
2021-04-27  8:54 ` [PATCH v3 6/6] iio: adis16400: " Nuno Sa
2021-04-27 17:26 ` [PATCH v3 0/6] Adis IRQ fixes and minor improvements Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210427085454.30616-3-nuno.sa@analog.com \
    --to=nuno.sa@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.