All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>
Subject: [PULL 5/7] usb/mtp: avoid dynamic stack allocation
Date: Tue,  4 May 2021 10:53:15 +0200	[thread overview]
Message-ID: <20210504085317.207369-6-kraxel@redhat.com> (raw)
In-Reply-To: <20210504085317.207369-1-kraxel@redhat.com>

Use autofree heap allocation instead.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210503132915.2335822-4-kraxel@redhat.com>
---
 hw/usb/dev-mtp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index bbb827434482..2a895a73b083 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -907,7 +907,8 @@ static MTPData *usb_mtp_get_object_handles(MTPState *s, MTPControl *c,
                                            MTPObject *o)
 {
     MTPData *d = usb_mtp_data_alloc(c);
-    uint32_t i = 0, handles[o->nchildren];
+    uint32_t i = 0;
+    g_autofree uint32_t *handles = g_new(uint32_t, o->nchildren);
     MTPObject *iter;
 
     trace_usb_mtp_op_get_object_handles(s->dev.addr, o->handle, o->path);
-- 
2.31.1



  parent reply	other threads:[~2021-05-04  8:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-04  8:53 [PULL 0/7] Usb 20210504 patches Gerd Hoffmann
2021-05-04  8:53 ` [PULL 1/7] hw/usb/host-stub: Remove unused header Gerd Hoffmann
2021-05-04  8:53 ` [PULL 2/7] hw/usb: Do not build USB subsystem if not required Gerd Hoffmann
2021-05-04  8:53 ` [PULL 3/7] usb/hid: avoid dynamic stack allocation Gerd Hoffmann
2021-05-04  8:53 ` [PULL 4/7] usb/redir: avoid dynamic stack allocation (CVE-2021-3527) Gerd Hoffmann
2021-05-04  8:53 ` Gerd Hoffmann [this message]
2021-05-04  8:53 ` [PULL 6/7] usb/xhci: sanity check packet size (CVE-2021-3527) Gerd Hoffmann
2021-05-04 13:33   ` Remy Noel
2021-05-04 14:12     ` Gerd Hoffmann
2021-05-04  8:53 ` [PULL 7/7] usb: limit combined packets to 1 MiB (CVE-2021-3527) Gerd Hoffmann
2021-05-05 13:05 ` [PULL 0/7] Usb 20210504 patches Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210504085317.207369-6-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.