From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "J. Bruce Fields" <bfields@redhat.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
Chuck Lever <chuck.lever@oracle.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andy Shevchenko <andy@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH v2 00/14] lib/string_helpers: get rid of ugly *_escape_mem_ascii()
Date: Tue, 4 May 2021 13:26:34 +0300 [thread overview]
Message-ID: <20210504102648.88057-1-andriy.shevchenko@linux.intel.com> (raw)
Get rid of ugly *_escape_mem_ascii() API since it's not flexible and
has the only single user. Provide better approach based on usage of the
string_escape_mem() with appropriate flags.
Test cases has been expanded accordingly to cover new functionality.
This is assumed to go either thru VFS or Andrew's tree. I don't expect
too many changes in string_helpers.
Changelog v2:
- introduced seq_escape_mem() instead of poking seq_get_buf() (Al)
- to keep balance of seq_get_buf() usage, convert seq_escape() to use above
- added missed ESCAPE_APPEND flag in NFSv4 patch
- moved indentation patch closer to the beginning of the series
- reshuffled series to be in two groups: generic library extension
followed by seq_file updates
Andy Shevchenko (14):
lib/string_helpers: Switch to use BIT() macro
lib/string_helpers: Move ESCAPE_NP check inside 'else' branch in a
loop
lib/string_helpers: Drop indentation level in string_escape_mem()
lib/string_helpers: Introduce ESCAPE_NA for escaping non-ASCII
lib/string_helpers: Introduce ESCAPE_NAP to escape non-ASCII and
non-printable
lib/string_helpers: Allow to append additional characters to be
escaped
lib/test-string_helpers: Print flags in hexadecimal format
lib/test-string_helpers: Get rid of trailing comma in terminators
lib/test-string_helpers: Add test cases for new features
MAINTAINERS: Add myself as designated reviewer for generic string
library
seq_file: Introduce seq_escape_mem()
seq_file: Replace seq_escape() with inliner
nfsd: Avoid non-flexible API in seq_quote_mem()
seq_file: Drop unused *_escape_mem_ascii()
MAINTAINERS | 8 ++
fs/nfsd/nfs4state.c | 2 +-
fs/seq_file.c | 35 +++-----
include/linux/seq_file.h | 21 ++++-
include/linux/string_helpers.h | 31 ++++---
lib/string_helpers.c | 102 ++++++++++++---------
lib/test-string_helpers.c | 157 +++++++++++++++++++++++++++++----
7 files changed, 262 insertions(+), 94 deletions(-)
--
2.30.2
next reply other threads:[~2021-05-04 10:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 10:26 Andy Shevchenko [this message]
2021-05-04 10:26 ` [PATCH v2 01/14] lib/string_helpers: Switch to use BIT() macro Andy Shevchenko
2021-05-04 10:26 ` [PATCH v2 02/14] lib/string_helpers: Move ESCAPE_NP check inside 'else' branch in a loop Andy Shevchenko
2021-05-04 10:26 ` [PATCH v2 03/14] lib/string_helpers: Drop indentation level in string_escape_mem() Andy Shevchenko
2021-05-04 10:26 ` [PATCH v2 04/14] lib/string_helpers: Introduce ESCAPE_NA for escaping non-ASCII Andy Shevchenko
2021-05-04 10:26 ` [PATCH v2 05/14] lib/string_helpers: Introduce ESCAPE_NAP to escape non-ASCII and non-printable Andy Shevchenko
2021-05-04 10:26 ` [PATCH v2 06/14] lib/string_helpers: Allow to append additional characters to be escaped Andy Shevchenko
2021-05-04 10:26 ` [PATCH v2 07/14] lib/test-string_helpers: Print flags in hexadecimal format Andy Shevchenko
2021-05-04 10:26 ` [PATCH v2 08/14] lib/test-string_helpers: Get rid of trailing comma in terminators Andy Shevchenko
2021-05-04 10:26 ` [PATCH v2 09/14] lib/test-string_helpers: Add test cases for new features Andy Shevchenko
2021-05-04 10:26 ` [PATCH v2 10/14] MAINTAINERS: Add myself as designated reviewer for generic string library Andy Shevchenko
2021-05-04 10:26 ` [PATCH v2 11/14] seq_file: Introduce seq_escape_mem() Andy Shevchenko
2021-05-04 10:26 ` [PATCH v2 12/14] seq_file: Replace seq_escape() with inliner Andy Shevchenko
2021-05-04 12:41 ` kernel test robot
2021-05-04 12:41 ` kernel test robot
2021-05-04 13:17 ` kernel test robot
2021-05-04 13:17 ` kernel test robot
2021-05-04 13:53 ` Andy Shevchenko
2021-05-04 13:53 ` Andy Shevchenko
2021-05-04 15:54 ` kernel test robot
2021-05-04 15:54 ` kernel test robot
2021-05-04 16:26 ` Andy Shevchenko
2021-05-04 10:26 ` [PATCH v2 13/14] nfsd: Avoid non-flexible API in seq_quote_mem() Andy Shevchenko
2021-05-04 10:26 ` [PATCH v2 14/14] seq_file: Drop unused *_escape_mem_ascii() Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210504102648.88057-1-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=bfields@fieldses.org \
--cc=bfields@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.