All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Keqian Zhu <zhukeqian1@huawei.com>,
	Hyman <huangy81@chinatelecom.cn>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	peterx@redhat.com
Subject: [PATCH v7 06/10] KVM: Simplify dirty log sync in kvm_set_phys_mem
Date: Thu,  6 May 2021 12:05:45 -0400	[thread overview]
Message-ID: <20210506160549.130416-7-peterx@redhat.com> (raw)
In-Reply-To: <20210506160549.130416-1-peterx@redhat.com>

kvm_physical_sync_dirty_bitmap() on the whole section is inaccurate, because
the section can be a superset of the memslot that we're working on.  The result
is that if the section covers multiple kvm memslots, we could be doing the
synchronization for multiple times for each kvmslot in the section.

With the two helpers that we just introduced, it's very easy to do it right now
by calling the helpers.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 accel/kvm/kvm-all.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index 1025701f557..4b786240a04 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -1161,7 +1161,8 @@ static void kvm_set_phys_mem(KVMMemoryListener *kml,
                 goto out;
             }
             if (mem->flags & KVM_MEM_LOG_DIRTY_PAGES) {
-                kvm_physical_sync_dirty_bitmap(kml, section);
+                kvm_slot_get_dirty_log(kvm_state, mem);
+                kvm_slot_sync_dirty_pages(mem);
             }
 
             /* unregister the slot */
-- 
2.31.1



  parent reply	other threads:[~2021-05-06 16:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06 16:05 [PATCH v7 00/10] KVM: Dirty ring support (QEMU part) Peter Xu
2021-05-06 16:05 ` [PATCH v7 01/10] memory: Introduce log_sync_global() to memory listener Peter Xu
2021-05-06 16:05 ` [PATCH v7 02/10] KVM: Use a big lock to replace per-kml slots_lock Peter Xu
2021-05-06 16:05 ` [PATCH v7 03/10] KVM: Create the KVMSlot dirty bitmap on flag changes Peter Xu
2021-05-06 16:05 ` [PATCH v7 04/10] KVM: Provide helper to get kvm dirty log Peter Xu
2021-05-06 16:05 ` [PATCH v7 05/10] KVM: Provide helper to sync dirty bitmap from slot to ramblock Peter Xu
2021-05-06 16:05 ` Peter Xu [this message]
2021-05-06 16:05 ` [PATCH v7 07/10] KVM: Cache kvm slot dirty bitmap size Peter Xu
2021-05-06 16:05 ` [PATCH v7 08/10] KVM: Add dirty-gfn-count property Peter Xu
2021-05-06 16:05 ` [PATCH v7 09/10] KVM: Disable manual dirty log when dirty ring enabled Peter Xu
2021-05-06 16:05 ` [PATCH v7 10/10] KVM: Dirty ring support Peter Xu
2021-05-14 15:38 ` [PATCH v7 00/10] KVM: Dirty ring support (QEMU part) Paolo Bonzini
2021-05-14 15:51   ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210506160549.130416-7-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=huangy81@chinatelecom.cn \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhukeqian1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.