From: Sean Paul <sean@poorly.run> To: dri-devel@lists.freedesktop.org Cc: Sean Paul <seanpaul@chromium.org>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Stephen Boyd <swboyd@chromium.org>, Abhinav Kumar <abhinavk@codeaurora.org>, Rob Clark <robdclark@chromium.org>, Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Subject: [PATCH] drm/msm: Fix uninitialized var usage in dsi_phy_28nm_8960.c Date: Fri, 7 May 2021 10:16:43 -0400 [thread overview] Message-ID: <20210507141651.2887-1-sean@poorly.run> (raw) From: Sean Paul <seanpaul@chromium.org> This patch fixes the following error: drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c:425:11: error: variable 'parent_name' is uninitialized when used here [-Werror,-Wuninitialized] snprintf(parent_name, 32, "dsi%dvco_clk", pll_28nm->phy->id); ^~~~~~~~~~~ drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c:385:30: note: initialize the variable 'parent_name' to silence this warning char *clk_name, *parent_name, *vco_name; ^ = NULL 1 error generated. make[5]: *** [scripts/Makefile.build:279: drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.o] Error 1 It looks like the allocation was inadvertently deleted. Fixes: 5d13459650b3 ("drm/msm/dsi: push provided clocks handling into a generic code") Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: Stephen Boyd <swboyd@chromium.org> Cc: Abhinav Kumar <abhinavk@codeaurora.org> Cc: Rob Clark <robdclark@chromium.org> Signed-off-by: Sean Paul <seanpaul@chromium.org> --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c index 582b1428f971..86e40a0d41a3 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c @@ -405,6 +405,10 @@ static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, struct clk_hw **prov if (!vco_name) return -ENOMEM; + parent_name = devm_kzalloc(dev, 32, GFP_KERNEL); + if (!parent_name) + return -ENOMEM; + clk_name = devm_kzalloc(dev, 32, GFP_KERNEL); if (!clk_name) return -ENOMEM; -- Sean Paul, Software Engineer, Google / Chromium OS
WARNING: multiple messages have this Message-ID (diff)
From: Sean Paul <sean@poorly.run> To: dri-devel@lists.freedesktop.org Cc: Rob Clark <robdclark@chromium.org>, freedreno@lists.freedesktop.org, David Airlie <airlied@linux.ie>, linux-arm-msm@vger.kernel.org, Abhinav Kumar <abhinavk@codeaurora.org>, Stephen Boyd <swboyd@chromium.org>, Sean Paul <seanpaul@chromium.org>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Sean Paul <sean@poorly.run> Subject: [PATCH] drm/msm: Fix uninitialized var usage in dsi_phy_28nm_8960.c Date: Fri, 7 May 2021 10:16:43 -0400 [thread overview] Message-ID: <20210507141651.2887-1-sean@poorly.run> (raw) From: Sean Paul <seanpaul@chromium.org> This patch fixes the following error: drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c:425:11: error: variable 'parent_name' is uninitialized when used here [-Werror,-Wuninitialized] snprintf(parent_name, 32, "dsi%dvco_clk", pll_28nm->phy->id); ^~~~~~~~~~~ drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c:385:30: note: initialize the variable 'parent_name' to silence this warning char *clk_name, *parent_name, *vco_name; ^ = NULL 1 error generated. make[5]: *** [scripts/Makefile.build:279: drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.o] Error 1 It looks like the allocation was inadvertently deleted. Fixes: 5d13459650b3 ("drm/msm/dsi: push provided clocks handling into a generic code") Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: Stephen Boyd <swboyd@chromium.org> Cc: Abhinav Kumar <abhinavk@codeaurora.org> Cc: Rob Clark <robdclark@chromium.org> Signed-off-by: Sean Paul <seanpaul@chromium.org> --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c index 582b1428f971..86e40a0d41a3 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c @@ -405,6 +405,10 @@ static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, struct clk_hw **prov if (!vco_name) return -ENOMEM; + parent_name = devm_kzalloc(dev, 32, GFP_KERNEL); + if (!parent_name) + return -ENOMEM; + clk_name = devm_kzalloc(dev, 32, GFP_KERNEL); if (!clk_name) return -ENOMEM; -- Sean Paul, Software Engineer, Google / Chromium OS
next reply other threads:[~2021-05-07 14:16 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-07 14:16 Sean Paul [this message] 2021-05-07 14:16 ` [PATCH] drm/msm: Fix uninitialized var usage in dsi_phy_28nm_8960.c Sean Paul 2021-05-07 16:43 ` Rob Clark 2021-05-07 16:43 ` Rob Clark 2021-05-07 17:02 ` Rob Clark 2021-05-07 17:02 ` Rob Clark
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210507141651.2887-1-sean@poorly.run \ --to=sean@poorly.run \ --cc=abhinavk@codeaurora.org \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=robdclark@chromium.org \ --cc=robdclark@gmail.com \ --cc=seanpaul@chromium.org \ --cc=swboyd@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.