From: Stephen Boyd <swboyd@chromium.org> To: Mark Brown <broonie@kernel.org> Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Jairaj Arava <jairaj.arava@intel.com>, Sathyanarayana Nujella <sathyanarayana.nujella@intel.com>, Pierre-Louis Bossart <pierre-louis.bossart@intel.com>, Shuming Fan <shumingf@realtek.com>, Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Subject: [RFC/PATCH 2/2] ASoC: rt5682: Implement remove callback Date: Sat, 8 May 2021 00:51:51 -0700 [thread overview] Message-ID: <20210508075151.1626903-2-swboyd@chromium.org> (raw) In-Reply-To: <20210508075151.1626903-1-swboyd@chromium.org> Let's implement a remove callback for this driver that's similar to the shutdown hook, but also disables the regulators before they're put by devm code. Cc: Jairaj Arava <jairaj.arava@intel.com> Cc: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com> Cc: Pierre-Louis Bossart <pierre-louis.bossart@intel.com> Cc: Shuming Fan <shumingf@realtek.com> Cc: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- This is totally untested, but sending it in case anyone is interested. sound/soc/codecs/rt5682-i2c.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/sound/soc/codecs/rt5682-i2c.c b/sound/soc/codecs/rt5682-i2c.c index 8265b537ff4f..52a6fc56a232 100644 --- a/sound/soc/codecs/rt5682-i2c.c +++ b/sound/soc/codecs/rt5682-i2c.c @@ -280,6 +280,16 @@ static void rt5682_i2c_shutdown(struct i2c_client *client) rt5682_reset(rt5682); } +static int rt5682_i2c_remove(struct i2c_client *client) +{ + struct rt5682_priv *rt5682 = i2c_get_clientdata(client); + + rt5682_i2c_shutdown(client); + regulator_bulk_disable(ARRAY_SIZE(rt5682->supplies), rt5682->supplies); + + return 0; +} + static const struct of_device_id rt5682_of_match[] = { {.compatible = "realtek,rt5682i"}, {}, @@ -306,6 +316,7 @@ static struct i2c_driver rt5682_i2c_driver = { .probe_type = PROBE_PREFER_ASYNCHRONOUS, }, .probe = rt5682_i2c_probe, + .remove = rt5682_i2c_remove, .shutdown = rt5682_i2c_shutdown, .id_table = rt5682_i2c_id, }; -- https://chromeos.dev
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <swboyd@chromium.org> To: Mark Brown <broonie@kernel.org> Cc: alsa-devel@alsa-project.org, Jairaj Arava <jairaj.arava@intel.com>, linux-kernel@vger.kernel.org, Ranjani Sridharan <ranjani.sridharan@linux.intel.com>, Sathyanarayana Nujella <sathyanarayana.nujella@intel.com>, Shuming Fan <shumingf@realtek.com>, Pierre-Louis Bossart <pierre-louis.bossart@intel.com> Subject: [RFC/PATCH 2/2] ASoC: rt5682: Implement remove callback Date: Sat, 8 May 2021 00:51:51 -0700 [thread overview] Message-ID: <20210508075151.1626903-2-swboyd@chromium.org> (raw) In-Reply-To: <20210508075151.1626903-1-swboyd@chromium.org> Let's implement a remove callback for this driver that's similar to the shutdown hook, but also disables the regulators before they're put by devm code. Cc: Jairaj Arava <jairaj.arava@intel.com> Cc: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com> Cc: Pierre-Louis Bossart <pierre-louis.bossart@intel.com> Cc: Shuming Fan <shumingf@realtek.com> Cc: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- This is totally untested, but sending it in case anyone is interested. sound/soc/codecs/rt5682-i2c.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/sound/soc/codecs/rt5682-i2c.c b/sound/soc/codecs/rt5682-i2c.c index 8265b537ff4f..52a6fc56a232 100644 --- a/sound/soc/codecs/rt5682-i2c.c +++ b/sound/soc/codecs/rt5682-i2c.c @@ -280,6 +280,16 @@ static void rt5682_i2c_shutdown(struct i2c_client *client) rt5682_reset(rt5682); } +static int rt5682_i2c_remove(struct i2c_client *client) +{ + struct rt5682_priv *rt5682 = i2c_get_clientdata(client); + + rt5682_i2c_shutdown(client); + regulator_bulk_disable(ARRAY_SIZE(rt5682->supplies), rt5682->supplies); + + return 0; +} + static const struct of_device_id rt5682_of_match[] = { {.compatible = "realtek,rt5682i"}, {}, @@ -306,6 +316,7 @@ static struct i2c_driver rt5682_i2c_driver = { .probe_type = PROBE_PREFER_ASYNCHRONOUS, }, .probe = rt5682_i2c_probe, + .remove = rt5682_i2c_remove, .shutdown = rt5682_i2c_shutdown, .id_table = rt5682_i2c_id, }; -- https://chromeos.dev
next prev parent reply other threads:[~2021-05-08 7:52 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-08 7:51 [PATCH 1/2] ASoC: rt5682: Disable irq on shutdown Stephen Boyd 2021-05-08 7:51 ` Stephen Boyd 2021-05-08 7:51 ` Stephen Boyd [this message] 2021-05-08 7:51 ` [RFC/PATCH 2/2] ASoC: rt5682: Implement remove callback Stephen Boyd 2021-05-11 8:25 ` [PATCH 1/2] ASoC: rt5682: Disable irq on shutdown Mark Brown 2021-05-11 8:25 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210508075151.1626903-2-swboyd@chromium.org \ --to=swboyd@chromium.org \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=jairaj.arava@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=pierre-louis.bossart@intel.com \ --cc=ranjani.sridharan@linux.intel.com \ --cc=sathyanarayana.nujella@intel.com \ --cc=shumingf@realtek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.