All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-input@vger.kernel.org
Cc: Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH] Input: tsc200x: Drop hard-coded IRQ edge
Date: Mon, 10 May 2021 01:38:30 +0200	[thread overview]
Message-ID: <20210509233830.359134-1-linus.walleij@linaro.org> (raw)

This edge setting should come from the device tree not
the driver. Also, most device trees sets this to the
falling edge, which is contradictory to what is hardcoded.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/input/touchscreen/tsc200x-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/tsc200x-core.c b/drivers/input/touchscreen/tsc200x-core.c
index ce2fe30d6b8a..5f0ce663a2dc 100644
--- a/drivers/input/touchscreen/tsc200x-core.c
+++ b/drivers/input/touchscreen/tsc200x-core.c
@@ -540,7 +540,7 @@ int tsc200x_probe(struct device *dev, int irq, const struct input_id *tsc_id,
 
 	error = devm_request_threaded_irq(dev, irq, NULL,
 					  tsc200x_irq_thread,
-					  IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+					  IRQF_ONESHOT,
 					  "tsc200x", ts);
 	if (error) {
 		dev_err(dev, "Failed to request irq, err: %d\n", error);
-- 
2.30.2


             reply	other threads:[~2021-05-09 23:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-09 23:38 Linus Walleij [this message]
2021-05-10  0:22 ` [PATCH] Input: tsc200x: Drop hard-coded IRQ edge Dmitry Torokhov
2021-05-10  9:29   ` Linus Walleij
2021-05-10 13:41     ` Tony Lindgren
2021-05-10 13:46       ` H. Nikolaus Schaller
2021-05-11  0:38     ` Dmitry Torokhov
2021-05-11 18:24       ` Adam Ford
2021-05-11 21:09         ` Dmitry Torokhov
2021-05-11 23:57           ` Adam Ford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210509233830.359134-1-linus.walleij@linaro.org \
    --to=linus.walleij@linaro.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.