From: Stephen Boyd <swboyd@chromium.org> To: Andrew Morton <akpm@linux-foundation.org>, Petr Mladek <pmladek@suse.com> Cc: linux-kernel@vger.kernel.org, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, linux-arm-kernel@lists.infradead.org, Jiri Olsa <jolsa@kernel.org>, Alexei Starovoitov <ast@kernel.org>, Jessica Yu <jeyu@kernel.org>, Evan Green <evgreen@chromium.org>, Hsin-Yi Wang <hsinyi@chromium.org>, Steven Rostedt <rostedt@goodmis.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Matthew Wilcox <willy@infradead.org> Subject: [PATCH v6 06/13] arm64: stacktrace: Use %pSb for backtrace printing Date: Mon, 10 May 2021 17:38:38 -0700 [thread overview] Message-ID: <20210511003845.2429846-7-swboyd@chromium.org> (raw) In-Reply-To: <20210511003845.2429846-1-swboyd@chromium.org> Let's use the new printk format to print the stacktrace entry when printing a backtrace to the kernel logs. This will include any module's build ID[1] in it so that offline/crash debugging can easily locate the debuginfo for a module via something like debuginfod[2]. Acked-by: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will@kernel.org> Cc: <linux-arm-kernel@lists.infradead.org> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Alexei Starovoitov <ast@kernel.org> Cc: Jessica Yu <jeyu@kernel.org> Cc: Evan Green <evgreen@chromium.org> Cc: Hsin-Yi Wang <hsinyi@chromium.org> Cc: Petr Mladek <pmladek@suse.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Matthew Wilcox <willy@infradead.org> Link: https://fedoraproject.org/wiki/Releases/FeatureBuildId [1] Link: https://sourceware.org/elfutils/Debuginfod.html [2] Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- arch/arm64/kernel/stacktrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index d55bdfb7789c..ddb64ada74c2 100644 --- a/arch/arm64/kernel/stacktrace.c +++ b/arch/arm64/kernel/stacktrace.c @@ -129,7 +129,7 @@ NOKPROBE_SYMBOL(walk_stackframe); static void dump_backtrace_entry(unsigned long where, const char *loglvl) { - printk("%s %pS\n", loglvl, (void *)where); + printk("%s %pSb\n", loglvl, (void *)where); } void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk, -- https://chromeos.dev
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <swboyd@chromium.org> To: Andrew Morton <akpm@linux-foundation.org>, Petr Mladek <pmladek@suse.com> Cc: linux-kernel@vger.kernel.org, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, linux-arm-kernel@lists.infradead.org, Jiri Olsa <jolsa@kernel.org>, Alexei Starovoitov <ast@kernel.org>, Jessica Yu <jeyu@kernel.org>, Evan Green <evgreen@chromium.org>, Hsin-Yi Wang <hsinyi@chromium.org>, Steven Rostedt <rostedt@goodmis.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Matthew Wilcox <willy@infradead.org> Subject: [PATCH v6 06/13] arm64: stacktrace: Use %pSb for backtrace printing Date: Mon, 10 May 2021 17:38:38 -0700 [thread overview] Message-ID: <20210511003845.2429846-7-swboyd@chromium.org> (raw) In-Reply-To: <20210511003845.2429846-1-swboyd@chromium.org> Let's use the new printk format to print the stacktrace entry when printing a backtrace to the kernel logs. This will include any module's build ID[1] in it so that offline/crash debugging can easily locate the debuginfo for a module via something like debuginfod[2]. Acked-by: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will@kernel.org> Cc: <linux-arm-kernel@lists.infradead.org> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Alexei Starovoitov <ast@kernel.org> Cc: Jessica Yu <jeyu@kernel.org> Cc: Evan Green <evgreen@chromium.org> Cc: Hsin-Yi Wang <hsinyi@chromium.org> Cc: Petr Mladek <pmladek@suse.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Matthew Wilcox <willy@infradead.org> Link: https://fedoraproject.org/wiki/Releases/FeatureBuildId [1] Link: https://sourceware.org/elfutils/Debuginfod.html [2] Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- arch/arm64/kernel/stacktrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index d55bdfb7789c..ddb64ada74c2 100644 --- a/arch/arm64/kernel/stacktrace.c +++ b/arch/arm64/kernel/stacktrace.c @@ -129,7 +129,7 @@ NOKPROBE_SYMBOL(walk_stackframe); static void dump_backtrace_entry(unsigned long where, const char *loglvl) { - printk("%s %pS\n", loglvl, (void *)where); + printk("%s %pSb\n", loglvl, (void *)where); } void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk, -- https://chromeos.dev _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-11 0:39 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-11 0:38 [PATCH v6 00/13] Add build ID to stacktraces Stephen Boyd 2021-05-11 0:38 ` Stephen Boyd 2021-05-11 0:38 ` Stephen Boyd 2021-05-11 0:38 ` [PATCH v6 01/13] buildid: Only consider GNU notes for build ID parsing Stephen Boyd 2021-05-11 0:38 ` [PATCH v6 02/13] buildid: Add API to parse build ID out of buffer Stephen Boyd 2021-05-11 0:38 ` [PATCH v6 03/13] buildid: Stash away kernels build ID on init Stephen Boyd 2021-05-11 0:38 ` Stephen Boyd 2021-05-11 0:38 ` [PATCH v6 04/13] dump_stack: Add vmlinux build ID to stack traces Stephen Boyd 2021-05-11 0:38 ` [PATCH v6 05/13] module: Add printk formats to add module build ID to stacktraces Stephen Boyd 2021-05-11 11:35 ` Petr Mladek 2021-05-11 16:51 ` Stephen Boyd 2021-05-11 0:38 ` Stephen Boyd [this message] 2021-05-11 0:38 ` [PATCH v6 06/13] arm64: stacktrace: Use %pSb for backtrace printing Stephen Boyd 2021-05-11 0:38 ` [PATCH v6 07/13] x86/dumpstack: Use %pSb/%pBb " Stephen Boyd 2021-05-11 0:38 ` [PATCH v6 08/13] scripts/decode_stacktrace.sh: Support debuginfod Stephen Boyd 2021-05-11 0:38 ` [PATCH v6 09/13] scripts/decode_stacktrace.sh: Silence stderr messages from addr2line/nm Stephen Boyd 2021-05-11 0:38 ` [PATCH v6 10/13] scripts/decode_stacktrace.sh: Indicate 'auto' can be used for base path Stephen Boyd 2021-05-11 0:38 ` [PATCH v6 11/13] buildid: Mark some arguments const Stephen Boyd 2021-05-11 0:38 ` [PATCH v6 12/13] buildid: Fix kernel-doc notation Stephen Boyd 2021-05-11 0:38 ` [PATCH v6 13/13] kdump: Use vmlinux_build_id to simplify Stephen Boyd 2021-05-11 0:38 ` Stephen Boyd 2021-05-11 11:48 ` [PATCH v6 00/13] Add build ID to stacktraces Petr Mladek 2021-05-11 11:48 ` Petr Mladek 2021-05-11 11:48 ` Petr Mladek 2021-05-11 12:36 ` David Laight 2021-05-11 12:36 ` David Laight 2021-05-11 12:36 ` David Laight 2021-05-11 12:52 ` Steven Rostedt 2021-05-11 12:52 ` Steven Rostedt 2021-05-11 12:52 ` Steven Rostedt 2021-05-11 12:58 ` David Laight 2021-05-11 12:58 ` David Laight 2021-05-11 12:58 ` David Laight 2021-05-11 14:21 ` Petr Mladek 2021-05-11 14:21 ` Petr Mladek 2021-05-11 14:21 ` Petr Mladek 2021-05-11 14:31 ` David Laight 2021-05-11 14:31 ` David Laight 2021-05-11 14:31 ` David Laight 2021-05-11 14:35 ` Matthew Wilcox 2021-05-11 14:35 ` Matthew Wilcox 2021-05-11 14:35 ` Matthew Wilcox
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210511003845.2429846-7-swboyd@chromium.org \ --to=swboyd@chromium.org \ --cc=akpm@linux-foundation.org \ --cc=andriy.shevchenko@linux.intel.com \ --cc=ast@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=evgreen@chromium.org \ --cc=hsinyi@chromium.org \ --cc=jeyu@kernel.org \ --cc=jolsa@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pmladek@suse.com \ --cc=rostedt@goodmis.org \ --cc=will@kernel.org \ --cc=willy@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.