All of lore.kernel.org
 help / color / mirror / Atom feed
From: chris.chiu@canonical.com
To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org,
	m.v.b@runbox.com, hadess@hadess.net
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Chris Chiu <chris.chiu@canonical.com>
Subject: [PATCH v4 2/2] Revert "USB: Add reset-resume quirk for WD19's Realtek Hub"
Date: Fri, 14 May 2021 12:54:05 +0800	[thread overview]
Message-ID: <20210514045405.5261-3-chris.chiu@canonical.com> (raw)
In-Reply-To: <20210514045405.5261-1-chris.chiu@canonical.com>

From: Chris Chiu <chris.chiu@canonical.com>

This reverts commit ca91fd8c7643 ("USB: Add reset-resume quirk for
WD19's Realtek Hub"). The previous patch in the series now handles
the problematic hubs by checking the port status and handling it
accordingly when PORT_SUSPEND timeout occurs. We don't need to use
reset-resume all the time.

Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
---

Changelog:
  v4:
    - correct the format of commit reference in the commit message
    - rephrase the commit message properly

 drivers/usb/core/quirks.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 21e7522655ac..6114cf83bb44 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -406,7 +406,6 @@ static const struct usb_device_id usb_quirk_list[] = {
 
 	/* Realtek hub in Dell WD19 (Type-C) */
 	{ USB_DEVICE(0x0bda, 0x0487), .driver_info = USB_QUIRK_NO_LPM },
-	{ USB_DEVICE(0x0bda, 0x5487), .driver_info = USB_QUIRK_RESET_RESUME },
 
 	/* Generic RTL8153 based ethernet adapters */
 	{ USB_DEVICE(0x0bda, 0x8153), .driver_info = USB_QUIRK_NO_LPM },
-- 
2.20.1


  parent reply	other threads:[~2021-05-14  4:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14  4:54 [PATCH v4 0/2] USB: propose a generic fix for PORT_SUSPEND set feature timeout chris.chiu
2021-05-14  4:54 ` [PATCH v4 1/2] USB: Verify the port status when timeout happens during port suspend chris.chiu
2021-05-14  4:54 ` chris.chiu [this message]
2021-05-14 15:33 ` [PATCH v4 0/2] USB: propose a generic fix for PORT_SUSPEND set feature timeout Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210514045405.5261-3-chris.chiu@canonical.com \
    --to=chris.chiu@canonical.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hadess@hadess.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.v.b@runbox.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.