From: Luca Ceresoli <luca@lucaceresoli.net> To: linux-pci@vger.kernel.org Cc: Luca Ceresoli <luca@lucaceresoli.net>, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I <kishon@ti.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Rob Herring <robh@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, Jingoo Han <jingoohan1@gmail.com>, Gustavo Pimentel <gustavo.pimentel@synopsys.com> Subject: [PATCH 5/5] PCI: dwc: pci-dra7xx: get an optional clock Date: Mon, 17 May 2021 17:41:22 +0200 [thread overview] Message-ID: <20210517154122.430544-6-luca@lucaceresoli.net> (raw) In-Reply-To: <20210517154122.430544-1-luca@lucaceresoli.net> If the clock is provided externally we need to make sure it is enabled before starting PCI scan. Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> --- drivers/pci/controller/dwc/pci-dra7xx.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c index 05d06806c300..8dd20b394d0c 100644 --- a/drivers/pci/controller/dwc/pci-dra7xx.c +++ b/drivers/pci/controller/dwc/pci-dra7xx.c @@ -7,6 +7,7 @@ * Authors: Kishon Vijay Abraham I <kishon@ti.com> */ +#include <linux/clk.h> #include <linux/delay.h> #include <linux/device.h> #include <linux/err.h> @@ -90,6 +91,7 @@ struct dra7xx_pcie { int phy_count; /* DT phy-names count */ struct phy **phy; struct irq_domain *irq_domain; + struct clk *clk; enum dw_pcie_device_mode mode; }; @@ -744,6 +746,15 @@ static int dra7xx_pcie_probe(struct platform_device *pdev) if (!link) return -ENOMEM; + dra7xx->clk = devm_clk_get_optional(dev, NULL); + if (IS_ERR(dra7xx->clk)) + return dev_err_probe(dev, PTR_ERR(dra7xx->clk), + "clock request failed"); + + ret = clk_prepare_enable(dra7xx->clk); + if (ret) + return ret; + for (i = 0; i < phy_count; i++) { snprintf(name, sizeof(name), "pcie-phy%d", i); phy[i] = devm_phy_get(dev, name); @@ -931,6 +942,8 @@ static void dra7xx_pcie_shutdown(struct platform_device *pdev) pm_runtime_disable(dev); dra7xx_pcie_disable_phy(dra7xx); + + clk_disable_unprepare(dra7xx->clk); } static const struct dev_pm_ops dra7xx_pcie_pm_ops = { -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Luca Ceresoli <luca@lucaceresoli.net> To: linux-pci@vger.kernel.org Cc: Luca Ceresoli <luca@lucaceresoli.net>, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I <kishon@ti.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Rob Herring <robh@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, Jingoo Han <jingoohan1@gmail.com>, Gustavo Pimentel <gustavo.pimentel@synopsys.com> Subject: [PATCH 5/5] PCI: dwc: pci-dra7xx: get an optional clock Date: Mon, 17 May 2021 17:41:22 +0200 [thread overview] Message-ID: <20210517154122.430544-6-luca@lucaceresoli.net> (raw) In-Reply-To: <20210517154122.430544-1-luca@lucaceresoli.net> If the clock is provided externally we need to make sure it is enabled before starting PCI scan. Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> --- drivers/pci/controller/dwc/pci-dra7xx.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c index 05d06806c300..8dd20b394d0c 100644 --- a/drivers/pci/controller/dwc/pci-dra7xx.c +++ b/drivers/pci/controller/dwc/pci-dra7xx.c @@ -7,6 +7,7 @@ * Authors: Kishon Vijay Abraham I <kishon@ti.com> */ +#include <linux/clk.h> #include <linux/delay.h> #include <linux/device.h> #include <linux/err.h> @@ -90,6 +91,7 @@ struct dra7xx_pcie { int phy_count; /* DT phy-names count */ struct phy **phy; struct irq_domain *irq_domain; + struct clk *clk; enum dw_pcie_device_mode mode; }; @@ -744,6 +746,15 @@ static int dra7xx_pcie_probe(struct platform_device *pdev) if (!link) return -ENOMEM; + dra7xx->clk = devm_clk_get_optional(dev, NULL); + if (IS_ERR(dra7xx->clk)) + return dev_err_probe(dev, PTR_ERR(dra7xx->clk), + "clock request failed"); + + ret = clk_prepare_enable(dra7xx->clk); + if (ret) + return ret; + for (i = 0; i < phy_count; i++) { snprintf(name, sizeof(name), "pcie-phy%d", i); phy[i] = devm_phy_get(dev, name); @@ -931,6 +942,8 @@ static void dra7xx_pcie_shutdown(struct platform_device *pdev) pm_runtime_disable(dev); dra7xx_pcie_disable_phy(dra7xx); + + clk_disable_unprepare(dra7xx->clk); } static const struct dev_pm_ops dra7xx_pcie_pm_ops = { -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-17 16:05 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-17 15:41 [PATCH 0/5] PCI: dwc: pci-dra7xx: miscellaneous improvements Luca Ceresoli 2021-05-17 15:41 ` Luca Ceresoli 2021-05-17 15:41 ` [PATCH 1/5] PCI: dwc: export more symbols to allow modular drivers Luca Ceresoli 2021-05-17 15:41 ` Luca Ceresoli 2021-05-17 15:41 ` [PATCH 2/5] PCI: dwc: pci-dra7xx: make it a kernel module Luca Ceresoli 2021-05-17 15:41 ` Luca Ceresoli 2021-05-18 18:55 ` Rob Herring 2021-05-18 18:55 ` Rob Herring 2021-05-18 21:39 ` Luca Ceresoli 2021-05-18 21:39 ` Luca Ceresoli 2021-05-17 15:41 ` [PATCH 3/5] PCI: dwc: pci-dra7xx: allow to build as a loadable module Luca Ceresoli 2021-05-17 15:41 ` Luca Ceresoli 2021-05-17 15:41 ` [PATCH 4/5] PCI: dwc: pci-dra7xx: remove unused include Luca Ceresoli 2021-05-17 15:41 ` Luca Ceresoli 2021-05-17 15:41 ` Luca Ceresoli [this message] 2021-05-17 15:41 ` [PATCH 5/5] PCI: dwc: pci-dra7xx: get an optional clock Luca Ceresoli 2021-05-17 16:36 ` [PATCH 0/5] PCI: dwc: pci-dra7xx: miscellaneous improvements Bjorn Helgaas 2021-05-17 16:36 ` Bjorn Helgaas 2021-05-18 17:06 ` Luca Ceresoli 2021-05-18 17:06 ` Luca Ceresoli
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210517154122.430544-6-luca@lucaceresoli.net \ --to=luca@lucaceresoli.net \ --cc=bhelgaas@google.com \ --cc=gustavo.pimentel@synopsys.com \ --cc=jingoohan1@gmail.com \ --cc=kishon@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.