From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Emanuele Giuseppe Esposito" <eesposit@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"John Snow" <jsnow@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH v2 1/6] python/console_socket: avoid one-letter variable
Date: Mon, 17 May 2021 14:48:03 -0400 [thread overview]
Message-ID: <20210517184808.3562549-2-jsnow@redhat.com> (raw)
In-Reply-To: <20210517184808.3562549-1-jsnow@redhat.com>
Fixes pylint warnings.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
python/qemu/console_socket.py | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/python/qemu/console_socket.py b/python/qemu/console_socket.py
index ac21130e446..87237bebef7 100644
--- a/python/qemu/console_socket.py
+++ b/python/qemu/console_socket.py
@@ -46,11 +46,11 @@ def __init__(self, address: str, file: Optional[str] = None,
self._drain_thread = self._thread_start()
def __repr__(self) -> str:
- s = super().__repr__()
- s = s.rstrip(">")
- s = "%s, logfile=%s, drain_thread=%s>" % (s, self._logfile,
- self._drain_thread)
- return s
+ tmp = super().__repr__()
+ tmp = tmp.rstrip(">")
+ tmp = "%s, logfile=%s, drain_thread=%s>" % (tmp, self._logfile,
+ self._drain_thread)
+ return tmp
def _drain_fn(self) -> None:
"""Drains the socket and runs while the socket is open."""
--
2.30.2
next prev parent reply other threads:[~2021-05-17 19:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 18:48 [PATCH v2 0/6] Python: delint python library John Snow
2021-05-17 18:48 ` John Snow [this message]
2021-05-17 18:48 ` [PATCH v2 2/6] python/machine: use subprocess.DEVNULL instead of open(os.path.devnull) John Snow
2021-05-18 3:33 ` Cleber Rosa
2021-05-17 18:48 ` [PATCH v2 3/6] python/machine: use subprocess.run instead of subprocess.Popen John Snow
2021-05-18 3:48 ` Cleber Rosa
2021-05-17 18:48 ` [PATCH v2 4/6] python/console_socket: Add a pylint ignore John Snow
2021-05-18 3:50 ` Cleber Rosa
2021-05-17 18:48 ` [PATCH v2 5/6] python/machine: Disable pylint warning for open() in _pre_launch John Snow
2021-05-18 4:07 ` Cleber Rosa
2021-05-17 18:48 ` [PATCH v2 6/6] python/machine: disable warning for Popen in _launch() John Snow
2021-05-18 4:08 ` Cleber Rosa
2021-05-18 13:33 ` [PATCH v2 0/6] Python: delint python library John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210517184808.3562549-2-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=crosa@redhat.com \
--cc=eesposit@redhat.com \
--cc=ehabkost@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.