From: Dong Aisheng <aisheng.dong@nxp.com> To: linux-pm@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, dongas86@gmail.com, linux-imx@nxp.com, cw00.choi@samsung.com, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, shawnguo@kernel.org, kernel@pengutronix.de, abel.vesa@nxp.com, Dong Aisheng <aisheng.dong@nxp.com> Subject: [PATCH 1/2] PM / devfreq: imx-bus: Remove imx_bus_get_dev_status Date: Wed, 19 May 2021 15:05:44 +0800 [thread overview] Message-ID: <20210519070545.1728197-1-aisheng.dong@nxp.com> (raw) Current driver actually does not support simple ondemand governor as it's unable to provide device load information. So removing the unnecessary callback to avoid confusing. Right now the driver is using userspace governor by default. polling_ms was also dropped as it's not needed for non-ondemand governor. Cc: Chanwoo Choi <cw00.choi@samsung.com> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> --- drivers/devfreq/imx-bus.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c index 3fc3fd77492d..f3f6e25053ed 100644 --- a/drivers/devfreq/imx-bus.c +++ b/drivers/devfreq/imx-bus.c @@ -45,18 +45,6 @@ static int imx_bus_get_cur_freq(struct device *dev, unsigned long *freq) return 0; } -static int imx_bus_get_dev_status(struct device *dev, - struct devfreq_dev_status *stat) -{ - struct imx_bus *priv = dev_get_drvdata(dev); - - stat->busy_time = 0; - stat->total_time = 0; - stat->current_frequency = clk_get_rate(priv->clk); - - return 0; -} - static void imx_bus_exit(struct device *dev) { struct imx_bus *priv = dev_get_drvdata(dev); @@ -129,9 +117,7 @@ static int imx_bus_probe(struct platform_device *pdev) return ret; } - priv->profile.polling_ms = 1000; priv->profile.target = imx_bus_target; - priv->profile.get_dev_status = imx_bus_get_dev_status; priv->profile.exit = imx_bus_exit; priv->profile.get_cur_freq = imx_bus_get_cur_freq; priv->profile.initial_freq = clk_get_rate(priv->clk); -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Dong Aisheng <aisheng.dong@nxp.com> To: linux-pm@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, dongas86@gmail.com, linux-imx@nxp.com, cw00.choi@samsung.com, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, shawnguo@kernel.org, kernel@pengutronix.de, abel.vesa@nxp.com, Dong Aisheng <aisheng.dong@nxp.com> Subject: [PATCH 1/2] PM / devfreq: imx-bus: Remove imx_bus_get_dev_status Date: Wed, 19 May 2021 15:05:44 +0800 [thread overview] Message-ID: <20210519070545.1728197-1-aisheng.dong@nxp.com> (raw) Current driver actually does not support simple ondemand governor as it's unable to provide device load information. So removing the unnecessary callback to avoid confusing. Right now the driver is using userspace governor by default. polling_ms was also dropped as it's not needed for non-ondemand governor. Cc: Chanwoo Choi <cw00.choi@samsung.com> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> --- drivers/devfreq/imx-bus.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c index 3fc3fd77492d..f3f6e25053ed 100644 --- a/drivers/devfreq/imx-bus.c +++ b/drivers/devfreq/imx-bus.c @@ -45,18 +45,6 @@ static int imx_bus_get_cur_freq(struct device *dev, unsigned long *freq) return 0; } -static int imx_bus_get_dev_status(struct device *dev, - struct devfreq_dev_status *stat) -{ - struct imx_bus *priv = dev_get_drvdata(dev); - - stat->busy_time = 0; - stat->total_time = 0; - stat->current_frequency = clk_get_rate(priv->clk); - - return 0; -} - static void imx_bus_exit(struct device *dev) { struct imx_bus *priv = dev_get_drvdata(dev); @@ -129,9 +117,7 @@ static int imx_bus_probe(struct platform_device *pdev) return ret; } - priv->profile.polling_ms = 1000; priv->profile.target = imx_bus_target; - priv->profile.get_dev_status = imx_bus_get_dev_status; priv->profile.exit = imx_bus_exit; priv->profile.get_cur_freq = imx_bus_get_cur_freq; priv->profile.initial_freq = clk_get_rate(priv->clk); -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2021-05-19 7:06 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20210519070646epcas1p278827601f2ce81e96e088f8fcac31d32@epcas1p2.samsung.com> 2021-05-19 7:05 ` Dong Aisheng [this message] 2021-05-19 7:05 ` [PATCH 1/2] PM / devfreq: imx-bus: Remove imx_bus_get_dev_status Dong Aisheng 2021-05-19 7:05 ` [PATCH 2/2] devfreq: imx8m-ddrc: de-select DEVFREQ_GOV_SIMPLE_ONDEMAND Dong Aisheng 2021-05-19 7:05 ` Dong Aisheng 2021-05-20 3:10 ` Chanwoo Choi 2021-05-20 3:10 ` Chanwoo Choi 2021-05-21 3:04 ` Aisheng Dong 2021-05-21 3:04 ` Aisheng Dong 2021-05-20 2:51 ` [PATCH 1/2] PM / devfreq: imx-bus: Remove imx_bus_get_dev_status Chanwoo Choi 2021-05-20 2:51 ` Chanwoo Choi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210519070545.1728197-1-aisheng.dong@nxp.com \ --to=aisheng.dong@nxp.com \ --cc=abel.vesa@nxp.com \ --cc=cw00.choi@samsung.com \ --cc=dongas86@gmail.com \ --cc=kernel@pengutronix.de \ --cc=kyungmin.park@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-pm@vger.kernel.org \ --cc=myungjoo.ham@samsung.com \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.