From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, armbru@redhat.com, qemu-stable@nongnu.org
Subject: [PATCH v3 0/3] vl: add -object support back into -readconfig
Date: Fri, 21 May 2021 06:21:01 -0400 [thread overview]
Message-ID: <20210521102104.3271053-1-pbonzini@redhat.com> (raw)
LXD developers have reported that [object] stanzas have stopped
working in configuration files.
The problem is that QEMU 6.0 switched the creation of objects from
qemu_opts_foreach to a bespoke QTAILQ, in preparation for supporting
JSON syntax in -object. Entries from the configuration file however
do not go through object_option_parse, and are thus lost. Of the many
fixes that are possible, I chose one that is slightly more invasive but
more consistent with the plans for keyval-ification of options such as
-M and -accel.
-set was also broken by the same change. For simplicity I chose
not to add it back yet, however this series will report the
breakage instead of failing silently.
The first two patches of this series are thus a reduced version of
https://patchew.org/QEMU/20210513162901.1310239-1-pbonzini@redhat.com/
([PATCH 00/14] vl: compound properties for machines and accelerators),
with the -set infrastructure removed. The third is very simple and
uses the newly-provided hooks to parse objects from configuration files.
Paolo
Based-on: <20210518131542.2941207-1-pbonzini@redhat.com>
Paolo Bonzini (3):
qemu-config: parse configuration files to a QDict
vl: plumb keyval-based options into -readconfig
vl: plug -object back into -readconfig
include/block/qdict.h | 2 -
include/qapi/qmp/qdict.h | 3 ++
include/qemu/config-file.h | 7 ++-
softmmu/vl.c | 105 +++++++++++++++++++++++++++----------
util/qemu-config.c | 98 +++++++++++++++++++++++-----------
5 files changed, 153 insertions(+), 62 deletions(-)
--
2.27.0
next reply other threads:[~2021-05-21 10:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 10:21 Paolo Bonzini [this message]
2021-05-21 10:21 ` [PATCH v3 1/3] qemu-config: parse configuration files to a QDict Paolo Bonzini
2021-05-21 16:09 ` Kevin Wolf
2021-05-21 16:42 ` Paolo Bonzini
2021-05-21 10:21 ` [PATCH v3 2/3] vl: plumb keyval-based options into -readconfig Paolo Bonzini
2021-05-21 10:21 ` [PATCH v3 3/3] vl: plug -object back " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210521102104.3271053-1-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.