From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: [RFC PATCH] configure: Do not add --warn-common to the linker flags anymore
Date: Tue, 25 May 2021 13:11:49 +0200 [thread overview]
Message-ID: <20210525111149.131222-1-thuth@redhat.com> (raw)
We are compiling with -fno-common since commit 4c288acbd6 ("configure:
Always build with -fno-common"), so --warn-common (which had been added
in commit 49237acdb725e in 2008 already) should not be necessary anymore
nowadays.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
Marked as RFC since I'm not 100% sure whether I'm missing here something...
but IMHO the --warn-common does not buy us anything if we also compile
with -fno-common...
configure | 7 -------
1 file changed, 7 deletions(-)
diff --git a/configure b/configure
index 86a8a7e44f..99b9216af3 100755
--- a/configure
+++ b/configure
@@ -5383,13 +5383,6 @@ fi
##########################################
-# Exclude --warn-common with TSan to suppress warnings from the TSan libraries.
-if test "$solaris" = "no" && test "$tsan" = "no"; then
- if $ld --version 2>/dev/null | grep "GNU ld" >/dev/null 2>/dev/null ; then
- QEMU_LDFLAGS="-Wl,--warn-common $QEMU_LDFLAGS"
- fi
-fi
-
# Use ASLR, no-SEH and DEP if available
if test "$mingw32" = "yes" ; then
flags="--no-seh --nxcompat"
--
2.27.0
next reply other threads:[~2021-05-25 11:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 11:11 Thomas Huth [this message]
2021-05-25 23:22 ` [RFC PATCH] configure: Do not add --warn-common to the linker flags anymore Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210525111149.131222-1-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.