From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, "Laurent Vivier" <lvivier@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PATCH v2 0/3] vhost-user: warn when guest RAM is not shared
Date: Tue, 25 May 2021 15:28:00 +0100 [thread overview]
Message-ID: <20210525142803.125401-1-stefanha@redhat.com> (raw)
v2:
* Clarify that object-memory-memfd enables share=on by default [Marc-André]
* Rebased
vhost-user requires -object memory-backend-*,share=on option so that QEMU uses
mmap(MAP_SHARED) on guest RAM that is shared with the vhost-user device backend
process. This is needed so the QEMU process sees changes made by the vhost-user
device backend process, and vice versa.
Today QEMU and the vhost-user device process will start up and then fail with a
confusing error message if the user forgot to specify share=on.
This patch series adds a warning letting the user know that share=on is
required.
Stefan Hajnoczi (3):
tests/qtest/vhost-user-test: use share=on with memfd
memory: add memory_region_is_mapped_shared()
vhost-user: warn when guest RAM is not shared
include/exec/memory.h | 11 +++++++++++
hw/virtio/vhost-user.c | 20 ++++++++++++++++----
softmmu/memory.c | 6 ++++++
tests/qtest/vhost-user-test.c | 2 +-
4 files changed, 34 insertions(+), 5 deletions(-)
--
2.31.1
next reply other threads:[~2021-05-25 14:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 14:28 Stefan Hajnoczi [this message]
2021-05-25 14:28 ` [PATCH v2 1/3] tests/qtest/vhost-user-test: use share=on with memfd Stefan Hajnoczi
2021-05-25 14:28 ` [PATCH v2 2/3] memory: add memory_region_is_mapped_shared() Stefan Hajnoczi
2021-05-25 14:28 ` [PATCH v2 3/3] vhost-user: warn when guest RAM is not shared Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210525142803.125401-1-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.