All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: kvm@vger.kernel.org
Cc: shashi.mallela@linaro.org, alexandru.elisei@arm.com,
	eric.auger@redhat.com, qemu-arm@nongnu.org,
	linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, christoffer.dall@arm.com,
	maz@kernel.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: [kvm-unit-tests PATCH v2 1/4] arm64: remove invalid check from its-trigger test
Date: Tue, 25 May 2021 18:26:25 +0100	[thread overview]
Message-ID: <20210525172628.2088-2-alex.bennee@linaro.org> (raw)
In-Reply-To: <20210525172628.2088-1-alex.bennee@linaro.org>

While an IRQ is not "guaranteed to be visible until an appropriate
invalidation" it doesn't stop the actual implementation delivering it
earlier if it wants to. This is the case for QEMU's TCG and as tests
should only be checking architectural compliance this check is
invalid.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Shashi Mallela <shashi.mallela@linaro.org>
---
 arm/gic.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/arm/gic.c b/arm/gic.c
index 98135ef..bef061a 100644
--- a/arm/gic.c
+++ b/arm/gic.c
@@ -732,21 +732,19 @@ static void test_its_trigger(void)
 			"dev2/eventid=20 does not trigger any LPI");
 
 	/*
-	 * re-enable the LPI but willingly do not call invall
-	 * so the change in config is not taken into account.
-	 * The LPI should not hit
+	 * re-enable the LPI but willingly do not call invall so the
+	 * change in config is not taken into account. While "A change
+	 * to the LPI configuration is not guaranteed to be visible
+	 * until an appropriate invalidation operation has completed"
+	 * hardware that doesn't implement caches may have delivered
+	 * the event at any point after the enabling.
 	 */
 	gicv3_lpi_set_config(8195, LPI_PROP_DEFAULT);
 	stats_reset();
 	cpumask_clear(&mask);
 	its_send_int(dev2, 20);
-	wait_for_interrupts(&mask);
-	report(check_acked(&mask, -1, -1),
-			"dev2/eventid=20 still does not trigger any LPI");
 
 	/* Now call the invall and check the LPI hits */
-	stats_reset();
-	cpumask_clear(&mask);
 	cpumask_set_cpu(3, &mask);
 	its_send_invall(col3);
 	wait_for_interrupts(&mask);
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: kvm@vger.kernel.org
Cc: maz@kernel.org, shashi.mallela@linaro.org, qemu-arm@nongnu.org,
	kvmarm@lists.cs.columbia.edu,
	linux-arm-kernel@lists.infradead.org
Subject: [kvm-unit-tests PATCH v2 1/4] arm64: remove invalid check from its-trigger test
Date: Tue, 25 May 2021 18:26:25 +0100	[thread overview]
Message-ID: <20210525172628.2088-2-alex.bennee@linaro.org> (raw)
In-Reply-To: <20210525172628.2088-1-alex.bennee@linaro.org>

While an IRQ is not "guaranteed to be visible until an appropriate
invalidation" it doesn't stop the actual implementation delivering it
earlier if it wants to. This is the case for QEMU's TCG and as tests
should only be checking architectural compliance this check is
invalid.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Shashi Mallela <shashi.mallela@linaro.org>
---
 arm/gic.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/arm/gic.c b/arm/gic.c
index 98135ef..bef061a 100644
--- a/arm/gic.c
+++ b/arm/gic.c
@@ -732,21 +732,19 @@ static void test_its_trigger(void)
 			"dev2/eventid=20 does not trigger any LPI");
 
 	/*
-	 * re-enable the LPI but willingly do not call invall
-	 * so the change in config is not taken into account.
-	 * The LPI should not hit
+	 * re-enable the LPI but willingly do not call invall so the
+	 * change in config is not taken into account. While "A change
+	 * to the LPI configuration is not guaranteed to be visible
+	 * until an appropriate invalidation operation has completed"
+	 * hardware that doesn't implement caches may have delivered
+	 * the event at any point after the enabling.
 	 */
 	gicv3_lpi_set_config(8195, LPI_PROP_DEFAULT);
 	stats_reset();
 	cpumask_clear(&mask);
 	its_send_int(dev2, 20);
-	wait_for_interrupts(&mask);
-	report(check_acked(&mask, -1, -1),
-			"dev2/eventid=20 still does not trigger any LPI");
 
 	/* Now call the invall and check the LPI hits */
-	stats_reset();
-	cpumask_clear(&mask);
 	cpumask_set_cpu(3, &mask);
 	its_send_invall(col3);
 	wait_for_interrupts(&mask);
-- 
2.20.1

_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: kvm@vger.kernel.org
Cc: shashi.mallela@linaro.org, alexandru.elisei@arm.com,
	eric.auger@redhat.com, qemu-arm@nongnu.org,
	linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, christoffer.dall@arm.com,
	maz@kernel.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: [kvm-unit-tests PATCH v2 1/4] arm64: remove invalid check from its-trigger test
Date: Tue, 25 May 2021 18:26:25 +0100	[thread overview]
Message-ID: <20210525172628.2088-2-alex.bennee@linaro.org> (raw)
In-Reply-To: <20210525172628.2088-1-alex.bennee@linaro.org>

While an IRQ is not "guaranteed to be visible until an appropriate
invalidation" it doesn't stop the actual implementation delivering it
earlier if it wants to. This is the case for QEMU's TCG and as tests
should only be checking architectural compliance this check is
invalid.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Shashi Mallela <shashi.mallela@linaro.org>
---
 arm/gic.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/arm/gic.c b/arm/gic.c
index 98135ef..bef061a 100644
--- a/arm/gic.c
+++ b/arm/gic.c
@@ -732,21 +732,19 @@ static void test_its_trigger(void)
 			"dev2/eventid=20 does not trigger any LPI");
 
 	/*
-	 * re-enable the LPI but willingly do not call invall
-	 * so the change in config is not taken into account.
-	 * The LPI should not hit
+	 * re-enable the LPI but willingly do not call invall so the
+	 * change in config is not taken into account. While "A change
+	 * to the LPI configuration is not guaranteed to be visible
+	 * until an appropriate invalidation operation has completed"
+	 * hardware that doesn't implement caches may have delivered
+	 * the event at any point after the enabling.
 	 */
 	gicv3_lpi_set_config(8195, LPI_PROP_DEFAULT);
 	stats_reset();
 	cpumask_clear(&mask);
 	its_send_int(dev2, 20);
-	wait_for_interrupts(&mask);
-	report(check_acked(&mask, -1, -1),
-			"dev2/eventid=20 still does not trigger any LPI");
 
 	/* Now call the invall and check the LPI hits */
-	stats_reset();
-	cpumask_clear(&mask);
 	cpumask_set_cpu(3, &mask);
 	its_send_invall(col3);
 	wait_for_interrupts(&mask);
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-05-25 17:26 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25 17:26 [kvm-unit-tests PATCH v2 0/4] enable LPI and ITS for TCG Alex Bennée
2021-05-25 17:26 ` Alex Bennée
2021-05-25 17:26 ` Alex Bennée
2021-05-25 17:26 ` Alex Bennée [this message]
2021-05-25 17:26   ` [kvm-unit-tests PATCH v2 1/4] arm64: remove invalid check from its-trigger test Alex Bennée
2021-05-25 17:26   ` Alex Bennée
2021-05-26 15:06   ` Auger Eric
2021-05-26 15:06     ` Auger Eric
2021-05-26 15:06     ` Auger Eric
2021-05-25 17:26 ` [kvm-unit-tests PATCH v2 2/4] scripts/arch-run: don't use deprecated server/nowait options Alex Bennée
2021-05-25 17:26   ` Alex Bennée
2021-05-25 17:26   ` Alex Bennée
2021-05-26 14:23   ` Zenghui Yu
2021-05-26 14:23     ` Zenghui Yu
2021-05-26 14:23     ` Zenghui Yu
2021-05-26 15:05   ` Auger Eric
2021-05-26 15:05     ` Auger Eric
2021-05-26 15:05     ` Auger Eric
2021-06-01 12:27   ` Andrew Jones
2021-06-01 12:27     ` Andrew Jones
2021-06-01 12:27     ` Andrew Jones
2021-07-13 20:47   ` Andrew Jones
2021-07-13 20:47     ` Andrew Jones
2021-07-13 20:47     ` Andrew Jones
2021-05-25 17:26 ` [kvm-unit-tests PATCH v2 3/4] arm64: enable its-migration tests for TCG Alex Bennée
2021-05-25 17:26   ` Alex Bennée
2021-05-25 17:26   ` Alex Bennée
2021-05-26 15:05   ` Auger Eric
2021-05-26 15:05     ` Auger Eric
2021-05-26 15:05     ` Auger Eric
2021-06-01 13:23   ` Andrew Jones
2021-06-01 13:23     ` Andrew Jones
2021-06-01 13:23     ` Andrew Jones
2021-05-25 17:26 ` [kvm-unit-tests PATCH v2 4/4] arm64: split its-migrate-unmapped-collection into KVM and TCG variants Alex Bennée
2021-05-25 17:26   ` Alex Bennée
2021-05-25 17:26   ` Alex Bennée
2021-05-26 16:33   ` Auger Eric
2021-05-26 16:33     ` Auger Eric
2021-05-26 16:33     ` Auger Eric
2021-06-01 16:49     ` Alex Bennée
2021-06-01 16:49       ` Alex Bennée
2021-06-01 16:49       ` Alex Bennée
2021-06-01 19:46       ` Andrew Jones
2021-06-01 19:46         ` Andrew Jones
2021-06-01 19:46         ` Andrew Jones
2021-06-01 21:50         ` Alex Bennée
2021-06-01 21:50           ` Alex Bennée
2021-06-01 21:50           ` Alex Bennée
2021-06-01 13:21   ` Andrew Jones
2021-06-01 13:21     ` Andrew Jones
2021-06-01 13:21     ` Andrew Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210525172628.2088-2-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=alexandru.elisei@arm.com \
    --cc=christoffer.dall@arm.com \
    --cc=eric.auger@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=qemu-arm@nongnu.org \
    --cc=shashi.mallela@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.