From: Mike Christie <michael.christie@oracle.com> To: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org, stefanha@redhat.com, pbonzini@redhat.com, jasowang@redhat.com, mst@redhat.com, sgarzare@redhat.com, virtualization@lists.linux-foundation.org Cc: Mike Christie <michael.christie@oracle.com> Subject: [PATCH 3/5] vhost-scsi: reduce flushes during endpoint clearing Date: Tue, 25 May 2021 12:47:31 -0500 [thread overview] Message-ID: <20210525174733.6212-4-michael.christie@oracle.com> (raw) In-Reply-To: <20210525174733.6212-1-michael.christie@oracle.com> vhost_scsi_flush will flush everything, so we can clear the backends then flush, then destroy. We don't need to flush before each vq destruction because after the flush we will have made sure there can be no new cmds started and there are no running cmds. Signed-off-by: Mike Christie <michael.christie@oracle.com> --- drivers/vhost/scsi.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index 2f9633ef26aa..927ebc52d822 100644 --- a/drivers/vhost/scsi.c +++ b/drivers/vhost/scsi.c @@ -1747,11 +1747,12 @@ vhost_scsi_clear_endpoint(struct vhost_scsi *vs, mutex_lock(&vq->mutex); vhost_vq_set_backend(vq, NULL); mutex_unlock(&vq->mutex); - /* - * Make sure cmds are not running before tearing them - * down. - */ - vhost_scsi_flush(vs); + } + /* Make sure cmds are not running before tearing them down. */ + vhost_scsi_flush(vs); + + for (i = 0; i < VHOST_SCSI_MAX_VQ; i++) { + vq = &vs->vqs[i].vq; vhost_scsi_destroy_vq_cmds(vq); } } -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Mike Christie <michael.christie@oracle.com> To: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org, stefanha@redhat.com, pbonzini@redhat.com, jasowang@redhat.com, mst@redhat.com, sgarzare@redhat.com, virtualization@lists.linux-foundation.org Subject: [PATCH 3/5] vhost-scsi: reduce flushes during endpoint clearing Date: Tue, 25 May 2021 12:47:31 -0500 [thread overview] Message-ID: <20210525174733.6212-4-michael.christie@oracle.com> (raw) In-Reply-To: <20210525174733.6212-1-michael.christie@oracle.com> vhost_scsi_flush will flush everything, so we can clear the backends then flush, then destroy. We don't need to flush before each vq destruction because after the flush we will have made sure there can be no new cmds started and there are no running cmds. Signed-off-by: Mike Christie <michael.christie@oracle.com> --- drivers/vhost/scsi.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index 2f9633ef26aa..927ebc52d822 100644 --- a/drivers/vhost/scsi.c +++ b/drivers/vhost/scsi.c @@ -1747,11 +1747,12 @@ vhost_scsi_clear_endpoint(struct vhost_scsi *vs, mutex_lock(&vq->mutex); vhost_vq_set_backend(vq, NULL); mutex_unlock(&vq->mutex); - /* - * Make sure cmds are not running before tearing them - * down. - */ - vhost_scsi_flush(vs); + } + /* Make sure cmds are not running before tearing them down. */ + vhost_scsi_flush(vs); + + for (i = 0; i < VHOST_SCSI_MAX_VQ; i++) { + vq = &vs->vqs[i].vq; vhost_scsi_destroy_vq_cmds(vq); } } -- 2.25.1 _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-05-25 17:47 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-25 17:47 vhost: coding style and flush cleanups Mike Christie 2021-05-25 17:47 ` Mike Christie 2021-05-25 17:47 ` [PATCH 1/5] vhost: remove work arg from vhost_work_flush Mike Christie 2021-05-25 17:47 ` Mike Christie 2021-05-27 13:22 ` Stefano Garzarella 2021-05-27 13:22 ` Stefano Garzarella 2021-05-25 17:47 ` [PATCH 2/5] vhost-scsi: remove extra flushes Mike Christie 2021-05-25 17:47 ` Mike Christie 2021-05-25 17:47 ` Mike Christie [this message] 2021-05-25 17:47 ` [PATCH 3/5] vhost-scsi: reduce flushes during endpoint clearing Mike Christie 2021-05-25 17:47 ` [PATCH 4/5] vhost: fix poll coding style Mike Christie 2021-05-25 17:47 ` Mike Christie 2021-05-25 17:47 ` [PATCH 5/5] vhost: fix up vhost_work " Mike Christie 2021-05-25 17:47 ` Mike Christie 2021-05-27 13:23 ` Stefano Garzarella 2021-05-27 13:23 ` Stefano Garzarella
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210525174733.6212-4-michael.christie@oracle.com \ --to=michael.christie@oracle.com \ --cc=jasowang@redhat.com \ --cc=linux-scsi@vger.kernel.org \ --cc=mst@redhat.com \ --cc=pbonzini@redhat.com \ --cc=sgarzare@redhat.com \ --cc=stefanha@redhat.com \ --cc=target-devel@vger.kernel.org \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.