All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bruno Larsen (billionai)" <bruno.larsen@eldorado.org.br>
To: qemu-devel@nongnu.org
Cc: farosas@linux.ibm.com, richard.henderson@linaro.org,
	luis.pires@eldorado.org.br, Greg Kurz <groug@kaod.org>,
	lucas.araujo@eldorado.org.br, fernando.valle@eldorado.org.br,
	qemu-ppc@nongnu.org, matheus.ferst@eldorado.org.br,
	david@gibson.dropbear.id.au
Subject: [PATCH 3/5] target/ppc: removed mentions to DO_PPC_STATISTICS
Date: Wed, 26 May 2021 17:21:02 -0300	[thread overview]
Message-ID: <20210526202104.127910-4-bruno.larsen@eldorado.org.br> (raw)
In-Reply-To: <20210526202104.127910-1-bruno.larsen@eldorado.org.br>

Removed the commented out definition and all ifdefs relating to
PPC_DUMP_STATISTICS, as it's hardly ever used.

Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br>
---
 target/ppc/translate.c | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index fc9fd790ca..0525e1939f 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -47,7 +47,6 @@
 
 /* Include definitions for instructions classes and implementations flags */
 /* #define PPC_DEBUG_DISAS */
-/* #define DO_PPC_STATISTICS */
 
 #ifdef PPC_DEBUG_DISAS
 #  define LOG_DISAS(...) qemu_log_mask(CPU_LOG_TB_IN_ASM, ## __VA_ARGS__)
@@ -217,12 +216,9 @@ struct opc_handler_t {
     uint64_t type2;
     /* handler */
     void (*handler)(DisasContext *ctx);
-#if defined(DO_PPC_STATISTICS) || defined(PPC_DUMP_CPU)
+#if defined(PPC_DUMP_CPU)
     const char *oname;
 #endif
-#if defined(DO_PPC_STATISTICS)
-    uint64_t count;
-#endif
 };
 
 /* SPR load/store helpers */
@@ -8546,7 +8542,7 @@ static int register_direct_insn(opc_handler_t **ppc_opcodes,
     if (insert_in_table(ppc_opcodes, idx, handler) < 0) {
         printf("*** ERROR: opcode %02x already assigned in main "
                "opcode table\n", idx);
-#if defined(DO_PPC_STATISTICS) || defined(PPC_DUMP_CPU)
+#if defined(PPC_DUMP_CPU)
         printf("           Registered handler '%s' - new handler '%s'\n",
                ppc_opcodes[idx]->oname, handler->oname);
 #endif
@@ -8570,7 +8566,7 @@ static int register_ind_in_table(opc_handler_t **table,
         if (!is_indirect_opcode(table[idx1])) {
             printf("*** ERROR: idx %02x already assigned to a direct "
                    "opcode\n", idx1);
-#if defined(DO_PPC_STATISTICS) || defined(PPC_DUMP_CPU)
+#if defined(PPC_DUMP_CPU)
             printf("           Registered handler '%s' - new handler '%s'\n",
                    ind_table(table[idx1])[idx2]->oname, handler->oname);
 #endif
@@ -8581,7 +8577,7 @@ static int register_ind_in_table(opc_handler_t **table,
         insert_in_table(ind_table(table[idx1]), idx2, handler) < 0) {
         printf("*** ERROR: opcode %02x already assigned in "
                "opcode table %02x\n", idx2, idx1);
-#if defined(DO_PPC_STATISTICS) || defined(PPC_DUMP_CPU)
+#if defined(PPC_DUMP_CPU)
         printf("           Registered handler '%s' - new handler '%s'\n",
                ind_table(table[idx1])[idx2]->oname, handler->oname);
 #endif
@@ -9036,10 +9032,6 @@ static void ppc_tr_translate_insn(DisasContextBase *dcbase, CPUState *cs)
         gen_invalid(ctx);
     }
 
-#if defined(DO_PPC_STATISTICS)
-    handler->count++;
-#endif
-
     translator_loop_temp_check(&ctx->base);
 }
 
-- 
2.17.1



  parent reply	other threads:[~2021-05-26 20:35 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26 20:20 [PATCH 0/5] stop collection of instruction usage statistics Bruno Larsen (billionai)
2021-05-26 20:21 ` [PATCH 1/5] target/ppc: fixed GEN_OPCODE behavior when PPC_DUMP_CPU is set Bruno Larsen (billionai)
2021-05-26 21:13   ` Luis Fernando Fujita Pires
2021-05-26 21:24     ` Richard Henderson
2021-05-27  1:18       ` david
2021-05-26 20:21 ` [PATCH 2/5] target/ppc: remove ppc_cpu_dump_statistics Bruno Larsen (billionai)
2021-05-26 21:25   ` Richard Henderson
2021-05-26 21:27   ` Luis Fernando Fujita Pires
2021-05-27  1:20   ` David Gibson
2021-05-27  4:35     ` David Gibson
2021-05-27 13:22       ` Bruno Piazera Larsen
2021-05-27 14:01         ` Greg Kurz
2021-05-29  5:46           ` David Gibson
2021-05-27  6:01   ` Greg Kurz
2021-05-29  5:47     ` David Gibson
2021-05-31 14:26       ` Bruno Piazera Larsen
2021-05-26 20:21 ` Bruno Larsen (billionai) [this message]
2021-05-26 21:26   ` [PATCH 3/5] target/ppc: removed mentions to DO_PPC_STATISTICS Richard Henderson
2021-05-26 21:35   ` Luis Fernando Fujita Pires
2021-05-27  4:37   ` David Gibson
2021-05-26 20:21 ` [PATCH 4/5] monitor: removed cpustats command Bruno Larsen (billionai)
2021-05-26 21:28   ` Richard Henderson
2021-05-27  4:40     ` David Gibson
2021-05-26 21:35   ` Luis Fernando Fujita Pires
2021-05-27  6:40   ` Greg Kurz
2021-05-27  8:09     ` Dr. David Alan Gilbert
2021-05-27  8:30       ` Greg Kurz
2021-05-27 11:24         ` Bruno Piazera Larsen
2021-05-27 14:57           ` Greg Kurz
2021-06-08 15:10     ` Markus Armbruster
2021-06-08 15:15       ` Greg Kurz
2021-05-27  8:08   ` Dr. David Alan Gilbert
2021-05-26 20:21 ` [PATCH 5/5] hw/core/cpu: removed cpu_dump_statistics function Bruno Larsen (billionai)
2021-05-26 21:29   ` Richard Henderson
2021-05-26 21:35   ` Luis Fernando Fujita Pires
2021-05-27  1:21   ` David Gibson
2021-05-27 21:05   ` Eduardo Habkost
2021-05-27 13:57 ` [PATCH 0/5] stop collection of instruction usage statistics Alex Bennée
2021-05-27 14:23   ` Bruno Piazera Larsen
2021-05-27 14:25   ` Luis Fernando Fujita Pires
2021-05-27 14:56     ` Alex Bennée
2021-05-27 15:39       ` Luis Fernando Fujita Pires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210526202104.127910-4-bruno.larsen@eldorado.org.br \
    --to=bruno.larsen@eldorado.org.br \
    --cc=david@gibson.dropbear.id.au \
    --cc=farosas@linux.ibm.com \
    --cc=fernando.valle@eldorado.org.br \
    --cc=groug@kaod.org \
    --cc=lucas.araujo@eldorado.org.br \
    --cc=luis.pires@eldorado.org.br \
    --cc=matheus.ferst@eldorado.org.br \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.