All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shai Malin <smalin@marvell.com>
To: <netdev@vger.kernel.org>, <linux-nvme@lists.infradead.org>,
	<davem@davemloft.net>, <kuba@kernel.org>, <sagi@grimberg.me>,
	<hch@lst.de>, <axboe@fb.com>, <kbusch@kernel.org>
Cc: <aelior@marvell.com>, <mkalderon@marvell.com>,
	<okulkarni@marvell.com>, <pkushwaha@marvell.com>,
	<malin1024@gmail.com>, <smalin@marvell.com>
Subject: [RFC PATCH v6 03/27] nvme-fabrics: Expose nvmf_check_required_opts() globally
Date: Fri, 28 May 2021 02:58:38 +0300	[thread overview]
Message-ID: <20210527235902.2185-4-smalin@marvell.com> (raw)
In-Reply-To: <20210527235902.2185-1-smalin@marvell.com>

From: Prabhakar Kushwaha <pkushwaha@marvell.com>

nvmf_check_required_opts() is used to check if user provided opts has
the required_opts or not. if not, it will log which options are not
provided.

It can be leveraged by nvme-tcp-offload to check if provided opts are
supported by this specific vendor driver or not.

So expose nvmf_check_required_opts() globally.

Acked-by: Igor Russkikh <irusskikh@marvell.com>
Signed-off-by: Prabhakar Kushwaha <pkushwaha@marvell.com>
Signed-off-by: Omkar Kulkarni <okulkarni@marvell.com>
Signed-off-by: Michal Kalderon <mkalderon@marvell.com>
Signed-off-by: Ariel Elior <aelior@marvell.com>
Signed-off-by: Shai Malin <smalin@marvell.com>
---
 drivers/nvme/host/fabrics.c | 5 +++--
 drivers/nvme/host/fabrics.h | 2 ++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
index e1e05aa2fada..ceb263eb50fb 100644
--- a/drivers/nvme/host/fabrics.c
+++ b/drivers/nvme/host/fabrics.c
@@ -860,8 +860,8 @@ static int nvmf_parse_options(struct nvmf_ctrl_options *opts,
 	return ret;
 }
 
-static int nvmf_check_required_opts(struct nvmf_ctrl_options *opts,
-		unsigned int required_opts)
+int nvmf_check_required_opts(struct nvmf_ctrl_options *opts,
+			     unsigned int required_opts)
 {
 	if ((opts->mask & required_opts) != required_opts) {
 		int i;
@@ -879,6 +879,7 @@ static int nvmf_check_required_opts(struct nvmf_ctrl_options *opts,
 
 	return 0;
 }
+EXPORT_SYMBOL_GPL(nvmf_check_required_opts);
 
 bool nvmf_ip_options_match(struct nvme_ctrl *ctrl,
 		struct nvmf_ctrl_options *opts)
diff --git a/drivers/nvme/host/fabrics.h b/drivers/nvme/host/fabrics.h
index ce7fe3a842b1..8399fcc063ef 100644
--- a/drivers/nvme/host/fabrics.h
+++ b/drivers/nvme/host/fabrics.h
@@ -193,5 +193,7 @@ int nvmf_get_address(struct nvme_ctrl *ctrl, char *buf, int size);
 bool nvmf_should_reconnect(struct nvme_ctrl *ctrl);
 bool nvmf_ip_options_match(struct nvme_ctrl *ctrl,
 		struct nvmf_ctrl_options *opts);
+int nvmf_check_required_opts(struct nvmf_ctrl_options *opts,
+			     unsigned int required_opts);
 
 #endif /* _NVME_FABRICS_H */
-- 
2.22.0


WARNING: multiple messages have this Message-ID (diff)
From: Shai Malin <smalin@marvell.com>
To: <netdev@vger.kernel.org>, <linux-nvme@lists.infradead.org>,
	<davem@davemloft.net>, <kuba@kernel.org>, <sagi@grimberg.me>,
	<hch@lst.de>, <axboe@fb.com>, <kbusch@kernel.org>
Cc: <aelior@marvell.com>, <mkalderon@marvell.com>,
	<okulkarni@marvell.com>, <pkushwaha@marvell.com>,
	<malin1024@gmail.com>, <smalin@marvell.com>
Subject: [RFC PATCH v6 03/27] nvme-fabrics: Expose nvmf_check_required_opts() globally
Date: Fri, 28 May 2021 02:58:38 +0300	[thread overview]
Message-ID: <20210527235902.2185-4-smalin@marvell.com> (raw)
In-Reply-To: <20210527235902.2185-1-smalin@marvell.com>

From: Prabhakar Kushwaha <pkushwaha@marvell.com>

nvmf_check_required_opts() is used to check if user provided opts has
the required_opts or not. if not, it will log which options are not
provided.

It can be leveraged by nvme-tcp-offload to check if provided opts are
supported by this specific vendor driver or not.

So expose nvmf_check_required_opts() globally.

Acked-by: Igor Russkikh <irusskikh@marvell.com>
Signed-off-by: Prabhakar Kushwaha <pkushwaha@marvell.com>
Signed-off-by: Omkar Kulkarni <okulkarni@marvell.com>
Signed-off-by: Michal Kalderon <mkalderon@marvell.com>
Signed-off-by: Ariel Elior <aelior@marvell.com>
Signed-off-by: Shai Malin <smalin@marvell.com>
---
 drivers/nvme/host/fabrics.c | 5 +++--
 drivers/nvme/host/fabrics.h | 2 ++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
index e1e05aa2fada..ceb263eb50fb 100644
--- a/drivers/nvme/host/fabrics.c
+++ b/drivers/nvme/host/fabrics.c
@@ -860,8 +860,8 @@ static int nvmf_parse_options(struct nvmf_ctrl_options *opts,
 	return ret;
 }
 
-static int nvmf_check_required_opts(struct nvmf_ctrl_options *opts,
-		unsigned int required_opts)
+int nvmf_check_required_opts(struct nvmf_ctrl_options *opts,
+			     unsigned int required_opts)
 {
 	if ((opts->mask & required_opts) != required_opts) {
 		int i;
@@ -879,6 +879,7 @@ static int nvmf_check_required_opts(struct nvmf_ctrl_options *opts,
 
 	return 0;
 }
+EXPORT_SYMBOL_GPL(nvmf_check_required_opts);
 
 bool nvmf_ip_options_match(struct nvme_ctrl *ctrl,
 		struct nvmf_ctrl_options *opts)
diff --git a/drivers/nvme/host/fabrics.h b/drivers/nvme/host/fabrics.h
index ce7fe3a842b1..8399fcc063ef 100644
--- a/drivers/nvme/host/fabrics.h
+++ b/drivers/nvme/host/fabrics.h
@@ -193,5 +193,7 @@ int nvmf_get_address(struct nvme_ctrl *ctrl, char *buf, int size);
 bool nvmf_should_reconnect(struct nvme_ctrl *ctrl);
 bool nvmf_ip_options_match(struct nvme_ctrl *ctrl,
 		struct nvmf_ctrl_options *opts);
+int nvmf_check_required_opts(struct nvmf_ctrl_options *opts,
+			     unsigned int required_opts);
 
 #endif /* _NVME_FABRICS_H */
-- 
2.22.0


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  parent reply	other threads:[~2021-05-28  0:00 UTC|newest]

Thread overview: 104+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-27 23:58 [RFC PATCH v6 00/27] NVMeTCP Offload ULP and QEDN Device Driver Shai Malin
2021-05-27 23:58 ` Shai Malin
2021-05-27 23:58 ` [RFC PATCH v6 01/27] nvme-tcp-offload: Add nvme-tcp-offload - NVMeTCP HW offload ULP Shai Malin
2021-05-27 23:58   ` Shai Malin
2021-05-28  2:30   ` kernel test robot
2021-05-28  3:30   ` kernel test robot
2021-05-28  4:30   ` kernel test robot
2021-05-27 23:58 ` [RFC PATCH v6 02/27] nvme-fabrics: Move NVMF_ALLOWED_OPTS and NVMF_REQUIRED_OPTS definitions Shai Malin
2021-05-27 23:58   ` Shai Malin
2021-05-28 10:18   ` Hannes Reinecke
2021-05-28 10:18     ` Hannes Reinecke
2021-05-27 23:58 ` Shai Malin [this message]
2021-05-27 23:58   ` [RFC PATCH v6 03/27] nvme-fabrics: Expose nvmf_check_required_opts() globally Shai Malin
2021-05-28 10:18   ` Hannes Reinecke
2021-05-28 10:18     ` Hannes Reinecke
2021-05-27 23:58 ` [RFC PATCH v6 04/27] nvme-tcp-offload: Add device scan implementation Shai Malin
2021-05-27 23:58   ` Shai Malin
2021-05-28  2:52   ` kernel test robot
2021-05-28  4:08   ` kernel test robot
2021-05-28 10:28   ` Hannes Reinecke
2021-05-28 10:28     ` Hannes Reinecke
2021-05-27 23:58 ` [RFC PATCH v6 05/27] nvme-tcp-offload: Add controller level implementation Shai Malin
2021-05-27 23:58   ` Shai Malin
2021-05-28  4:36   ` kernel test robot
2021-05-28  5:17   ` kernel test robot
2021-05-28 11:21   ` Hannes Reinecke
2021-05-28 11:21     ` Hannes Reinecke
2021-05-31 14:02     ` Shai Malin
2021-05-31 14:02       ` Shai Malin
2021-05-27 23:58 ` [RFC PATCH v6 06/27] nvme-tcp-offload: Add controller level error recovery implementation Shai Malin
2021-05-27 23:58   ` Shai Malin
2021-05-28  6:31   ` kernel test robot
2021-05-27 23:58 ` [RFC PATCH v6 07/27] nvme-tcp-offload: Add queue level implementation Shai Malin
2021-05-27 23:58   ` Shai Malin
2021-05-28 11:29   ` Hannes Reinecke
2021-05-28 11:29     ` Hannes Reinecke
2021-05-31 14:04     ` Shai Malin
2021-05-31 14:04       ` Shai Malin
2021-05-27 23:58 ` [RFC PATCH v6 08/27] nvme-tcp-offload: Add IO " Shai Malin
2021-05-27 23:58   ` Shai Malin
2021-05-28  3:30   ` kernel test robot
2021-05-28  4:55   ` kernel test robot
2021-05-27 23:58 ` [RFC PATCH v6 09/27] qed: Add TCP_ULP FW resource layout Shai Malin
2021-05-27 23:58   ` Shai Malin
2021-05-28 11:31   ` Hannes Reinecke
2021-05-28 11:31     ` Hannes Reinecke
2021-05-27 23:58 ` [RFC PATCH v6 10/27] qed: Add NVMeTCP Offload PF Level FW and HW HSI Shai Malin
2021-05-27 23:58   ` Shai Malin
2021-05-28 12:01   ` Hannes Reinecke
2021-05-28 12:01     ` Hannes Reinecke
2021-05-27 23:58 ` [RFC PATCH v6 11/27] qed: Add NVMeTCP Offload Connection " Shai Malin
2021-05-27 23:58   ` Shai Malin
2021-05-28 12:41   ` Hannes Reinecke
2021-05-28 12:41     ` Hannes Reinecke
2021-05-27 23:58 ` [RFC PATCH v6 12/27] qed: Add support of HW filter block Shai Malin
2021-05-27 23:58   ` Shai Malin
2021-05-28  4:34   ` kernel test robot
2021-05-28  4:34   ` [RFC PATCH] qed: qed_abs_ppfid() can be static kernel test robot
2021-05-27 23:58 ` [RFC PATCH v6 13/27] qed: Add NVMeTCP Offload IO Level FW and HW HSI Shai Malin
2021-05-27 23:58   ` Shai Malin
2021-05-28 12:41   ` Hannes Reinecke
2021-05-28 12:41     ` Hannes Reinecke
2021-05-27 23:58 ` [RFC PATCH v6 14/27] qed: Add NVMeTCP Offload IO Level FW Initializations Shai Malin
2021-05-27 23:58   ` Shai Malin
2021-05-28 12:43   ` Hannes Reinecke
2021-05-28 12:43     ` Hannes Reinecke
2021-05-27 23:58 ` [RFC PATCH v6 15/27] qed: Add IP services APIs support Shai Malin
2021-05-27 23:58   ` Shai Malin
2021-05-27 23:58 ` [RFC PATCH v6 16/27] qedn: Add qedn - Marvell's NVMeTCP HW offload vendor driver Shai Malin
2021-05-27 23:58   ` Shai Malin
2021-05-27 23:58 ` [RFC PATCH v6 17/27] qedn: Add qedn probe Shai Malin
2021-05-27 23:58   ` Shai Malin
2021-05-27 23:58 ` [RFC PATCH v6 18/27] qedn: Add qedn_claim_dev API support Shai Malin
2021-05-27 23:58   ` Shai Malin
2021-05-27 23:58 ` [RFC PATCH v6 19/27] qedn: Add IRQ and fast-path resources initializations Shai Malin
2021-05-27 23:58   ` Shai Malin
2021-05-28 12:46   ` Hannes Reinecke
2021-05-28 12:46     ` Hannes Reinecke
2021-05-27 23:58 ` [RFC PATCH v6 20/27] qedn: Add connection-level slowpath functionality Shai Malin
2021-05-27 23:58   ` Shai Malin
2021-05-27 23:58 ` [RFC PATCH v6 21/27] qedn: Add support of configuring HW filter block Shai Malin
2021-05-27 23:58   ` Shai Malin
2021-05-27 23:58 ` [RFC PATCH v6 22/27] qedn: Add IO level qedn_send_req and fw_cq workqueue Shai Malin
2021-05-27 23:58   ` Shai Malin
2021-05-28 12:57   ` Hannes Reinecke
2021-05-28 12:57     ` Hannes Reinecke
2021-05-31 14:12     ` Shai Malin
2021-05-31 14:12       ` Shai Malin
2021-05-27 23:58 ` [RFC PATCH v6 23/27] qedn: Add support of Task and SGL Shai Malin
2021-05-27 23:58   ` Shai Malin
2021-05-28 13:06   ` Hannes Reinecke
2021-05-28 13:06     ` Hannes Reinecke
2021-05-31 14:14     ` Shai Malin
2021-05-31 14:14       ` Shai Malin
2021-05-27 23:58 ` [RFC PATCH v6 24/27] qedn: Add support of NVME ICReq & ICResp Shai Malin
2021-05-27 23:58   ` Shai Malin
2021-05-28 13:07   ` Hannes Reinecke
2021-05-28 13:07     ` Hannes Reinecke
2021-05-27 23:59 ` [RFC PATCH v6 25/27] qedn: Add IO level fastpath functionality Shai Malin
2021-05-27 23:59   ` Shai Malin
2021-05-27 23:59 ` [RFC PATCH v6 26/27] qedn: Add Connection and IO level recovery flows Shai Malin
2021-05-27 23:59   ` Shai Malin
2021-05-27 23:59 ` [RFC PATCH v6 27/27] qedn: Add support of ASYNC Shai Malin
2021-05-27 23:59   ` Shai Malin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210527235902.2185-4-smalin@marvell.com \
    --to=smalin@marvell.com \
    --cc=aelior@marvell.com \
    --cc=axboe@fb.com \
    --cc=davem@davemloft.net \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=malin1024@gmail.com \
    --cc=mkalderon@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=okulkarni@marvell.com \
    --cc=pkushwaha@marvell.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.