From: Uma Shankar <uma.shankar@intel.com> To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: Uma Shankar <uma.shankar@intel.com>, bhanuprakash.modem@intel.com Subject: [PATCH 6/9] drm/i915/xelpd: logarithmic gamma enabled only with advance gamma mode Date: Tue, 1 Jun 2021 16:11:32 +0530 [thread overview] Message-ID: <20210601104135.29020-7-uma.shankar@intel.com> (raw) In-Reply-To: <20210601104135.29020-1-uma.shankar@intel.com> Only Enable Logarithmic Gamma if client caps for advance gamma mode is enabled. Fallback to 10bit gamma in case its not supported. Signed-off-by: Uma Shankar <uma.shankar@intel.com> --- drivers/gpu/drm/i915/display/intel_color.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c index cae96fbec1a7..18b51b9cc2aa 100644 --- a/drivers/gpu/drm/i915/display/intel_color.c +++ b/drivers/gpu/drm/i915/display/intel_color.c @@ -1606,13 +1606,17 @@ static u32 icl_gamma_mode(const struct intel_crtc_state *crtc_state) gamma_mode |= POST_CSC_GAMMA_ENABLE; if (!crtc_state->hw.gamma_lut || - crtc_state_is_legacy_gamma(crtc_state)) + crtc_state_is_legacy_gamma(crtc_state)) { gamma_mode |= GAMMA_MODE_MODE_8BIT; - else if (crtc_state->uapi.gamma_mode_type == - GAMMA_MODE_LOGARITHMIC_12BIT) - gamma_mode |= GAMMA_MODE_MODE_12BIT_LOGARITHMIC; - else + } else if (crtc_state->uapi.gamma_mode_type == + GAMMA_MODE_LOGARITHMIC_12BIT) { + if (crtc_state->uapi.advance_gamma_mode_active) + gamma_mode |= GAMMA_MODE_MODE_12BIT_LOGARITHMIC; + else + gamma_mode |= GAMMA_MODE_MODE_10BIT; + } else { gamma_mode |= GAMMA_MODE_MODE_12BIT_MULTI_SEGMENTED; + } return gamma_mode; } -- 2.26.2
WARNING: multiple messages have this Message-ID (diff)
From: Uma Shankar <uma.shankar@intel.com> To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [Intel-gfx] [PATCH 6/9] drm/i915/xelpd: logarithmic gamma enabled only with advance gamma mode Date: Tue, 1 Jun 2021 16:11:32 +0530 [thread overview] Message-ID: <20210601104135.29020-7-uma.shankar@intel.com> (raw) In-Reply-To: <20210601104135.29020-1-uma.shankar@intel.com> Only Enable Logarithmic Gamma if client caps for advance gamma mode is enabled. Fallback to 10bit gamma in case its not supported. Signed-off-by: Uma Shankar <uma.shankar@intel.com> --- drivers/gpu/drm/i915/display/intel_color.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c index cae96fbec1a7..18b51b9cc2aa 100644 --- a/drivers/gpu/drm/i915/display/intel_color.c +++ b/drivers/gpu/drm/i915/display/intel_color.c @@ -1606,13 +1606,17 @@ static u32 icl_gamma_mode(const struct intel_crtc_state *crtc_state) gamma_mode |= POST_CSC_GAMMA_ENABLE; if (!crtc_state->hw.gamma_lut || - crtc_state_is_legacy_gamma(crtc_state)) + crtc_state_is_legacy_gamma(crtc_state)) { gamma_mode |= GAMMA_MODE_MODE_8BIT; - else if (crtc_state->uapi.gamma_mode_type == - GAMMA_MODE_LOGARITHMIC_12BIT) - gamma_mode |= GAMMA_MODE_MODE_12BIT_LOGARITHMIC; - else + } else if (crtc_state->uapi.gamma_mode_type == + GAMMA_MODE_LOGARITHMIC_12BIT) { + if (crtc_state->uapi.advance_gamma_mode_active) + gamma_mode |= GAMMA_MODE_MODE_12BIT_LOGARITHMIC; + else + gamma_mode |= GAMMA_MODE_MODE_10BIT; + } else { gamma_mode |= GAMMA_MODE_MODE_12BIT_MULTI_SEGMENTED; + } return gamma_mode; } -- 2.26.2 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-06-01 10:06 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-01 10:41 [PATCH 0/9] Enhance pipe color support for multi segmented luts Uma Shankar 2021-06-01 10:41 ` [Intel-gfx] " Uma Shankar 2021-06-01 10:41 ` [PATCH 1/9] drm: Add gamma mode property Uma Shankar 2021-06-01 10:41 ` [Intel-gfx] " Uma Shankar 2021-06-02 9:09 ` Pekka Paalanen 2021-06-02 9:09 ` [Intel-gfx] " Pekka Paalanen 2021-06-02 20:18 ` Shankar, Uma 2021-06-02 20:18 ` [Intel-gfx] " Shankar, Uma 2021-06-03 8:05 ` Pekka Paalanen 2021-06-03 8:05 ` [Intel-gfx] " Pekka Paalanen 2021-06-01 10:41 ` [PATCH 2/9] drm/i915/xelpd: Define color lut range structure Uma Shankar 2021-06-01 10:41 ` [Intel-gfx] " Uma Shankar 2021-06-01 10:41 ` [PATCH 3/9] drm/i915/xelpd: Add support for Logarithmic gamma mode Uma Shankar 2021-06-01 10:41 ` [Intel-gfx] " Uma Shankar 2021-06-01 10:41 ` [PATCH 4/9] drm/i915/xelpd: Attach gamma mode property Uma Shankar 2021-06-01 10:41 ` [Intel-gfx] " Uma Shankar 2021-06-01 10:41 ` [PATCH 5/9] drm: Add Client Cap for advance gamma mode Uma Shankar 2021-06-01 10:41 ` [Intel-gfx] " Uma Shankar 2021-06-02 2:53 ` kernel test robot 2021-06-02 2:53 ` kernel test robot 2021-06-02 2:53 ` [Intel-gfx] " kernel test robot 2021-06-02 9:03 ` Pekka Paalanen 2021-06-02 9:03 ` [Intel-gfx] " Pekka Paalanen 2021-06-02 20:08 ` Shankar, Uma 2021-06-02 20:08 ` [Intel-gfx] " Shankar, Uma 2021-06-01 10:41 ` Uma Shankar [this message] 2021-06-01 10:41 ` [Intel-gfx] [PATCH 6/9] drm/i915/xelpd: logarithmic gamma enabled only with " Uma Shankar 2021-06-01 10:41 ` [PATCH 7/9] drm/i915/xelpd: Enable Pipe Degamma Uma Shankar 2021-06-01 10:41 ` [Intel-gfx] " Uma Shankar 2021-06-01 10:41 ` [PATCH 8/9] drm/i915/xelpd: Add Pipe Color Lut caps to platform config Uma Shankar 2021-06-01 10:41 ` [Intel-gfx] " Uma Shankar 2021-06-01 10:41 ` [PATCH 9/9] drm/i915/xelpd: Enable XE_LPD Gamma Lut readout Uma Shankar 2021-06-01 10:41 ` [Intel-gfx] " Uma Shankar 2021-06-01 12:47 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enhance pipe color support for multi segmented luts Patchwork 2021-06-01 13:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-06-01 17:12 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2021-06-04 18:51 ` [PATCH 0/9] " Harry Wentland 2021-06-04 18:51 ` [Intel-gfx] " Harry Wentland 2021-06-07 7:29 ` Pekka Paalanen 2021-06-07 7:29 ` [Intel-gfx] " Pekka Paalanen 2021-06-07 18:07 ` Shankar, Uma 2021-06-07 18:07 ` [Intel-gfx] " Shankar, Uma 2021-06-08 7:59 ` Pekka Paalanen 2021-06-08 7:59 ` [Intel-gfx] " Pekka Paalanen 2021-06-07 18:01 ` Shankar, Uma 2021-06-07 18:01 ` [Intel-gfx] " Shankar, Uma 2021-06-07 21:00 ` Harry Wentland 2021-06-07 21:00 ` [Intel-gfx] " Harry Wentland
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210601104135.29020-7-uma.shankar@intel.com \ --to=uma.shankar@intel.com \ --cc=bhanuprakash.modem@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.