All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: devicetree@vger.kernel.org
Cc: Sudeep Holla <sudeep.holla@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	Cristian Marussi <cristian.marussi@arm.com>,
	Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH v3 1/6] dt-bindings: mailbox : arm,mhu: Fix arm,scpi example used here
Date: Fri,  4 Jun 2021 21:57:05 +0100	[thread overview]
Message-ID: <20210604205710.1944363-2-sudeep.holla@arm.com> (raw)
In-Reply-To: <20210604205710.1944363-1-sudeep.holla@arm.com>

Once the arm,scpi binding is converted to YAML format, the following
errors will be seen when doing `make DT_CHECKER_FLAGS=-m dt_binding_check`

From schema: Documentation/devicetree/bindings/firmware/arm,scpi.yaml
Documentation/devicetree/bindings/mailbox/arm,mhu.example.dt.yaml:
	scpi@2f000000: $nodename:0: 'scpi' was expected
Documentation/devicetree/bindings/mailbox/arm,mhu.example.dt.yaml:
	scpi@2f000000: reg: [[0, 788529152, 0, 512]] is not of type 'object'
Documentation/devicetree/bindings/mailbox/arm,mhu.example.dt.yaml:
	scpi@2f000000: 'shmem' is a required property

Fix those error following the SCPI bindings.

Cc: Rob Herring <robh+dt@kernel.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 Documentation/devicetree/bindings/mailbox/arm,mhu.yaml | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
index d07eb00b97c8..496308d91a86 100644
--- a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
+++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
@@ -126,9 +126,15 @@ additionalProperties: false
             clock-names = "apb_pclk";
         };
 
-        mhu_client_scpi: scpi@2f000000 {
+        scpi {
             compatible = "arm,scpi";
-            reg = <0 0x2f000000 0 0x200>;
             mboxes = <&mhuB 1 4>; /* HP-NonSecure, 5th doorbell */
+            shmem = <&cpu_scp_hpri>; /* HP-NonSecure */
+
+            scpi_devpd: power-controller {
+                compatible = "arm,scpi-power-domains";
+                num-domains = <2>;
+                #power-domain-cells = <1>;
+            };
         };
     };
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: devicetree@vger.kernel.org
Cc: Sudeep Holla <sudeep.holla@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	Cristian Marussi <cristian.marussi@arm.com>,
	Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH v3 1/6] dt-bindings: mailbox : arm, mhu: Fix arm, scpi example used here
Date: Fri,  4 Jun 2021 21:57:05 +0100	[thread overview]
Message-ID: <20210604205710.1944363-2-sudeep.holla@arm.com> (raw)
In-Reply-To: <20210604205710.1944363-1-sudeep.holla@arm.com>

Once the arm,scpi binding is converted to YAML format, the following
errors will be seen when doing `make DT_CHECKER_FLAGS=-m dt_binding_check`

From schema: Documentation/devicetree/bindings/firmware/arm,scpi.yaml
Documentation/devicetree/bindings/mailbox/arm,mhu.example.dt.yaml:
	scpi@2f000000: $nodename:0: 'scpi' was expected
Documentation/devicetree/bindings/mailbox/arm,mhu.example.dt.yaml:
	scpi@2f000000: reg: [[0, 788529152, 0, 512]] is not of type 'object'
Documentation/devicetree/bindings/mailbox/arm,mhu.example.dt.yaml:
	scpi@2f000000: 'shmem' is a required property

Fix those error following the SCPI bindings.

Cc: Rob Herring <robh+dt@kernel.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 Documentation/devicetree/bindings/mailbox/arm,mhu.yaml | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
index d07eb00b97c8..496308d91a86 100644
--- a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
+++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
@@ -126,9 +126,15 @@ additionalProperties: false
             clock-names = "apb_pclk";
         };
 
-        mhu_client_scpi: scpi@2f000000 {
+        scpi {
             compatible = "arm,scpi";
-            reg = <0 0x2f000000 0 0x200>;
             mboxes = <&mhuB 1 4>; /* HP-NonSecure, 5th doorbell */
+            shmem = <&cpu_scp_hpri>; /* HP-NonSecure */
+
+            scpi_devpd: power-controller {
+                compatible = "arm,scpi-power-domains";
+                num-domains = <2>;
+                #power-domain-cells = <1>;
+            };
         };
     };
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-04 20:57 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-04 20:57 [PATCH v3 0/6] dt-bindings: firmware: Convert SCPI and SCMI to json schema Sudeep Holla
2021-06-04 20:57 ` Sudeep Holla
2021-06-04 20:57 ` Sudeep Holla [this message]
2021-06-04 20:57   ` [PATCH v3 1/6] dt-bindings: mailbox : arm, mhu: Fix arm, scpi example used here Sudeep Holla
2021-06-04 21:59   ` [PATCH v3 1/6] dt-bindings: mailbox : arm,mhu: Fix arm,scpi " Rob Herring
2021-06-04 21:59     ` Rob Herring
2021-06-04 20:57 ` [PATCH v3 2/6] dt-bindings: firmware: arm,scpi: Convert to json schema Sudeep Holla
2021-06-04 20:57   ` [PATCH v3 2/6] dt-bindings: firmware: arm, scpi: " Sudeep Holla
2021-06-04 22:11   ` [PATCH v3 2/6] dt-bindings: firmware: arm,scpi: " Rob Herring
2021-06-04 22:11     ` Rob Herring
2021-06-04 20:57 ` [PATCH v3 3/6] dt-bindings: firmware: amlogic,scpi: " Sudeep Holla
2021-06-04 20:57   ` [PATCH v3 3/6] dt-bindings: firmware: amlogic, scpi: " Sudeep Holla
2021-06-04 22:11   ` [PATCH v3 3/6] dt-bindings: firmware: amlogic,scpi: " Rob Herring
2021-06-04 22:11     ` Rob Herring
2021-06-04 20:57 ` [PATCH v3 4/6] dt-bindings: firmware: arm,scmi: " Sudeep Holla
2021-06-04 20:57   ` [PATCH v3 4/6] dt-bindings: firmware: arm, scmi: " Sudeep Holla
2021-06-04 22:12   ` [PATCH v3 4/6] dt-bindings: firmware: arm,scmi: " Rob Herring
2021-06-04 22:12     ` Rob Herring
2021-06-04 20:57 ` [PATCH v3 5/6] dt-bindings: mailbox : arm,mhu: Use examples with matching schema Sudeep Holla
2021-06-04 20:57   ` [PATCH v3 5/6] dt-bindings: mailbox : arm, mhu: " Sudeep Holla
2021-06-04 22:25   ` [PATCH v3 5/6] dt-bindings: mailbox : arm,mhu: " Rob Herring
2021-06-04 22:25     ` [PATCH v3 5/6] dt-bindings: mailbox : arm, mhu: " Rob Herring
2021-06-04 20:57 ` [PATCH v3 6/6] dt-bindings: mailbox : arm,mhuv2: Use example " Sudeep Holla
2021-06-04 20:57   ` [PATCH v3 6/6] dt-bindings: mailbox : arm, mhuv2: " Sudeep Holla
2021-06-04 22:26   ` [PATCH v3 6/6] dt-bindings: mailbox : arm,mhuv2: " Rob Herring
2021-06-04 22:26     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210604205710.1944363-2-sudeep.holla@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=cristian.marussi@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.