From: Satya Tangirala <satyat@google.com> To: "Theodore Y . Ts'o" <tytso@mit.edu>, Jaegeuk Kim <jaegeuk@kernel.org>, Eric Biggers <ebiggers@kernel.org>, Chao Yu <chao@kernel.org>, Jens Axboe <axboe@kernel.dk>, "Darrick J . Wong" <darrick.wong@oracle.com> Cc: linux-kernel@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-block@vger.kernel.org, linux-ext4@vger.kernel.org, Eric Biggers <ebiggers@google.com>, Satya Tangirala <satyat@google.com> Subject: [PATCH v9 8/9] f2fs: support direct I/O with fscrypt using blk-crypto Date: Fri, 4 Jun 2021 21:09:07 +0000 [thread overview] Message-ID: <20210604210908.2105870-9-satyat@google.com> (raw) In-Reply-To: <20210604210908.2105870-1-satyat@google.com> From: Eric Biggers <ebiggers@google.com> Wire up f2fs with fscrypt direct I/O support. direct I/O with fscrypt is only supported through blk-crypto (i.e. CONFIG_BLK_INLINE_ENCRYPTION must have been enabled, the 'inlinecrypt' mount option must have been specified, and either hardware inline encryption support must be present or CONFIG_BLK_INLINE_ENCYRPTION_FALLBACK must have been enabled). Further, direct I/O on encrypted files is only supported when the *length* of the I/O is aligned to the filesystem block size (which is *not* necessarily the same as the block device's block size). Signed-off-by: Eric Biggers <ebiggers@google.com> Co-developed-by: Satya Tangirala <satyat@google.com> Signed-off-by: Satya Tangirala <satyat@google.com> Acked-by: Jaegeuk Kim <jaegeuk@kernel.org> --- fs/f2fs/f2fs.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index c83d90125ebd..a416ea3a1a04 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -4181,7 +4181,11 @@ static inline bool f2fs_force_buffered_io(struct inode *inode, struct f2fs_sb_info *sbi = F2FS_I_SB(inode); int rw = iov_iter_rw(iter); - if (f2fs_post_read_required(inode)) + if (!fscrypt_dio_supported(iocb, iter)) + return true; + if (fsverity_active(inode)) + return true; + if (f2fs_compressed_file(inode)) return true; if (f2fs_is_multi_device(sbi)) return true; -- 2.32.0.rc1.229.g3e70b5a671-goog
WARNING: multiple messages have this Message-ID (diff)
From: Satya Tangirala via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net> To: "Theodore Y . Ts'o" <tytso@mit.edu>, Jaegeuk Kim <jaegeuk@kernel.org>, Eric Biggers <ebiggers@kernel.org>, Chao Yu <chao@kernel.org>, Jens Axboe <axboe@kernel.dk>, "Darrick J . Wong" <darrick.wong@oracle.com> Cc: linux-block@vger.kernel.org, Eric Biggers <ebiggers@google.com>, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-fscrypt@vger.kernel.org, Satya Tangirala <satyat@google.com>, linux-ext4@vger.kernel.org Subject: [f2fs-dev] [PATCH v9 8/9] f2fs: support direct I/O with fscrypt using blk-crypto Date: Fri, 4 Jun 2021 21:09:07 +0000 [thread overview] Message-ID: <20210604210908.2105870-9-satyat@google.com> (raw) In-Reply-To: <20210604210908.2105870-1-satyat@google.com> From: Eric Biggers <ebiggers@google.com> Wire up f2fs with fscrypt direct I/O support. direct I/O with fscrypt is only supported through blk-crypto (i.e. CONFIG_BLK_INLINE_ENCRYPTION must have been enabled, the 'inlinecrypt' mount option must have been specified, and either hardware inline encryption support must be present or CONFIG_BLK_INLINE_ENCYRPTION_FALLBACK must have been enabled). Further, direct I/O on encrypted files is only supported when the *length* of the I/O is aligned to the filesystem block size (which is *not* necessarily the same as the block device's block size). Signed-off-by: Eric Biggers <ebiggers@google.com> Co-developed-by: Satya Tangirala <satyat@google.com> Signed-off-by: Satya Tangirala <satyat@google.com> Acked-by: Jaegeuk Kim <jaegeuk@kernel.org> --- fs/f2fs/f2fs.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index c83d90125ebd..a416ea3a1a04 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -4181,7 +4181,11 @@ static inline bool f2fs_force_buffered_io(struct inode *inode, struct f2fs_sb_info *sbi = F2FS_I_SB(inode); int rw = iov_iter_rw(iter); - if (f2fs_post_read_required(inode)) + if (!fscrypt_dio_supported(iocb, iter)) + return true; + if (fsverity_active(inode)) + return true; + if (f2fs_compressed_file(inode)) return true; if (f2fs_is_multi_device(sbi)) return true; -- 2.32.0.rc1.229.g3e70b5a671-goog _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-06-04 21:09 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-04 21:08 [PATCH v9 0/9] add support for direct I/O with fscrypt using blk-crypto Satya Tangirala 2021-06-04 21:08 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2021-06-04 21:09 ` [PATCH v9 1/9] block: blk-crypto-fallback: handle data unit split across multiple bvecs Satya Tangirala 2021-06-04 21:09 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2021-06-04 21:09 ` [PATCH v9 2/9] block: blk-crypto: relax alignment requirements for bvecs in bios Satya Tangirala 2021-06-04 21:09 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2021-06-04 21:09 ` [PATCH v9 3/9] fscrypt: add functions for direct I/O support Satya Tangirala 2021-06-04 21:09 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2021-07-23 20:42 ` Eric Biggers 2021-07-23 20:42 ` [f2fs-dev] " Eric Biggers 2021-06-04 21:09 ` [PATCH v9 4/9] direct-io: add support for fscrypt using blk-crypto Satya Tangirala 2021-06-04 21:09 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2021-06-04 21:09 ` [PATCH v9 5/9] block: Make bio_iov_iter_get_pages() respect bio_required_sector_alignment() Satya Tangirala 2021-06-04 21:09 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2021-06-04 22:51 ` kernel test robot 2021-06-04 22:51 ` kernel test robot 2021-06-05 2:55 ` kernel test robot 2021-06-05 2:55 ` kernel test robot 2021-07-23 21:33 ` Eric Biggers 2021-07-23 21:33 ` [f2fs-dev] " Eric Biggers 2021-07-24 7:19 ` Christoph Hellwig 2021-07-24 7:19 ` [f2fs-dev] " Christoph Hellwig 2021-06-04 21:09 ` [PATCH v9 6/9] iomap: support direct I/O with fscrypt using blk-crypto Satya Tangirala 2021-06-04 21:09 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2021-07-22 19:04 ` Darrick J. Wong 2021-07-22 19:04 ` [f2fs-dev] " Darrick J. Wong 2021-06-04 21:09 ` [PATCH v9 7/9] ext4: " Satya Tangirala 2021-06-04 21:09 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2021-06-04 21:09 ` Satya Tangirala [this message] 2021-06-04 21:09 ` [f2fs-dev] [PATCH v9 8/9] f2fs: " Satya Tangirala via Linux-f2fs-devel 2021-06-04 21:09 ` [PATCH v9 9/9] fscrypt: update documentation for direct I/O support Satya Tangirala 2021-06-04 21:09 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel [not found] ` <CAF2Aj3h-Gt3bOxH4wXB7aeQ3jVzR3TEqd3uLsh4T9Q=e6W6iqQ@mail.gmail.com> 2021-07-22 14:48 ` [PATCH v9 0/9] add support for direct I/O with fscrypt using blk-crypto Eric Biggers 2021-07-22 14:48 ` [f2fs-dev] " Eric Biggers 2021-08-04 8:26 ` Lee Jones 2021-08-04 8:26 ` [f2fs-dev] " Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210604210908.2105870-9-satyat@google.com \ --to=satyat@google.com \ --cc=axboe@kernel.dk \ --cc=chao@kernel.org \ --cc=darrick.wong@oracle.com \ --cc=ebiggers@google.com \ --cc=ebiggers@kernel.org \ --cc=jaegeuk@kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fscrypt@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-xfs@vger.kernel.org \ --cc=tytso@mit.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.