All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
	Kai Vehmanen <kai.vehmanen@linux.intel.com>,
	tiwai@suse.de,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Rander Wang <rander.wang@intel.com>,
	Paul Olaru <paul.olaru@oss.nxp.com>
Subject: [PATCH 07/10] ASoC: Intel: sof_sdw: fix signed/unsigned warning
Date: Mon,  7 Jun 2021 17:46:35 -0500	[thread overview]
Message-ID: <20210607224638.585486-8-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20210607224638.585486-1-pierre-louis.bossart@linux.intel.com>

Sparse throws the following warning:

sound/soc/intel/boards/sof_sdw.c:796:31: error: incorrect type in argument 6 (different signedness)
sound/soc/intel/boards/sof_sdw.c:796:31:    expected int *group_id
sound/soc/intel/boards/sof_sdw.c:796:31:    got unsigned int *

The group_id cannot be negative, use unsigned int.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Paul Olaru <paul.olaru@oss.nxp.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
---
 sound/soc/intel/boards/sof_sdw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/intel/boards/sof_sdw.c b/sound/soc/intel/boards/sof_sdw.c
index 34f142d7b3f9..e9118234b30e 100644
--- a/sound/soc/intel/boards/sof_sdw.c
+++ b/sound/soc/intel/boards/sof_sdw.c
@@ -682,7 +682,7 @@ static int set_codec_init_func(const struct snd_soc_acpi_link_adr *link,
  */
 static int get_slave_info(const struct snd_soc_acpi_link_adr *adr_link,
 			  struct device *dev, int *cpu_dai_id, int *cpu_dai_num,
-			  int *codec_num, int *group_id,
+			  int *codec_num, unsigned int *group_id,
 			  bool *group_generated)
 {
 	const struct snd_soc_acpi_adr_device *adr_d;
-- 
2.25.1


  parent reply	other threads:[~2021-06-07 22:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-07 22:46 [PATCH 00/10] ASoC: Intel: machine driver corrections Pierre-Louis Bossart
2021-06-07 22:46 ` [PATCH 01/10] ASoC: Intel: sof_sdw: use mach data for ADL RVP DMIC count Pierre-Louis Bossart
2021-06-07 22:46 ` [PATCH 02/10] ASoC: Intel: sof_sdw: remove hdac-hdmi support Pierre-Louis Bossart
2021-06-16 13:53   ` Richard Fitzgerald
2021-06-07 22:46 ` [PATCH 03/10] ASoC: Intel: sof_rt5682: shrink platform_id names below 20 characters Pierre-Louis Bossart
2021-06-07 22:46 ` [PATCH 04/10] ASoC: Intel: glk_rt5682_max98357a: shrink platform_id " Pierre-Louis Bossart
2021-06-07 22:46 ` [PATCH 05/10] ASoC: Intel: kbl_da7219_max98357a: " Pierre-Louis Bossart
2021-06-07 22:46 ` [PATCH 06/10] ASoC: Intel: sof_da7219_max98373: " Pierre-Louis Bossart
2021-06-07 22:46 ` Pierre-Louis Bossart [this message]
2021-06-07 22:46 ` [PATCH 08/10] ASoC: Intel: soc-acpi: add ull suffix for SoundWire _ADR values Pierre-Louis Bossart
2021-06-07 22:46 ` [PATCH 09/10] ASoC: Intel: use MODULE_DEVICE_TABLE with platform_device_id tables Pierre-Louis Bossart
2021-06-07 22:46 ` [PATCH 10/10] ASoC: Intel: skl_hda_dsp_generic: Update Kconfig documentation Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210607224638.585486-8-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=guennadi.liakhovetski@linux.intel.com \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=paul.olaru@oss.nxp.com \
    --cc=rander.wang@intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.