All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhang Chen <chen.zhang@intel.com>
To: Jason Wang <jasowang@redhat.com>, qemu-dev <qemu-devel@nongnu.org>
Cc: Lukas Straub <lukasstraub2@web.de>,
	Li Zhijian <lizhijian@cn.fujitsu.com>,
	"Rao, Lei" <lei.rao@intel.com>,
	Li Zhijian <lizhijian@fujitsu.com>,
	Zhang Chen <chen.zhang@intel.com>,
	Zhang Chen <zhangckid@gmail.com>
Subject: [PATCH 7/7] Fixed calculation error of pkt->header_size in fill_pkt_tcp_info()
Date: Tue,  8 Jun 2021 16:23:31 +0800	[thread overview]
Message-ID: <20210608082331.1949117-8-chen.zhang@intel.com> (raw)
In-Reply-To: <20210608082331.1949117-1-chen.zhang@intel.com>

From: "Rao, Lei" <lei.rao@intel.com>

The data pointer has skipped vnet_hdr_len in the function of
parse_packet_early().So, we can not subtract vnet_hdr_len again
when calculating pkt->header_size in fill_pkt_tcp_info(). Otherwise,
it will cause network packet comparsion errors and greatly increase
the frequency of checkpoints.

Signed-off-by: Lei Rao <lei.rao@intel.com>
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Reviewed-by: Lukas Straub <lukasstraub2@web.de>
Tested-by: Lukas Straub <lukasstraub2@web.de>
---
 net/colo-compare.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/colo-compare.c b/net/colo-compare.c
index 5b538f4e0b..b100e7b51f 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -211,7 +211,7 @@ static void fill_pkt_tcp_info(void *data, uint32_t *max_ack)
     pkt->tcp_ack = ntohl(tcphd->th_ack);
     *max_ack = *max_ack > pkt->tcp_ack ? *max_ack : pkt->tcp_ack;
     pkt->header_size = pkt->transport_header - (uint8_t *)pkt->data
-                       + (tcphd->th_off << 2) - pkt->vnet_hdr_len;
+                       + (tcphd->th_off << 2);
     pkt->payload_size = pkt->size - pkt->header_size;
     pkt->seq_end = pkt->tcp_seq + pkt->payload_size;
     pkt->flags = tcphd->th_flags;
-- 
2.25.1



      parent reply	other threads:[~2021-06-08  8:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-08  8:23 [PATCH 0/7] COLO proxy patch Zhang Chen
2021-06-08  8:23 ` [PATCH 1/7] Remove some duplicate trace code Zhang Chen
2021-06-08  8:23 ` [PATCH 2/7] Fix the qemu crash when guest shutdown during checkpoint Zhang Chen
2021-06-08  8:23 ` [PATCH 3/7] Optimize the function of filter_send Zhang Chen
2021-06-08  8:23 ` [PATCH 4/7] Remove migrate_set_block_enabled in checkpoint Zhang Chen
2021-06-08  8:23 ` [PATCH 5/7] Add a function named packet_new_nocopy for COLO Zhang Chen
2021-06-08  8:23 ` [PATCH 6/7] Add the function of colo_compare_cleanup Zhang Chen
2021-06-08  8:23 ` Zhang Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210608082331.1949117-8-chen.zhang@intel.com \
    --to=chen.zhang@intel.com \
    --cc=jasowang@redhat.com \
    --cc=lei.rao@intel.com \
    --cc=lizhijian@cn.fujitsu.com \
    --cc=lizhijian@fujitsu.com \
    --cc=lukasstraub2@web.de \
    --cc=qemu-devel@nongnu.org \
    --cc=zhangckid@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.