All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maurizio Lombardi <mlombard@redhat.com>
To: martin.petersen@oracle.com
Cc: target-devel@vger.kernel.org
Subject: [PATCH] target: remove the auth_type field from iscsi_session
Date: Tue,  8 Jun 2021 18:40:47 +0200	[thread overview]
Message-ID: <20210608164047.128763-1-mlombard@redhat.com> (raw)

This field is not used anymore so we can remove it.

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
---
 drivers/target/iscsi/iscsi_target_nego.c | 5 -----
 include/target/iscsi/iscsi_target_core.h | 1 -
 2 files changed, 6 deletions(-)

diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c
index 151e2949bb75..36341ffaffbf 100644
--- a/drivers/target/iscsi/iscsi_target_nego.c
+++ b/drivers/target/iscsi/iscsi_target_nego.c
@@ -144,11 +144,6 @@ static u32 iscsi_handle_authentication(
 		auth = &iscsit_global->discovery_acl.node_auth;
 	}
 
-	if (strstr("CHAP", authtype))
-		strcpy(conn->sess->auth_type, "CHAP");
-	else
-		strcpy(conn->sess->auth_type, NONE);
-
 	if (strstr("None", authtype))
 		return 1;
 	else if (strstr("CHAP", authtype))
diff --git a/include/target/iscsi/iscsi_target_core.h b/include/target/iscsi/iscsi_target_core.h
index 1eccb2ac7d02..f0495515ca6a 100644
--- a/include/target/iscsi/iscsi_target_core.h
+++ b/include/target/iscsi/iscsi_target_core.h
@@ -647,7 +647,6 @@ struct iscsi_session {
 
 	/* LIO specific session ID */
 	u32			sid;
-	char			auth_type[8];
 	/* unique within the target */
 	int			session_index;
 	/* Used for session reference counting */
-- 
Maurizio Lombardi


             reply	other threads:[~2021-06-08 16:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-08 16:40 Maurizio Lombardi [this message]
2021-06-08 23:14 ` [PATCH] target: remove the auth_type field from iscsi_session Roman Bolshakov
2021-06-09 10:22   ` Maurizio Lombardi
2021-06-11 17:04     ` Roman Bolshakov
2021-06-11 18:41     ` michael.christie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210608164047.128763-1-mlombard@redhat.com \
    --to=mlombard@redhat.com \
    --cc=martin.petersen@oracle.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.