All of lore.kernel.org
 help / color / mirror / Atom feed
From: zuoqilin1@163.com
To: daniel@zonque.org, haojian.zhuang@gmail.com,
	robert.jarzmik@free.fr, perex@perex.cz, tiwai@suse.com
Cc: linux-arm-kernel@lists.infradead.org,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	zuoqilin <zuoqilin@yulong.com>
Subject: [PATCH] sound/arm: Remove unnecessary variables
Date: Thu, 10 Jun 2021 10:40:53 +0800	[thread overview]
Message-ID: <20210610024053.1217-1-zuoqilin1@163.com> (raw)

From: zuoqilin <zuoqilin@yulong.com>

There is no need to define the variable "ret" to receive.

Signed-off-by: zuoqilin <zuoqilin@yulong.com>
---
 sound/arm/pxa2xx-ac97.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sound/arm/pxa2xx-ac97.c b/sound/arm/pxa2xx-ac97.c
index 6322e639..a67e668 100644
--- a/sound/arm/pxa2xx-ac97.c
+++ b/sound/arm/pxa2xx-ac97.c
@@ -47,9 +47,7 @@ static unsigned short pxa2xx_ac97_legacy_read(struct snd_ac97 *ac97,
 static void pxa2xx_ac97_legacy_write(struct snd_ac97 *ac97,
 				     unsigned short reg, unsigned short val)
 {
-	int __always_unused ret;
-
-	ret = pxa2xx_ac97_write(ac97->num, reg, val);
+	pxa2xx_ac97_write(ac97->num, reg, val);
 }
 
 static const struct snd_ac97_bus_ops pxa2xx_ac97_ops = {
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: zuoqilin1@163.com
To: daniel@zonque.org, haojian.zhuang@gmail.com,
	robert.jarzmik@free.fr, perex@perex.cz, tiwai@suse.com
Cc: zuoqilin <zuoqilin@yulong.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH] sound/arm: Remove unnecessary variables
Date: Thu, 10 Jun 2021 10:40:53 +0800	[thread overview]
Message-ID: <20210610024053.1217-1-zuoqilin1@163.com> (raw)

From: zuoqilin <zuoqilin@yulong.com>

There is no need to define the variable "ret" to receive.

Signed-off-by: zuoqilin <zuoqilin@yulong.com>
---
 sound/arm/pxa2xx-ac97.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sound/arm/pxa2xx-ac97.c b/sound/arm/pxa2xx-ac97.c
index 6322e639..a67e668 100644
--- a/sound/arm/pxa2xx-ac97.c
+++ b/sound/arm/pxa2xx-ac97.c
@@ -47,9 +47,7 @@ static unsigned short pxa2xx_ac97_legacy_read(struct snd_ac97 *ac97,
 static void pxa2xx_ac97_legacy_write(struct snd_ac97 *ac97,
 				     unsigned short reg, unsigned short val)
 {
-	int __always_unused ret;
-
-	ret = pxa2xx_ac97_write(ac97->num, reg, val);
+	pxa2xx_ac97_write(ac97->num, reg, val);
 }
 
 static const struct snd_ac97_bus_ops pxa2xx_ac97_ops = {
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: zuoqilin1@163.com
To: daniel@zonque.org, haojian.zhuang@gmail.com,
	robert.jarzmik@free.fr, perex@perex.cz, tiwai@suse.com
Cc: linux-arm-kernel@lists.infradead.org,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	zuoqilin <zuoqilin@yulong.com>
Subject: [PATCH] sound/arm: Remove unnecessary variables
Date: Thu, 10 Jun 2021 10:40:53 +0800	[thread overview]
Message-ID: <20210610024053.1217-1-zuoqilin1@163.com> (raw)

From: zuoqilin <zuoqilin@yulong.com>

There is no need to define the variable "ret" to receive.

Signed-off-by: zuoqilin <zuoqilin@yulong.com>
---
 sound/arm/pxa2xx-ac97.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sound/arm/pxa2xx-ac97.c b/sound/arm/pxa2xx-ac97.c
index 6322e639..a67e668 100644
--- a/sound/arm/pxa2xx-ac97.c
+++ b/sound/arm/pxa2xx-ac97.c
@@ -47,9 +47,7 @@ static unsigned short pxa2xx_ac97_legacy_read(struct snd_ac97 *ac97,
 static void pxa2xx_ac97_legacy_write(struct snd_ac97 *ac97,
 				     unsigned short reg, unsigned short val)
 {
-	int __always_unused ret;
-
-	ret = pxa2xx_ac97_write(ac97->num, reg, val);
+	pxa2xx_ac97_write(ac97->num, reg, val);
 }
 
 static const struct snd_ac97_bus_ops pxa2xx_ac97_ops = {
-- 
1.9.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2021-06-10  2:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-10  2:40 zuoqilin1 [this message]
2021-06-10  2:40 ` [PATCH] sound/arm: Remove unnecessary variables zuoqilin1
2021-06-10  2:40 ` zuoqilin1
2021-06-10  7:51 ` Takashi Iwai
2021-06-10  7:51   ` Takashi Iwai
2021-06-10  7:51   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210610024053.1217-1-zuoqilin1@163.com \
    --to=zuoqilin1@163.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=daniel@zonque.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robert.jarzmik@free.fr \
    --cc=tiwai@suse.com \
    --cc=zuoqilin@yulong.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.