From: Russ Weight <russell.h.weight@intel.com>
To: mdf@kernel.org, linux-fpga@vger.kernel.org
Cc: trix@redhat.com, lgoncalv@redhat.com, yilun.xu@intel.com,
hao.wu@intel.com, matthew.gerlach@intel.com,
richard.gong@intel.com, Russ Weight <russell.h.weight@intel.com>
Subject: [PATCH v5 0/3] fpga: Use standard class dev_release function
Date: Wed, 16 Jun 2021 15:57:37 -0700 [thread overview]
Message-ID: <20210616225740.399486-1-russell.h.weight@intel.com> (raw)
The FPGA framework has a convention of using managed resource
functions to allow parent drivers to manage the data structures
allocated by the class drivers. They use an empty *_dev_release()
function to satisfy the class driver.
This is inconsistent with linux driver model.
These changes remove the managed resource functions and populate
the class dev_release callback functions. They also merge the
create and register functions into a single register function for
each of the fpga-mgr, fpga-region, and fpga-bridge class drivers.
For more context, refer to this email thread:
https://marc.info/?l=linux-fpga&m=162127412218557&w=2
I turned on the configs assocated with each of the modified files,
but I must have been missing some dependencies, because not all
of them compiled. I did a run-time test specifically with the
dfl-fme infrastructure. This would have exercised the region,
bridge, and fpga-mgr frameworks.
Changelog v4 -> v5:
- Rebased on top of recently accepted patches.
- Removed compat_id from the fpga_mgr_register() parameter list
and added it to the fpga_manager_ops structure. This also required
dynamically allocating the dfl-fme-ops structure in order to add
the appropriate compat_id.
- Created the fpga_region_ops data structure which is optionally passed
to fpga_region_register(). compat_id, the get_bridges() pointer, and
the priv pointer are included in the fpga_region_ops structure.
Changelog v3 -> v4:
- Added the compat_id parameter to fpga_mgr_register() and
devm_fpga_mgr_register() to ensure that the compat_id is set before
the device_register() call.
- Added the compat_id parameter to fpga_region_register() to ensure
that the compat_id is set before the device_register() call.
- Modified the dfl_fpga_feature_devs_enumerate() function to restore
the fpga_region_register() call to the correct location.
Changelog v2 -> v3:
- Cleaned up comment headers for fpga_mgr_register(), fpga_bridge_register(),
and fpga_region_register().
- Fixed error return on ida_simple_get() failure for fpga_mgr_register(),
fpga_bridge_register(), and fpga_region_register().
- Fixed error return value for fpga_bridge_register(): ERR_PTR(ret) instead
of NULL.
Changelog v1 -> v2:
- Restored devm_fpga_mgr_register() functionality to the fpga-mgr
class driver, adapted for the combined create/register functionality.
- All previous callers of devm_fpga_mgr_register() will continue to call
devm_fpga_mgr_register().
- replaced unnecessary ternary operators in return statements with
standard if conditions.
Russ Weight (3):
fpga: mgr: Use standard dev_release for class driver
fpga: bridge: Use standard dev_release for class driver
fpga: region: Use standard dev_release for class driver
drivers/fpga/altera-cvp.c | 12 +-
drivers/fpga/altera-fpga2sdram.c | 12 +-
drivers/fpga/altera-freeze-bridge.c | 10 +-
drivers/fpga/altera-hps2fpga.c | 12 +-
drivers/fpga/altera-pr-ip-core.c | 8 +-
drivers/fpga/altera-ps-spi.c | 10 +-
drivers/fpga/dfl-fme-br.c | 10 +-
drivers/fpga/dfl-fme-mgr.c | 52 +++++----
drivers/fpga/dfl-fme-pr.c | 2 +-
drivers/fpga/dfl-fme-region.c | 32 ++++--
drivers/fpga/dfl.c | 12 +-
drivers/fpga/fpga-bridge.c | 116 ++++----------------
drivers/fpga/fpga-mgr.c | 163 +++++++---------------------
drivers/fpga/fpga-region.c | 119 +++++---------------
drivers/fpga/ice40-spi.c | 10 +-
drivers/fpga/machxo2-spi.c | 10 +-
drivers/fpga/of-fpga-region.c | 14 +--
drivers/fpga/socfpga-a10.c | 16 +--
drivers/fpga/socfpga.c | 10 +-
drivers/fpga/stratix10-soc.c | 16 +--
drivers/fpga/ts73xx-fpga.c | 10 +-
drivers/fpga/xilinx-pr-decoupler.c | 17 +--
drivers/fpga/xilinx-spi.c | 12 +-
drivers/fpga/zynq-fpga.c | 16 +--
drivers/fpga/zynqmp-fpga.c | 10 +-
include/linux/fpga/fpga-bridge.h | 12 +-
include/linux/fpga/fpga-mgr.h | 43 ++++----
include/linux/fpga/fpga-region.h | 38 ++++---
28 files changed, 286 insertions(+), 518 deletions(-)
--
2.25.1
next reply other threads:[~2021-06-16 22:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 22:57 Russ Weight [this message]
2021-06-16 22:57 ` [PATCH v5 1/3] fpga: mgr: Use standard dev_release for class driver Russ Weight
2021-06-18 15:45 ` Xu Yilun
2021-06-18 16:03 ` Russ Weight
2021-06-18 17:58 ` Russ Weight
2021-06-18 20:39 ` Tom Rix
2021-06-18 22:01 ` Moritz Fischer
2021-06-21 9:48 ` Wu, Hao
2021-06-18 22:31 ` Russ Weight
2021-06-21 6:39 ` Xu Yilun
2021-06-21 6:47 ` Wu, Hao
2021-06-21 7:36 ` Xu Yilun
2021-06-16 22:57 ` [PATCH v5 2/3] fpga: bridge: " Russ Weight
2021-06-18 15:52 ` Xu Yilun
2021-06-18 16:05 ` Russ Weight
2021-06-21 7:38 ` Xu Yilun
2021-06-16 22:57 ` [PATCH v5 3/3] fpga: region: " Russ Weight
2021-06-18 15:54 ` Xu Yilun
2021-06-18 16:06 ` Russ Weight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210616225740.399486-1-russell.h.weight@intel.com \
--to=russell.h.weight@intel.com \
--cc=hao.wu@intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-fpga@vger.kernel.org \
--cc=matthew.gerlach@intel.com \
--cc=mdf@kernel.org \
--cc=richard.gong@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.