All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anand Moon <linux.amoon@gmail.com>
To: --to=linux-phy@lists.infradead.org,
	--to=linux-arm-kernel@lists.infradead.org,
	--to=linux-amlogic@lists.infradead.org,
	--to=linux-kernel@vger.kernel.org
Cc: Anand Moon <linux.amoon@gmail.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [RFCv1 0/8] Meson-8b and Meson-gxbb USB phy code re-structure
Date: Thu, 17 Jun 2021 19:41:35 +0000	[thread overview]
Message-ID: <20210617194154.2397-1-linux.amoon@gmail.com> (raw)

On Odroid C1+ and Odroid C2 USB feature is broken
this code changes are just re-structure the code so that
proper callback function execute in proper order.

Code changes losely based on phy-meson-gxl-usb2.c

Initially if we connect USB HDD at initial boot it get detected.
but after that usb hotplug of USB HDD is broken.
I did not observe and USB debug events messages to trace the root cause.

Another issue I observed is increase of USB interrupts event
even if there is not much activity on USB ports.
I tried some clk changes but it did not workout for me.

$ cat /proc/interrupts | grep usb
 45:          0          0          0          0     GICv2  62 Level     c9000000.usb, dwc2_hsotg:usb1
 46:   17488032          0          0          0     GICv2  63 Level     c9100000.usb, dwc2_hsotg:usb2

Thanks
-Anand

Anand Moon (8):
  phy: amlogic: meson8b-usb2: Use clock bulk to get clocks for phy
  phy: amlogic: meson8b-usb2: Use phy init callback function
  phy: amlogic: meson8b-usb2: Use phy exit callback function
  phy: amlogic: meson8b-usb2: Use phy set_mode callback function
  phy: amlogic: meson8b-usb2: Reorder phy poweroff callback function
  phy: amlogic: meson8b-usb2: Use phy reset callback function
  phy: amlogic: meson8b-usb2: Power off the PHY by putting it into reset
    mode.
  phy: amlogic: meson8b-usb2: don't log an error on -EPROBE_DEFER

 drivers/phy/amlogic/phy-meson8b-usb2.c | 159 +++++++++++++++++--------
 1 file changed, 109 insertions(+), 50 deletions(-)

-- 
2.31.1


WARNING: multiple messages have this Message-ID (diff)
From: Anand Moon <linux.amoon@gmail.com>
To: --to=linux-phy@lists.infradead.org,
	--to=linux-arm-kernel@lists.infradead.org,
	--to=linux-amlogic@lists.infradead.org,
	--to=linux-kernel@vger.kernel.org
Cc: Anand Moon <linux.amoon@gmail.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [RFCv1 0/8] Meson-8b and Meson-gxbb USB phy code re-structure
Date: Thu, 17 Jun 2021 19:41:35 +0000	[thread overview]
Message-ID: <20210617194154.2397-1-linux.amoon@gmail.com> (raw)

On Odroid C1+ and Odroid C2 USB feature is broken
this code changes are just re-structure the code so that
proper callback function execute in proper order.

Code changes losely based on phy-meson-gxl-usb2.c

Initially if we connect USB HDD at initial boot it get detected.
but after that usb hotplug of USB HDD is broken.
I did not observe and USB debug events messages to trace the root cause.

Another issue I observed is increase of USB interrupts event
even if there is not much activity on USB ports.
I tried some clk changes but it did not workout for me.

$ cat /proc/interrupts | grep usb
 45:          0          0          0          0     GICv2  62 Level     c9000000.usb, dwc2_hsotg:usb1
 46:   17488032          0          0          0     GICv2  63 Level     c9100000.usb, dwc2_hsotg:usb2

Thanks
-Anand

Anand Moon (8):
  phy: amlogic: meson8b-usb2: Use clock bulk to get clocks for phy
  phy: amlogic: meson8b-usb2: Use phy init callback function
  phy: amlogic: meson8b-usb2: Use phy exit callback function
  phy: amlogic: meson8b-usb2: Use phy set_mode callback function
  phy: amlogic: meson8b-usb2: Reorder phy poweroff callback function
  phy: amlogic: meson8b-usb2: Use phy reset callback function
  phy: amlogic: meson8b-usb2: Power off the PHY by putting it into reset
    mode.
  phy: amlogic: meson8b-usb2: don't log an error on -EPROBE_DEFER

 drivers/phy/amlogic/phy-meson8b-usb2.c | 159 +++++++++++++++++--------
 1 file changed, 109 insertions(+), 50 deletions(-)

-- 
2.31.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Anand Moon <linux.amoon@gmail.com>
To: --to=linux-phy@lists.infradead.org,
	--to=linux-arm-kernel@lists.infradead.org,
	--to=linux-amlogic@lists.infradead.org,
	--to=linux-kernel@vger.kernel.org
Cc: Anand Moon <linux.amoon@gmail.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [RFCv1 0/8] Meson-8b and Meson-gxbb USB phy code re-structure
Date: Thu, 17 Jun 2021 19:41:35 +0000	[thread overview]
Message-ID: <20210617194154.2397-1-linux.amoon@gmail.com> (raw)

On Odroid C1+ and Odroid C2 USB feature is broken
this code changes are just re-structure the code so that
proper callback function execute in proper order.

Code changes losely based on phy-meson-gxl-usb2.c

Initially if we connect USB HDD at initial boot it get detected.
but after that usb hotplug of USB HDD is broken.
I did not observe and USB debug events messages to trace the root cause.

Another issue I observed is increase of USB interrupts event
even if there is not much activity on USB ports.
I tried some clk changes but it did not workout for me.

$ cat /proc/interrupts | grep usb
 45:          0          0          0          0     GICv2  62 Level     c9000000.usb, dwc2_hsotg:usb1
 46:   17488032          0          0          0     GICv2  63 Level     c9100000.usb, dwc2_hsotg:usb2

Thanks
-Anand

Anand Moon (8):
  phy: amlogic: meson8b-usb2: Use clock bulk to get clocks for phy
  phy: amlogic: meson8b-usb2: Use phy init callback function
  phy: amlogic: meson8b-usb2: Use phy exit callback function
  phy: amlogic: meson8b-usb2: Use phy set_mode callback function
  phy: amlogic: meson8b-usb2: Reorder phy poweroff callback function
  phy: amlogic: meson8b-usb2: Use phy reset callback function
  phy: amlogic: meson8b-usb2: Power off the PHY by putting it into reset
    mode.
  phy: amlogic: meson8b-usb2: don't log an error on -EPROBE_DEFER

 drivers/phy/amlogic/phy-meson8b-usb2.c | 159 +++++++++++++++++--------
 1 file changed, 109 insertions(+), 50 deletions(-)

-- 
2.31.1


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Anand Moon <linux.amoon@gmail.com>
To: --to=linux-phy@lists.infradead.org,
	--to=linux-arm-kernel@lists.infradead.org,
	--to=linux-amlogic@lists.infradead.org,
	--to=linux-kernel@vger.kernel.org
Cc: Anand Moon <linux.amoon@gmail.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [RFCv1 0/8] Meson-8b and Meson-gxbb USB phy code re-structure
Date: Thu, 17 Jun 2021 19:41:35 +0000	[thread overview]
Message-ID: <20210617194154.2397-1-linux.amoon@gmail.com> (raw)

On Odroid C1+ and Odroid C2 USB feature is broken
this code changes are just re-structure the code so that
proper callback function execute in proper order.

Code changes losely based on phy-meson-gxl-usb2.c

Initially if we connect USB HDD at initial boot it get detected.
but after that usb hotplug of USB HDD is broken.
I did not observe and USB debug events messages to trace the root cause.

Another issue I observed is increase of USB interrupts event
even if there is not much activity on USB ports.
I tried some clk changes but it did not workout for me.

$ cat /proc/interrupts | grep usb
 45:          0          0          0          0     GICv2  62 Level     c9000000.usb, dwc2_hsotg:usb1
 46:   17488032          0          0          0     GICv2  63 Level     c9100000.usb, dwc2_hsotg:usb2

Thanks
-Anand

Anand Moon (8):
  phy: amlogic: meson8b-usb2: Use clock bulk to get clocks for phy
  phy: amlogic: meson8b-usb2: Use phy init callback function
  phy: amlogic: meson8b-usb2: Use phy exit callback function
  phy: amlogic: meson8b-usb2: Use phy set_mode callback function
  phy: amlogic: meson8b-usb2: Reorder phy poweroff callback function
  phy: amlogic: meson8b-usb2: Use phy reset callback function
  phy: amlogic: meson8b-usb2: Power off the PHY by putting it into reset
    mode.
  phy: amlogic: meson8b-usb2: don't log an error on -EPROBE_DEFER

 drivers/phy/amlogic/phy-meson8b-usb2.c | 159 +++++++++++++++++--------
 1 file changed, 109 insertions(+), 50 deletions(-)

-- 
2.31.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

             reply	other threads:[~2021-06-17 19:42 UTC|newest]

Thread overview: 149+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17 19:41 Anand Moon [this message]
2021-06-17 19:41 ` [RFCv1 0/8] Meson-8b and Meson-gxbb USB phy code re-structure Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` Anand Moon
2021-06-17 19:41 ` [RFCv1 1/8] phy: amlogic: meson8b-usb2: Use clock bulk to get clocks for phy Anand Moon
2021-06-17 19:41   ` Anand Moon
2021-06-17 19:41   ` Anand Moon
2021-06-17 19:41   ` Anand Moon
2021-06-17 22:33   ` Martin Blumenstingl
2021-06-17 22:33     ` Martin Blumenstingl
2021-06-17 22:33     ` Martin Blumenstingl
2021-06-17 22:33     ` Martin Blumenstingl
2021-06-18 15:32     ` Anand Moon
2021-06-18 15:32       ` Anand Moon
2021-06-18 15:32       ` Anand Moon
2021-06-18 15:32       ` Anand Moon
2021-06-17 19:41 ` [RFCv1 2/8] phy: amlogic: meson8b-usb2: Use phy init callback function Anand Moon
2021-06-17 19:41   ` Anand Moon
2021-06-17 19:41   ` Anand Moon
2021-06-17 19:41   ` Anand Moon
2021-06-18 12:26   ` Martin Blumenstingl
2021-06-18 12:26     ` Martin Blumenstingl
2021-06-18 12:26     ` Martin Blumenstingl
2021-06-18 12:26     ` Martin Blumenstingl
2021-06-18 13:17     ` Anand Moon
2021-06-18 13:17       ` Anand Moon
2021-06-18 13:17       ` Anand Moon
2021-06-18 13:17       ` Anand Moon
2021-06-17 19:41 ` [RFCv1 3/8] phy: amlogic: meson8b-usb2: Use phy exit " Anand Moon
2021-06-17 19:41   ` Anand Moon
2021-06-17 19:41   ` Anand Moon
2021-06-17 19:41   ` Anand Moon
2021-06-17 19:41 ` [RFCv1 4/8] phy: amlogic: meson8b-usb2: Use phy set_mode " Anand Moon
2021-06-17 19:41   ` Anand Moon
2021-06-17 19:41   ` Anand Moon
2021-06-17 19:41   ` Anand Moon
2021-06-17 22:16   ` Martin Blumenstingl
2021-06-17 22:16     ` Martin Blumenstingl
2021-06-17 22:16     ` Martin Blumenstingl
2021-06-17 22:16     ` Martin Blumenstingl
2021-06-18 13:19     ` Anand Moon
2021-06-18 13:19       ` Anand Moon
2021-06-18 13:19       ` Anand Moon
2021-06-18 13:19       ` Anand Moon
2021-06-18 20:01       ` Martin Blumenstingl
2021-06-18 20:01         ` Martin Blumenstingl
2021-06-18 20:01         ` Martin Blumenstingl
2021-06-18 20:01         ` Martin Blumenstingl
2021-06-21  7:20         ` Anand Moon
2021-06-21  7:20           ` Anand Moon
2021-06-21  7:20           ` Anand Moon
2021-06-21  7:20           ` Anand Moon
2021-06-22 20:27           ` Martin Blumenstingl
2021-06-22 20:27             ` Martin Blumenstingl
2021-06-22 20:27             ` Martin Blumenstingl
2021-06-22 20:27             ` Martin Blumenstingl
2021-06-17 19:41 ` [RFCv1 5/8] phy: amlogic: meson8b-usb2: Reorder phy poweroff " Anand Moon
2021-06-17 19:41   ` Anand Moon
2021-06-17 19:41   ` Anand Moon
2021-06-17 19:41   ` Anand Moon
2021-06-17 22:16   ` Martin Blumenstingl
2021-06-17 22:16     ` Martin Blumenstingl
2021-06-17 22:16     ` Martin Blumenstingl
2021-06-17 22:16     ` Martin Blumenstingl
2021-06-18 15:33     ` Anand Moon
2021-06-18 15:33       ` Anand Moon
2021-06-18 15:33       ` Anand Moon
2021-06-18 15:33       ` Anand Moon
2021-06-18  0:34   ` kernel test robot
2021-06-17 19:41 ` [RFCv1 6/8] phy: amlogic: meson8b-usb2: Use phy reset " Anand Moon
2021-06-17 19:41   ` Anand Moon
2021-06-17 19:41   ` Anand Moon
2021-06-17 19:41   ` Anand Moon
2021-06-17 22:24   ` Martin Blumenstingl
2021-06-17 22:24     ` Martin Blumenstingl
2021-06-17 22:24     ` Martin Blumenstingl
2021-06-17 22:24     ` Martin Blumenstingl
2021-06-18 15:33     ` Anand Moon
2021-06-18 15:33       ` Anand Moon
2021-06-18 15:33       ` Anand Moon
2021-06-18 15:33       ` Anand Moon
2021-06-18 20:06       ` Martin Blumenstingl
2021-06-18 20:06         ` Martin Blumenstingl
2021-06-18 20:06         ` Martin Blumenstingl
2021-06-18 20:06         ` Martin Blumenstingl
2021-06-21  7:15         ` Anand Moon
2021-06-21  7:15           ` Anand Moon
2021-06-21  7:15           ` Anand Moon
2021-06-21  7:15           ` Anand Moon
2021-06-22 20:11           ` Martin Blumenstingl
2021-06-22 20:11             ` Martin Blumenstingl
2021-06-22 20:11             ` Martin Blumenstingl
2021-06-22 20:11             ` Martin Blumenstingl
2021-06-24 14:54             ` Anand Moon
2021-06-24 14:54               ` Anand Moon
2021-06-24 14:54               ` Anand Moon
2021-06-24 14:54               ` Anand Moon
2021-06-27 20:07               ` Anand Moon
2021-06-27 20:07                 ` Anand Moon
2021-06-27 20:07                 ` Anand Moon
2021-06-27 20:07                 ` Anand Moon
2021-06-27 20:25                 ` Martin Blumenstingl
2021-06-27 20:25                   ` Martin Blumenstingl
2021-06-27 20:25                   ` Martin Blumenstingl
2021-06-27 20:25                   ` Martin Blumenstingl
2021-07-02 19:13                   ` Anand Moon
2021-07-02 19:13                     ` Anand Moon
2021-07-02 19:13                     ` Anand Moon
2021-07-02 19:13                     ` Anand Moon
2021-06-17 19:41 ` [RFCv1 7/8] phy: amlogic: meson8b-usb2: Power off the PHY by putting it into reset mode Anand Moon
2021-06-17 19:41   ` Anand Moon
2021-06-17 19:41   ` Anand Moon
2021-06-17 19:41   ` Anand Moon
2021-06-17 22:37   ` Martin Blumenstingl
2021-06-17 22:37     ` Martin Blumenstingl
2021-06-17 22:37     ` Martin Blumenstingl
2021-06-17 22:37     ` Martin Blumenstingl
2021-06-21  7:15     ` Anand Moon
2021-06-21  7:15       ` Anand Moon
2021-06-21  7:15       ` Anand Moon
2021-06-21  7:15       ` Anand Moon
2021-06-22 20:00       ` Martin Blumenstingl
2021-06-22 20:00         ` Martin Blumenstingl
2021-06-22 20:00         ` Martin Blumenstingl
2021-06-22 20:00         ` Martin Blumenstingl
2021-06-17 19:41 ` [RFCv1 8/8] phy: amlogic: meson8b-usb2: don't log an error on -EPROBE_DEFER Anand Moon
2021-06-17 19:41   ` Anand Moon
2021-06-17 19:41   ` Anand Moon
2021-06-17 19:41   ` Anand Moon
2021-06-17 22:26   ` Martin Blumenstingl
2021-06-17 22:26     ` Martin Blumenstingl
2021-06-17 22:26     ` Martin Blumenstingl
2021-06-17 22:26     ` Martin Blumenstingl
2021-06-17 22:11 ` [RFCv1 0/8] Meson-8b and Meson-gxbb USB phy code re-structure Martin Blumenstingl
2021-06-17 22:11   ` Martin Blumenstingl
2021-06-17 22:11   ` Martin Blumenstingl
2021-06-17 22:11   ` Martin Blumenstingl
2021-06-18 13:20   ` Anand Moon
2021-06-18 13:20     ` Anand Moon
2021-06-18 13:20     ` Anand Moon
2021-06-18 13:20     ` Anand Moon
2021-06-18 20:16     ` Martin Blumenstingl
2021-06-18 20:16       ` Martin Blumenstingl
2021-06-18 20:16       ` Martin Blumenstingl
2021-06-18 20:16       ` Martin Blumenstingl
2021-06-21  7:21       ` Anand Moon
2021-06-21  7:21         ` Anand Moon
2021-06-21  7:21         ` Anand Moon
2021-06-21  7:21         ` Anand Moon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210617194154.2397-1-linux.amoon@gmail.com \
    --to=linux.amoon@gmail.com \
    --cc=--to=linux-amlogic@lists.infradead.org \
    --cc=--to=linux-arm-kernel@lists.infradead.org \
    --cc=--to=linux-kernel@vger.kernel.org \
    --cc=--to=linux-phy@lists.infradead.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=kishon@ti.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=narmstrong@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.