From: Matt Roper <matthew.d.roper@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [CI 0/3] Explicity steer l3bank multicast reads when necessary
Date: Thu, 17 Jun 2021 14:14:22 -0700 [thread overview]
Message-ID: <20210617211425.1943662-1-matthew.d.roper@intel.com> (raw)
We've recently learned that when steering reads of multicast registers
that use 'subslice' replication, it's not only important to steer to a
subslice that isn't fused off, but also to steer to the lowest-numbered
subslice. This is because when Render Power Gating is enabled, grabbing
forcewake will only cause the hardware to power up a single subslice
(referred to as the "minconfig") until/unless a real workload is being
run on the EUs. If we try to read back a value from a register instance
other than the minconfig subslice, the read operation will either return
0 or random garbage.
Unfortunately this extra requirement to steer to the minconfig means
that the steering target we use for subslice-replicated registers may
not select a valid instance for l3bank-replicated registers. In cases
where the two types of multicast registers do not have compatible
steering targets, we'll initialize the steering control register to the
proper subslice target at driver load, and then explicitly re-steer
individual reads of l3bank registers as they occur at runtime.
This series sets up an infrastructure to handle explicit resteering of
multiple multicast register types, and then applies it to l3bank
registers. Our next upcoming platform (which we'll probably start
upstreaming soon) will bring several more types of multicast registers,
each with their own steering criteria, so the infrastructure here is
partially in preparation for those extra multicast types that will be
arriving soon.
v2:
- Use {} as table terminator and check for end==0 instead of 0xFFFFFF
on loop iteration. (Rodrigo)
- Use gt->uncore instead of gt->i915->uncore. (Tvrtko)
- Now that wa_list_verify() uses _fw accessors we need to explicitly
grab forcewake.
v2.1:
- Rebase
v3:
- The L3BANK fuse value is a disable mask rather than an enable mask.
We need to invert it before applying ffs() to select a valid
instance.
v4:
- The selected L3BANK ID goes in the subslice field of the steering
register, not the slice field.
v4.1:
- Rebase
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Daniele Ceraolo Spurio (1):
drm/i915: extract steered reg access to common function
Matt Roper (2):
drm/i915: Add GT support for multiple types of multicast steering
drm/i915: Add support for explicit L3BANK steering
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 41 +-----
drivers/gpu/drm/i915/gt/intel_gt.c | 102 +++++++++++++++
drivers/gpu/drm/i915/gt/intel_gt.h | 8 ++
drivers/gpu/drm/i915/gt/intel_gt_types.h | 26 ++++
drivers/gpu/drm/i915/gt/intel_workarounds.c | 123 ++++++++----------
.../gpu/drm/i915/gt/selftest_workarounds.c | 2 +-
drivers/gpu/drm/i915/intel_uncore.c | 55 ++++++++
drivers/gpu/drm/i915/intel_uncore.h | 6 +
8 files changed, 251 insertions(+), 112 deletions(-)
--
2.25.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2021-06-17 21:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 21:14 Matt Roper [this message]
2021-06-17 21:14 ` [Intel-gfx] [CI 1/3] drm/i915: extract steered reg access to common function Matt Roper
2021-06-17 21:14 ` [Intel-gfx] [CI 2/3] drm/i915: Add GT support for multiple types of multicast steering Matt Roper
2021-06-17 21:14 ` [Intel-gfx] [CI 3/3] drm/i915: Add support for explicit L3BANK steering Matt Roper
2021-06-17 22:14 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Explicity steer l3bank multicast reads when necessary (rev7) Patchwork
2021-06-17 22:44 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-06-18 0:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-06-18 2:20 ` Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210617211425.1943662-1-matthew.d.roper@intel.com \
--to=matthew.d.roper@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.