All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Marc Zyngier <maz@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Tsahee Zidenberg <tsahee@annapurnalabs.com>,
	Antoine Tenart <atenart@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: [PATCH v1 7/7] irqchip/mvebu-odmi: Switch to bitmap_zalloc()
Date: Fri, 18 Jun 2021 18:16:57 +0300	[thread overview]
Message-ID: <20210618151657.65305-7-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20210618151657.65305-1-andriy.shevchenko@linux.intel.com>

Switch to bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/irqchip/irq-mvebu-odmi.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/irqchip/irq-mvebu-odmi.c b/drivers/irqchip/irq-mvebu-odmi.c
index b4d367868dbb..dc4145abdd6f 100644
--- a/drivers/irqchip/irq-mvebu-odmi.c
+++ b/drivers/irqchip/irq-mvebu-odmi.c
@@ -171,8 +171,7 @@ static int __init mvebu_odmi_init(struct device_node *node,
 	if (!odmis)
 		return -ENOMEM;
 
-	odmis_bm = kcalloc(BITS_TO_LONGS(odmis_count * NODMIS_PER_FRAME),
-			   sizeof(long), GFP_KERNEL);
+	odmis_bm = bitmap_zalloc(odmis_count * NODMIS_PER_FRAME, GFP_KERNEL);
 	if (!odmis_bm) {
 		ret = -ENOMEM;
 		goto err_alloc;
@@ -227,7 +226,7 @@ static int __init mvebu_odmi_init(struct device_node *node,
 		if (odmi->base && !IS_ERR(odmi->base))
 			iounmap(odmis[i].base);
 	}
-	kfree(odmis_bm);
+	bitmap_free(odmis_bm);
 err_alloc:
 	kfree(odmis);
 	return ret;
-- 
2.30.2


WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Marc Zyngier <maz@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Tsahee Zidenberg <tsahee@annapurnalabs.com>,
	Antoine Tenart <atenart@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: [PATCH v1 7/7] irqchip/mvebu-odmi: Switch to bitmap_zalloc()
Date: Fri, 18 Jun 2021 18:16:57 +0300	[thread overview]
Message-ID: <20210618151657.65305-7-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20210618151657.65305-1-andriy.shevchenko@linux.intel.com>

Switch to bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/irqchip/irq-mvebu-odmi.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/irqchip/irq-mvebu-odmi.c b/drivers/irqchip/irq-mvebu-odmi.c
index b4d367868dbb..dc4145abdd6f 100644
--- a/drivers/irqchip/irq-mvebu-odmi.c
+++ b/drivers/irqchip/irq-mvebu-odmi.c
@@ -171,8 +171,7 @@ static int __init mvebu_odmi_init(struct device_node *node,
 	if (!odmis)
 		return -ENOMEM;
 
-	odmis_bm = kcalloc(BITS_TO_LONGS(odmis_count * NODMIS_PER_FRAME),
-			   sizeof(long), GFP_KERNEL);
+	odmis_bm = bitmap_zalloc(odmis_count * NODMIS_PER_FRAME, GFP_KERNEL);
 	if (!odmis_bm) {
 		ret = -ENOMEM;
 		goto err_alloc;
@@ -227,7 +226,7 @@ static int __init mvebu_odmi_init(struct device_node *node,
 		if (odmi->base && !IS_ERR(odmi->base))
 			iounmap(odmis[i].base);
 	}
-	kfree(odmis_bm);
+	bitmap_free(odmis_bm);
 err_alloc:
 	kfree(odmis);
 	return ret;
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-06-18 15:17 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 15:16 [PATCH v1 1/7] irqchip: Switch to bitmap_zalloc() Andy Shevchenko
2021-06-18 15:16 ` Andy Shevchenko
2021-06-18 15:16 ` [PATCH v1 2/7] irqchip/alpine-msi: " Andy Shevchenko
2021-06-18 15:16   ` Andy Shevchenko
2021-07-26 17:12   ` [irqchip: irq/irqchip-next] " irqchip-bot for Andy Shevchenko
2021-06-18 15:16 ` [PATCH v1 3/7] irqchip/gic-v2m: " Andy Shevchenko
2021-06-18 15:16   ` Andy Shevchenko
2021-07-26 17:12   ` [irqchip: irq/irqchip-next] " irqchip-bot for Andy Shevchenko
2021-06-18 15:16 ` [PATCH v1 4/7] irqchip/gic-v3: " Andy Shevchenko
2021-06-18 15:16   ` Andy Shevchenko
2021-07-26 17:05   ` Marc Zyngier
2021-07-26 17:05     ` Marc Zyngier
2021-07-26 17:12   ` [irqchip: irq/irqchip-next] " irqchip-bot for Andy Shevchenko
2021-06-18 15:16 ` [PATCH v1 5/7] irqchip/ls-scfg-msi: Switch to devm_bitmap_zalloc() Andy Shevchenko
2021-06-18 15:16   ` Andy Shevchenko
2021-07-26 17:12   ` [irqchip: irq/irqchip-next] " irqchip-bot for Andy Shevchenko
2021-06-18 15:16 ` [PATCH v1 6/7] irqchip/mvebu-gicp: " Andy Shevchenko
2021-06-18 15:16   ` Andy Shevchenko
2021-07-26 17:12   ` [irqchip: irq/irqchip-next] " irqchip-bot for Andy Shevchenko
2021-06-18 15:16 ` Andy Shevchenko [this message]
2021-06-18 15:16   ` [PATCH v1 7/7] irqchip/mvebu-odmi: Switch to bitmap_zalloc() Andy Shevchenko
2021-07-26 17:12   ` [irqchip: irq/irqchip-next] " irqchip-bot for Andy Shevchenko
2021-07-26 17:12 ` [irqchip: irq/irqchip-next] irqchip/partitions: " irqchip-bot for Andy Shevchenko
2021-07-26 17:12 ` [PATCH v1 1/7] irqchip: " Marc Zyngier
2021-07-26 17:12   ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210618151657.65305-7-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=andrew@lunn.ch \
    --cc=atenart@kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=tsahee@annapurnalabs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.