From: ice_yangxiao@163.com
To: linux-rdma@vger.kernel.org
Cc: leon@kernel.org, zyjzyj2000@gmail.com, Xiao Yang <yangx.jy@fujitsu.com>
Subject: [PATCH RESEND] RDMA/rxe: Don't overwrite errno from ib_umem_get()
Date: Mon, 21 Jun 2021 15:14:56 +0800 [thread overview]
Message-ID: <20210621071456.4259-1-ice_yangxiao@163.com> (raw)
From: Xiao Yang <yangx.jy@fujitsu.com>
rxe_mr_init_user() always returns the fixed -EINVAL when ib_umem_get()
fails so it's hard for user to know which actual error happens in
ib_umem_get(). For example, ib_umem_get() will return -EOPNOTSUPP
when trying to pin pages on a DAX file.
Return actual error as mlx4/mlx5 does.
Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
---
drivers/infiniband/sw/rxe/rxe_mr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c
index 9f63947bab12..fe2b7d223183 100644
--- a/drivers/infiniband/sw/rxe/rxe_mr.c
+++ b/drivers/infiniband/sw/rxe/rxe_mr.c
@@ -135,7 +135,7 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova,
if (IS_ERR(umem)) {
pr_warn("err %d from rxe_umem_get\n",
(int)PTR_ERR(umem));
- err = -EINVAL;
+ err = PTR_ERR(umem);
goto err1;
}
--
2.26.2
next reply other threads:[~2021-06-21 7:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 7:14 ice_yangxiao [this message]
2021-06-21 8:53 ` [PATCH RESEND] RDMA/rxe: Don't overwrite errno from ib_umem_get() Zhu Yanjun
2021-06-22 0:06 ` Jason Gunthorpe
2021-06-22 0:07 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210621071456.4259-1-ice_yangxiao@163.com \
--to=ice_yangxiao@163.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=yangx.jy@fujitsu.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.