From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Jens Wiklander <jens.wiklander@linaro.org>,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: [PATCH 2/2] firmware: arm_ffa: Simplify probe function
Date: Mon, 21 Jun 2021 22:16:52 +0200 [thread overview]
Message-ID: <20210621201652.127611-2-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <20210621201652.127611-1-u.kleine-koenig@pengutronix.de>
When the driver core calls the probe callback it already checked that
the devices match, so there is no need to call the match callback again.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/firmware/arm_ffa/bus.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/firmware/arm_ffa/bus.c b/drivers/firmware/arm_ffa/bus.c
index d2cc24319626..00fe595a5bc8 100644
--- a/drivers/firmware/arm_ffa/bus.c
+++ b/drivers/firmware/arm_ffa/bus.c
@@ -46,9 +46,6 @@ static int ffa_device_probe(struct device *dev)
struct ffa_driver *ffa_drv = to_ffa_driver(dev->driver);
struct ffa_device *ffa_dev = to_ffa_dev(dev);
- if (!ffa_device_match(dev, dev->driver))
- return -ENODEV;
-
return ffa_drv->probe(ffa_dev);
}
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-21 20:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 20:16 [PATCH 1/2] firmware: arm_ffa: Ensure drivers provide a probe function Uwe Kleine-König
2021-06-21 20:16 ` Uwe Kleine-König [this message]
2021-06-23 13:56 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210621201652.127611-2-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=jens.wiklander@linaro.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.