All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PATCH v2 11/29] tcg/ppc: Support bswap flags
Date: Mon, 21 Jun 2021 16:18:31 -0700	[thread overview]
Message-ID: <20210621231849.1871164-12-richard.henderson@linaro.org> (raw)
In-Reply-To: <20210621231849.1871164-1-richard.henderson@linaro.org>

For INDEX_op_bswap32_i32, pass 0 for flags: input not zero-extended,
output does not need extension within the host 64-bit register.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 tcg/ppc/tcg-target.c.inc | 22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

diff --git a/tcg/ppc/tcg-target.c.inc b/tcg/ppc/tcg-target.c.inc
index da6d10722e..33f0139519 100644
--- a/tcg/ppc/tcg-target.c.inc
+++ b/tcg/ppc/tcg-target.c.inc
@@ -789,7 +789,7 @@ static inline void tcg_out_sari64(TCGContext *s, TCGReg dst, TCGReg src, int c)
     tcg_out32(s, SRADI | RA(dst) | RS(src) | SH(c & 0x1f) | ((c >> 4) & 2));
 }
 
-static void tcg_out_bswap16(TCGContext *s, TCGReg dst, TCGReg src)
+static void tcg_out_bswap16(TCGContext *s, TCGReg dst, TCGReg src, int flags)
 {
     TCGReg tmp = dst == src ? TCG_REG_R0 : dst;
 
@@ -804,10 +804,14 @@ static void tcg_out_bswap16(TCGContext *s, TCGReg dst, TCGReg src)
     /* tmp = dep(tmp, rol32(src, 8), 0x0000ff00)    = 000000dc */
     tcg_out_rlw(s, RLWIMI, tmp, src, 8, 16, 23);
 
-    tcg_out_mov(s, TCG_TYPE_REG, dst, tmp);
+    if (flags & TCG_BSWAP_OS) {
+        tcg_out_ext16s(s, dst, tmp);
+    } else {
+        tcg_out_mov(s, TCG_TYPE_REG, dst, tmp);
+    }
 }
 
-static void tcg_out_bswap32(TCGContext *s, TCGReg dst, TCGReg src)
+static void tcg_out_bswap32(TCGContext *s, TCGReg dst, TCGReg src, int flags)
 {
     TCGReg tmp = dst == src ? TCG_REG_R0 : dst;
 
@@ -825,7 +829,11 @@ static void tcg_out_bswap32(TCGContext *s, TCGReg dst, TCGReg src)
     /* tmp = dep(tmp, rol32(src, 24), 0x0000ff00)   = 0000dcba */
     tcg_out_rlw(s, RLWIMI, tmp, src, 24, 16, 23);
 
-    tcg_out_mov(s, TCG_TYPE_REG, dst, tmp);
+    if (flags & TCG_BSWAP_OS) {
+        tcg_out_ext32s(s, dst, tmp);
+    } else {
+        tcg_out_mov(s, TCG_TYPE_REG, dst, tmp);
+    }
 }
 
 static void tcg_out_bswap64(TCGContext *s, TCGReg dst, TCGReg src)
@@ -2851,11 +2859,13 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc,
 
     case INDEX_op_bswap16_i32:
     case INDEX_op_bswap16_i64:
-        tcg_out_bswap16(s, args[0], args[1]);
+        tcg_out_bswap16(s, args[0], args[1], args[2]);
         break;
     case INDEX_op_bswap32_i32:
+        tcg_out_bswap32(s, args[0], args[1], 0);
+        break;
     case INDEX_op_bswap32_i64:
-        tcg_out_bswap32(s, args[0], args[1]);
+        tcg_out_bswap32(s, args[0], args[1], args[2]);
         break;
     case INDEX_op_bswap64_i64:
         tcg_out_bswap64(s, args[0], args[1]);
-- 
2.25.1



  parent reply	other threads:[~2021-06-21 23:27 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-21 23:18 [PATCH v2 00/29] tcg: bswap improvements Richard Henderson
2021-06-21 23:18 ` [PATCH v2 01/29] tcg: Add flags argument to bswap opcodes Richard Henderson
2021-06-21 23:18 ` [PATCH v2 02/29] tcg/i386: Support bswap flags Richard Henderson
2021-06-21 23:18 ` [PATCH v2 03/29] tcg/aarch64: Merge tcg_out_rev{16,32,64} Richard Henderson
2021-06-21 23:18 ` [PATCH v2 04/29] tcg/aarch64: Support bswap flags Richard Henderson
2021-06-21 23:18 ` [PATCH v2 05/29] tcg/arm: " Richard Henderson
2021-06-21 23:18 ` [PATCH v2 06/29] tcg/ppc: Split out tcg_out_ext{8,16,32}s Richard Henderson
2021-06-21 23:18 ` [PATCH v2 07/29] tcg/ppc: Split out tcg_out_sari{32,64} Richard Henderson
2021-06-21 23:18 ` [PATCH v2 08/29] tcg/ppc: Split out tcg_out_bswap16 Richard Henderson
2021-06-21 23:18 ` [PATCH v2 09/29] tcg/ppc: Split out tcg_out_bswap32 Richard Henderson
2021-06-21 23:18 ` [PATCH v2 10/29] tcg/ppc: Split out tcg_out_bswap64 Richard Henderson
2021-06-21 23:18 ` Richard Henderson [this message]
2021-06-21 23:18 ` [PATCH v2 12/29] tcg/ppc: Use power10 byte-reverse instructions Richard Henderson
2021-06-21 23:18 ` [PATCH v2 13/29] tcg/s390: Support bswap flags Richard Henderson
2021-06-21 23:18 ` [PATCH v2 14/29] tcg/mips: Support bswap flags in tcg_out_bswap16 Richard Henderson
2021-06-22  6:48   ` Philippe Mathieu-Daudé
2021-06-21 23:18 ` [PATCH v2 15/29] tcg/mips: Support bswap flags in tcg_out_bswap32 Richard Henderson
2021-06-21 23:18 ` [PATCH v2 16/29] tcg/tci: Support bswap flags Richard Henderson
2021-06-21 23:18 ` [PATCH v2 17/29] tcg: Handle new bswap flags during optimize Richard Henderson
2021-06-21 23:18 ` [PATCH v2 18/29] tcg: Add flags argument to tcg_gen_bswap16_*, tcg_gen_bswap32_i64 Richard Henderson
2021-06-21 23:18 ` [PATCH v2 19/29] tcg: Make use of bswap flags in tcg_gen_qemu_ld_* Richard Henderson
2021-06-22  6:46   ` Philippe Mathieu-Daudé
2021-06-21 23:18 ` [PATCH v2 20/29] tcg: Make use of bswap flags in tcg_gen_qemu_st_* Richard Henderson
2021-06-21 23:18 ` [PATCH v2 21/29] target/arm: Improve REV32 Richard Henderson
2021-06-21 23:18 ` [PATCH v2 22/29] target/arm: Improve vector REV Richard Henderson
2021-06-22  6:47   ` Philippe Mathieu-Daudé
2021-06-21 23:18 ` [PATCH v2 23/29] target/arm: Improve REVSH Richard Henderson
2021-06-21 23:18 ` [PATCH v2 24/29] target/i386: Improve bswap translation Richard Henderson
2021-06-21 23:18 ` [PATCH v2 25/29] target/sh4: Improve swap.b translation Richard Henderson
2021-06-21 23:18 ` [PATCH v2 26/29] target/mips: Fix gen_mxu_s32ldd_s32lddr Richard Henderson
2021-06-21 23:18 ` [PATCH v2 27/29] tcg/arm: Unset TCG_TARGET_HAS_MEMORY_BSWAP Richard Henderson
2021-06-21 23:18 ` [PATCH v2 28/29] tcg/aarch64: " Richard Henderson
2021-06-21 23:18 ` [PATCH v2 29/29] tcg/riscv: Remove MO_BSWAP handling Richard Henderson
2021-06-21 23:45 ` [PATCH v2 00/29] tcg: bswap improvements no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210621231849.1871164-12-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.