All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: bpf@vger.kernel.org, netdev@vger.kernel.org
Cc: "Martin KaFai Lau" <kafai@fb.com>,
	"Hangbin Liu" <liuhangbin@gmail.com>,
	"Jesper Dangaard Brouer" <brouer@redhat.com>,
	"Magnus Karlsson" <magnus.karlsson@gmail.com>,
	"Paul E . McKenney" <paulmck@kernel.org>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Toke Høiland-Jørgensen" <toke@redhat.com>
Subject: [PATCH bpf-next v5 03/19] doc: Give XDP as example of non-obvious RCU reader/updater pairing
Date: Thu, 24 Jun 2021 18:05:53 +0200	[thread overview]
Message-ID: <20210624160609.292325-4-toke@redhat.com> (raw)
In-Reply-To: <20210624160609.292325-1-toke@redhat.com>

This commit gives an example of non-obvious RCU reader/updater pairing
in the guise of the XDP feature in networking, which calls BPF programs
from network-driver NAPI (softirq) context.

Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
---
 Documentation/RCU/checklist.rst | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/Documentation/RCU/checklist.rst b/Documentation/RCU/checklist.rst
index 07f6cb8f674d..01cc21f17f7b 100644
--- a/Documentation/RCU/checklist.rst
+++ b/Documentation/RCU/checklist.rst
@@ -236,8 +236,15 @@ over a rather long period of time, but improvements are always welcome!
 
 	Mixing things up will result in confusion and broken kernels, and
 	has even resulted in an exploitable security issue.  Therefore,
-	when using non-obvious pairs of primitives, commenting is of
-	course a must.
+	when using non-obvious pairs of primitives, commenting is
+	of course a must.  One example of non-obvious pairing is
+	the XDP feature in networking, which calls BPF programs from
+	network-driver NAPI (softirq) context.	BPF relies heavily on RCU
+	protection for its data structures, but because the BPF program
+	invocation happens entirely within a single local_bh_disable()
+	section in a NAPI poll cycle, this usage is safe.  The reason
+	that this usage is safe is that readers can use anything that
+	disables BH when updaters use call_rcu() or synchronize_rcu().
 
 8.	Although synchronize_rcu() is slower than is call_rcu(), it
 	usually results in simpler code.  So, unless update performance is
-- 
2.32.0


  parent reply	other threads:[~2021-06-24 16:06 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24 16:05 [PATCH bpf-next v5 00/19] Clean up and document RCU-based object protection for XDP and TC BPF Toke Høiland-Jørgensen
2021-06-24 16:05 ` [PATCH bpf-next v5 01/19] rcu: Create an unrcu_pointer() to remove __rcu from a pointer Toke Høiland-Jørgensen
2021-06-24 16:05 ` [PATCH bpf-next v5 02/19] doc: Clarify and expand RCU updaters and corresponding readers Toke Høiland-Jørgensen
2021-06-24 16:05 ` Toke Høiland-Jørgensen [this message]
2021-06-24 16:05 ` [PATCH bpf-next v5 04/19] bpf: allow RCU-protected lookups to happen from bh context Toke Høiland-Jørgensen
2021-06-24 16:05 ` [PATCH bpf-next v5 05/19] xdp: add proper __rcu annotations to redirect map entries Toke Høiland-Jørgensen
2021-06-24 16:05 ` [PATCH bpf-next v5 06/19] sched: remove unneeded rcu_read_lock() around BPF program invocation Toke Høiland-Jørgensen
2021-06-24 16:05 ` [PATCH bpf-next v5 07/19] ena: remove rcu_read_lock() around XDP " Toke Høiland-Jørgensen
2021-06-24 16:05 ` [PATCH bpf-next v5 08/19] bnxt: " Toke Høiland-Jørgensen
2021-06-24 16:05 ` [PATCH bpf-next v5 09/19] thunderx: " Toke Høiland-Jørgensen
2021-06-24 16:05   ` Toke Høiland-Jørgensen
2021-06-24 16:06 ` [PATCH bpf-next v5 10/19] freescale: " Toke Høiland-Jørgensen
2021-06-24 16:06 ` [PATCH bpf-next v5 11/19] net: intel: " Toke Høiland-Jørgensen
2021-06-24 16:06   ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?=
2021-06-24 16:06 ` [PATCH bpf-next v5 12/19] marvell: " Toke Høiland-Jørgensen
2021-06-24 16:06 ` [PATCH bpf-next v5 13/19] mlx4: " Toke Høiland-Jørgensen
2021-06-24 16:06 ` [PATCH bpf-next v5 14/19] nfp: " Toke Høiland-Jørgensen
2021-06-24 16:06 ` [PATCH bpf-next v5 15/19] qede: " Toke Høiland-Jørgensen
2021-06-24 16:06 ` [PATCH bpf-next v5 16/19] sfc: " Toke Høiland-Jørgensen
2021-06-24 16:06 ` [PATCH bpf-next v5 17/19] netsec: " Toke Høiland-Jørgensen
2021-06-24 16:06 ` [PATCH bpf-next v5 18/19] stmmac: " Toke Høiland-Jørgensen
2021-06-24 16:06 ` [PATCH bpf-next v5 19/19] net: ti: " Toke Høiland-Jørgensen
2021-06-24 18:00 ` [PATCH bpf-next v5 00/19] Clean up and document RCU-based object protection for XDP and TC BPF patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210624160609.292325-4-toke@redhat.com \
    --to=toke@redhat.com \
    --cc=bpf@vger.kernel.org \
    --cc=brouer@redhat.com \
    --cc=kafai@fb.com \
    --cc=kuba@kernel.org \
    --cc=liuhangbin@gmail.com \
    --cc=magnus.karlsson@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=paulmck@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.