From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [PATCH v2 0/6] export/fuse: Allow other users access to the export
Date: Fri, 25 Jun 2021 16:23:11 +0200 [thread overview]
Message-ID: <20210625142317.271673-1-mreitz@redhat.com> (raw)
Hi,
The v1 cover letter is here:
https://lists.nongnu.org/archive/html/qemu-block/2021-06/msg00730.html
In v2, I changed the following:
- default_permissions is now passed always. This is the right thing to
do regardless of whether allow_other is active or not.
- allow_other is no longer a bool, but an off/on/auto enum. `auto` is
the default, in which case we will try to mount the export with
allow_other first, and then fall back to mounting it without.
- Changing the file mode is now possible even without allow_other
(because default_permissions is always active now), but only for the
user/owner. Giving the group or others any permissions only makes
sense with allow_other, the same applies to changing the UID or GID.
Giving a read-only export +w makes no sense and hence yields an EROFS
error now.
- I decided just testing some default_permission quirks is boring. So
the new fuse-allow-other iotest does rely on `sudo -n -u nobody`
working now, and actually tests what allow_other is supposed to do.
(Also, it is skipped if allow_other does not work.)
git-backport-diff against v1:
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
001/6:[down] 'export/fuse: Pass default_permissions for mount'
002/6:[0089] [FC] 'export/fuse: Add allow-other option'
003/6:[----] [--] 'export/fuse: Give SET_ATTR_SIZE its own branch'
004/6:[0039] [FC] 'export/fuse: Let permissions be adjustable'
005/6:[down] 'iotests/308: Test +w on read-only FUSE exports'
006/6:[down] 'iotests/fuse-allow-other: Test allow-other'
Max Reitz (6):
export/fuse: Pass default_permissions for mount
export/fuse: Add allow-other option
export/fuse: Give SET_ATTR_SIZE its own branch
export/fuse: Let permissions be adjustable
iotests/308: Test +w on read-only FUSE exports
iotests/fuse-allow-other: Test allow-other
qapi/block-export.json | 33 +++-
block/export/fuse.c | 121 +++++++++---
tests/qemu-iotests/308 | 20 +-
tests/qemu-iotests/308.out | 6 +-
tests/qemu-iotests/common.rc | 6 +-
tests/qemu-iotests/tests/fuse-allow-other | 175 ++++++++++++++++++
tests/qemu-iotests/tests/fuse-allow-other.out | 88 +++++++++
7 files changed, 421 insertions(+), 28 deletions(-)
create mode 100755 tests/qemu-iotests/tests/fuse-allow-other
create mode 100644 tests/qemu-iotests/tests/fuse-allow-other.out
--
2.31.1
next reply other threads:[~2021-06-25 14:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 14:23 Max Reitz [this message]
2021-06-25 14:23 ` [PATCH v2 1/6] export/fuse: Pass default_permissions for mount Max Reitz
2021-06-25 14:23 ` [PATCH v2 2/6] export/fuse: Add allow-other option Max Reitz
2021-07-07 10:37 ` Kevin Wolf
2021-06-25 14:23 ` [PATCH v2 3/6] export/fuse: Give SET_ATTR_SIZE its own branch Max Reitz
2021-06-25 14:23 ` [PATCH v2 4/6] export/fuse: Let permissions be adjustable Max Reitz
2021-06-25 14:23 ` [PATCH v2 5/6] iotests/308: Test +w on read-only FUSE exports Max Reitz
2021-06-25 14:23 ` [PATCH v2 6/6] iotests/fuse-allow-other: Test allow-other Max Reitz
2021-07-07 10:40 ` Kevin Wolf
2021-07-07 11:03 ` [PATCH v2 0/6] export/fuse: Allow other users access to the export Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210625142317.271673-1-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.