From: Martin Blumenstingl <martin.blumenstingl@googlemail.com> To: linux-clk@vger.kernel.org, sboyd@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Martin Blumenstingl <martin.blumenstingl@googlemail.com> Subject: [PATCH v1 1/6] clk: divider: Implement and wire up .determine_rate by default Date: Sat, 3 Jul 2021 00:51:40 +0200 [thread overview] Message-ID: <20210702225145.2643303-2-martin.blumenstingl@googlemail.com> (raw) In-Reply-To: <20210702225145.2643303-1-martin.blumenstingl@googlemail.com> .determine_rate is meant to replace .round_rate. The former comes with a benefit which is especially relevant on 32-bit systems: since .determine_rate uses an "unsigned long" (compared to a "signed long" which is used by .round_rate) the maximum value on 32-bit systems increases from 2^31 (or approx. 2.14GHz) to 2^32 (or approx. 4.29GHz). Implement .determine_rate in addition to .round_rate so drivers that are using clk_divider_{ro_,}ops can benefit from this by default. Keep the .round_rate callback for now since some drivers rely on clk_divider_ops.round_rate being implemented. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- drivers/clk/clk-divider.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c index 87ba4966b0e8..f6b2bf558486 100644 --- a/drivers/clk/clk-divider.c +++ b/drivers/clk/clk-divider.c @@ -446,6 +446,27 @@ static long clk_divider_round_rate(struct clk_hw *hw, unsigned long rate, divider->width, divider->flags); } +static int clk_divider_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) +{ + struct clk_divider *divider = to_clk_divider(hw); + + /* if read only, just return current value */ + if (divider->flags & CLK_DIVIDER_READ_ONLY) { + u32 val; + + val = clk_div_readl(divider) >> divider->shift; + val &= clk_div_mask(divider->width); + + return divider_ro_determine_rate(hw, req, divider->table, + divider->width, + divider->flags, val); + } + + return divider_determine_rate(hw, req, divider->table, divider->width, + divider->flags); +} + int divider_get_val(unsigned long rate, unsigned long parent_rate, const struct clk_div_table *table, u8 width, unsigned long flags) @@ -501,6 +522,7 @@ static int clk_divider_set_rate(struct clk_hw *hw, unsigned long rate, const struct clk_ops clk_divider_ops = { .recalc_rate = clk_divider_recalc_rate, .round_rate = clk_divider_round_rate, + .determine_rate = clk_divider_determine_rate, .set_rate = clk_divider_set_rate, }; EXPORT_SYMBOL_GPL(clk_divider_ops); @@ -508,6 +530,7 @@ EXPORT_SYMBOL_GPL(clk_divider_ops); const struct clk_ops clk_divider_ro_ops = { .recalc_rate = clk_divider_recalc_rate, .round_rate = clk_divider_round_rate, + .determine_rate = clk_divider_determine_rate, }; EXPORT_SYMBOL_GPL(clk_divider_ro_ops); -- 2.32.0
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com> To: linux-clk@vger.kernel.org, sboyd@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Martin Blumenstingl <martin.blumenstingl@googlemail.com> Subject: [PATCH v1 1/6] clk: divider: Implement and wire up .determine_rate by default Date: Sat, 3 Jul 2021 00:51:40 +0200 [thread overview] Message-ID: <20210702225145.2643303-2-martin.blumenstingl@googlemail.com> (raw) In-Reply-To: <20210702225145.2643303-1-martin.blumenstingl@googlemail.com> .determine_rate is meant to replace .round_rate. The former comes with a benefit which is especially relevant on 32-bit systems: since .determine_rate uses an "unsigned long" (compared to a "signed long" which is used by .round_rate) the maximum value on 32-bit systems increases from 2^31 (or approx. 2.14GHz) to 2^32 (or approx. 4.29GHz). Implement .determine_rate in addition to .round_rate so drivers that are using clk_divider_{ro_,}ops can benefit from this by default. Keep the .round_rate callback for now since some drivers rely on clk_divider_ops.round_rate being implemented. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- drivers/clk/clk-divider.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c index 87ba4966b0e8..f6b2bf558486 100644 --- a/drivers/clk/clk-divider.c +++ b/drivers/clk/clk-divider.c @@ -446,6 +446,27 @@ static long clk_divider_round_rate(struct clk_hw *hw, unsigned long rate, divider->width, divider->flags); } +static int clk_divider_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) +{ + struct clk_divider *divider = to_clk_divider(hw); + + /* if read only, just return current value */ + if (divider->flags & CLK_DIVIDER_READ_ONLY) { + u32 val; + + val = clk_div_readl(divider) >> divider->shift; + val &= clk_div_mask(divider->width); + + return divider_ro_determine_rate(hw, req, divider->table, + divider->width, + divider->flags, val); + } + + return divider_determine_rate(hw, req, divider->table, divider->width, + divider->flags); +} + int divider_get_val(unsigned long rate, unsigned long parent_rate, const struct clk_div_table *table, u8 width, unsigned long flags) @@ -501,6 +522,7 @@ static int clk_divider_set_rate(struct clk_hw *hw, unsigned long rate, const struct clk_ops clk_divider_ops = { .recalc_rate = clk_divider_recalc_rate, .round_rate = clk_divider_round_rate, + .determine_rate = clk_divider_determine_rate, .set_rate = clk_divider_set_rate, }; EXPORT_SYMBOL_GPL(clk_divider_ops); @@ -508,6 +530,7 @@ EXPORT_SYMBOL_GPL(clk_divider_ops); const struct clk_ops clk_divider_ro_ops = { .recalc_rate = clk_divider_recalc_rate, .round_rate = clk_divider_round_rate, + .determine_rate = clk_divider_determine_rate, }; EXPORT_SYMBOL_GPL(clk_divider_ro_ops); -- 2.32.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-02 22:52 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-02 22:51 [PATCH v1 0/6] clk: switch dividers to .determine_rate Martin Blumenstingl 2021-07-02 22:51 ` Martin Blumenstingl 2021-07-02 22:51 ` Martin Blumenstingl [this message] 2021-07-02 22:51 ` [PATCH v1 1/6] clk: divider: Implement and wire up .determine_rate by default Martin Blumenstingl 2021-08-06 1:10 ` Stephen Boyd 2021-08-06 1:10 ` Stephen Boyd 2021-10-14 9:55 ` Alex Bee 2021-10-14 9:55 ` Alex Bee 2021-10-14 9:55 ` Alex Bee 2021-10-14 12:11 ` Martin Blumenstingl 2021-10-14 12:11 ` Martin Blumenstingl 2021-10-14 12:11 ` Martin Blumenstingl 2021-10-14 21:34 ` Martin Blumenstingl 2021-10-14 21:34 ` Martin Blumenstingl 2021-10-14 21:34 ` Martin Blumenstingl 2021-10-14 22:52 ` Stephen Boyd 2021-10-14 22:52 ` Stephen Boyd 2021-10-14 22:52 ` Stephen Boyd 2021-10-15 12:05 ` [PATCH] clk: composite: Also consider .determine_rate for rate + mux composites Martin Blumenstingl 2021-10-15 12:05 ` Martin Blumenstingl 2021-10-15 12:05 ` Martin Blumenstingl 2021-10-15 21:27 ` Stephen Boyd 2021-10-15 21:27 ` Stephen Boyd 2021-10-15 21:27 ` Stephen Boyd 2021-11-01 20:19 ` Guillaume Tucker 2021-11-01 20:19 ` Guillaume Tucker 2021-11-01 20:19 ` Guillaume Tucker 2021-11-01 20:58 ` Martin Blumenstingl 2021-11-01 20:58 ` Martin Blumenstingl 2021-11-01 20:58 ` Martin Blumenstingl 2021-11-01 21:59 ` Robin Murphy 2021-11-01 21:59 ` Robin Murphy 2021-11-01 21:59 ` Robin Murphy 2021-11-01 22:11 ` Robin Murphy 2021-11-01 22:11 ` Robin Murphy 2021-11-01 22:11 ` Robin Murphy 2021-11-01 22:41 ` Alex Bee 2021-11-01 22:41 ` Alex Bee 2021-11-01 22:41 ` Alex Bee 2021-11-02 7:58 ` Guillaume Tucker 2021-11-02 7:58 ` Guillaume Tucker 2021-11-02 7:58 ` Guillaume Tucker 2021-11-02 21:40 ` LABBE Corentin 2021-11-02 21:40 ` Corentin Labbe 2021-11-02 21:40 ` LABBE Corentin 2021-11-02 21:40 ` LABBE Corentin 2021-10-15 19:14 ` [PATCH v1 1/6] clk: divider: Implement and wire up .determine_rate by default Alex Bee 2021-10-15 19:14 ` Alex Bee 2021-10-15 19:14 ` Alex Bee 2021-10-15 21:31 ` Stephen Boyd 2021-10-15 21:31 ` Stephen Boyd 2021-10-15 21:31 ` Stephen Boyd 2021-07-02 22:51 ` [PATCH v1 2/6] clk: imx: clk-divider-gate: Switch to clk_divider.determine_rate Martin Blumenstingl 2021-07-02 22:51 ` Martin Blumenstingl 2021-07-19 10:43 ` Abel Vesa 2021-07-19 10:43 ` Abel Vesa 2021-07-29 11:30 ` Abel Vesa 2021-07-29 11:30 ` Abel Vesa 2021-07-02 22:51 ` [PATCH v1 3/6] clk: bcm2835: " Martin Blumenstingl 2021-07-02 22:51 ` Martin Blumenstingl 2021-07-05 6:57 ` Marek Szyprowski 2021-07-05 6:57 ` Marek Szyprowski 2021-08-06 1:10 ` Stephen Boyd 2021-08-06 1:10 ` Stephen Boyd 2021-07-02 22:51 ` [PATCH v1 4/6] clk: stm32f4: " Martin Blumenstingl 2021-07-02 22:51 ` Martin Blumenstingl 2021-08-06 1:10 ` Stephen Boyd 2021-08-06 1:10 ` Stephen Boyd 2021-07-02 22:51 ` [PATCH v1 5/6] clk: stm32h7: " Martin Blumenstingl 2021-07-02 22:51 ` Martin Blumenstingl 2021-08-06 1:10 ` Stephen Boyd 2021-08-06 1:10 ` Stephen Boyd 2021-07-02 22:51 ` [PATCH v1 6/6] clk: stm32mp1: " Martin Blumenstingl 2021-07-02 22:51 ` Martin Blumenstingl 2021-08-06 1:10 ` Stephen Boyd 2021-08-06 1:10 ` Stephen Boyd 2021-08-03 19:32 ` [PATCH v1 0/6] clk: switch dividers to .determine_rate Martin Blumenstingl 2021-08-03 19:32 ` Martin Blumenstingl 2021-08-03 20:16 ` Stephen Boyd 2021-08-03 20:16 ` Stephen Boyd
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210702225145.2643303-2-martin.blumenstingl@googlemail.com \ --to=martin.blumenstingl@googlemail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=sboyd@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.